From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F3967C433F5 for ; Mon, 28 Feb 2022 07:38:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 7D98960AD8; Mon, 28 Feb 2022 07:38:33 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Htn04GpzICfx; Mon, 28 Feb 2022 07:38:32 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id 231A660768; Mon, 28 Feb 2022 07:38:32 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 04C19C0077; Mon, 28 Feb 2022 07:38:32 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E0444C001A for ; Mon, 28 Feb 2022 07:38:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BFB8940893 for ; Mon, 28 Feb 2022 07:38:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wS_RjPfUBKBh for ; Mon, 28 Feb 2022 07:38:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 2374040865 for ; Mon, 28 Feb 2022 07:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646033909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Wvjc6bhiBV/L81IMZEHXA+XZrxqHRvtBEx7es2Kbyc=; b=Rn9GtBcFISlL8AlYLOwwuxJN5XJqq9lXSl5MALTyf7kMcfOFz4jtZ8a2cy5MOUoCp0sjgL 9Y8terrC9nDC16Mk93yZIcmyHIjgp8AwMFIBtqRmASoj/8MIavEzDqzYZXkfTAvSrsbVSF sN6/RQavrcG826Wz/lqJbfz97yk7EYo= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-50-mg91jR_ePnaI93ZCub4rFA-1; Mon, 28 Feb 2022 02:38:27 -0500 X-MC-Unique: mg91jR_ePnaI93ZCub4rFA-1 Received: by mail-pl1-f197.google.com with SMTP id z14-20020a170902ccce00b0014d7a559635so4324866ple.16 for ; Sun, 27 Feb 2022 23:38:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0Wvjc6bhiBV/L81IMZEHXA+XZrxqHRvtBEx7es2Kbyc=; b=L0xduiqt+acBuBQCSmwp2RSx+ewMFJ6zGbti6JKlGqmLGIj9mJ6KdHy0Y0BvSFNex+ 4R3C+T35R0iTj4SNtjiY9R/mW540gOXRKjjAepHlqiMBW48JF+gExqt1TNU0EdT4mEmz UclpsBOD1fGLiO6FZ4kpH/WrhuXtmZx2L+YSVTvu7eQfTGB5iFSzMdzWh5LcX/BlV7hv FbomlqJWAxyjJfDjp+WZNsHcWbH7Ty7R6XZWr60DOnUgI9oomm2K3PBRgodW2nXTp7AC 1FgKlMJ36PnLpmCuatxYlxEFcVFNdoFNXTiut6YlPTnAmB2PkpRTjgEzP0F5TvGAjPow k97w== X-Gm-Message-State: AOAM533Z4A413IMav4GeLI5BdsH1mVzb2bKAtWYx8gy4k9i+ddMJ9Ho7 j4ayPBDF2nEf/8A6qQYpD9EGQZX/BGixd7YXd/r+joqquqzGtmkGt1D/iRY20PVQbiJd3CZaMQM 0kXbNazaRqtIfy4uHajNBCpvDLRQ5oRWsp3+wbUFZVQ== X-Received: by 2002:a17:902:82c5:b0:151:476b:c581 with SMTP id u5-20020a17090282c500b00151476bc581mr10390680plz.158.1646033906864; Sun, 27 Feb 2022 23:38:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwP9+aMD7qkw3m78bo1fiGWJvGsGa8g0OtxpeXajuBxQA1ADkbmlTIFUUJcGIaq2AozQF7/4g== X-Received: by 2002:a17:902:82c5:b0:151:476b:c581 with SMTP id u5-20020a17090282c500b00151476bc581mr10390639plz.158.1646033906603; Sun, 27 Feb 2022 23:38:26 -0800 (PST) Received: from [10.72.13.215] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id j13-20020a63594d000000b003639cf2f9c7sm9487274pgm.71.2022.02.27.23.38.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 23:38:26 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 15:38:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20220227134111.3254066-1-eperezma@redhat.com> <20220227134111.3254066-12-eperezma@redhat.com> From: Jason Wang In-Reply-To: <20220227134111.3254066-12-eperezma@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: "Michael S. Tsirkin" , virtualization@lists.linux-foundation.org, Eli Cohen , Eric Blake , Parav Pandit , Cindy Lu , "Fangyi \(Eric\)" , Markus Armbruster , yebiaoxiang@huawei.com, Liuxiangdong , Laurent Vivier , Eduardo Habkost , Richard Henderson , Gautam Dawar , Xiao W Wang , Stefan Hajnoczi , Harpreet Singh Anand , Paolo Bonzini , Lingshan X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIyLzIvMjcg5LiL5Y2IOTo0MSwgRXVnZW5pbyBQw6lyZXog5YaZ6YGTOgo+IFRoaXMg aXMgbmVlZGVkIHRvIGFjaGlldmUgbWlncmF0aW9uLCBzbyB0aGUgZGVzdGluYXRpb24gY2FuIHJl c3RvcmUgaXRzCj4gaW5kZXguCgoKSSBzdWdnZXN0IHRvIGR1cGxpY2F0ZSB0aGUgY29tbWVudCBi ZWxvdyBoZXJlLgoKVGhhbmtzCgoKPiBTaWduZWQtb2ZmLWJ5OiBFdWdlbmlvIFDDqXJleiA8ZXBl cmV6bWFAcmVkaGF0LmNvbT4KPiAtLS0KPiAgIGh3L3ZpcnRpby92aG9zdC12ZHBhLmMgfCAxNyAr KysrKysrKysrKysrKysrKwo+ICAgMSBmaWxlIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKykKPgo+ IGRpZmYgLS1naXQgYS9ody92aXJ0aW8vdmhvc3QtdmRwYS5jIGIvaHcvdmlydGlvL3Zob3N0LXZk cGEuYwo+IGluZGV4IDU2ZjlmMTI1Y2QuLmFjY2M0MDI0YzIgMTAwNjQ0Cj4gLS0tIGEvaHcvdmly dGlvL3Zob3N0LXZkcGEuYwo+ICsrKyBiL2h3L3ZpcnRpby92aG9zdC12ZHBhLmMKPiBAQCAtMTE4 MCw4ICsxMTgwLDI1IEBAIHN0YXRpYyBpbnQgdmhvc3RfdmRwYV9zZXRfdnJpbmdfYmFzZShzdHJ1 Y3Qgdmhvc3RfZGV2ICpkZXYsCj4gICBzdGF0aWMgaW50IHZob3N0X3ZkcGFfZ2V0X3ZyaW5nX2Jh c2Uoc3RydWN0IHZob3N0X2RldiAqZGV2LAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgc3RydWN0IHZob3N0X3ZyaW5nX3N0YXRlICpyaW5nKQo+ICAgewo+ICsgICAg c3RydWN0IHZob3N0X3ZkcGEgKnYgPSBkZXYtPm9wYXF1ZTsKPiAgICAgICBpbnQgcmV0Owo+ICAg Cj4gKyAgICBpZiAodi0+c2hhZG93X3Zxc19lbmFibGVkKSB7Cj4gKyAgICAgICAgVmhvc3RTaGFk b3dWaXJ0cXVldWUgKnN2cSA9IGdfcHRyX2FycmF5X2luZGV4KHYtPnNoYWRvd192cXMsCj4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJpbmct PmluZGV4KTsKPiArCj4gKyAgICAgICAgLyoKPiArICAgICAgICAgKiBTZXR0aW5nIGJhc2UgYXMg bGFzdCB1c2VkIGlkeCwgc28gZGVzdGluYXRpb24gd2lsbCBzZWUgYXMgYXZhaWxhYmxlCj4gKyAg ICAgICAgICogYWxsIHRoZSBlbnRyaWVzIHRoYXQgdGhlIGRldmljZSBkaWQgbm90IHVzZSwgaW5j bHVkaW5nIHRoZSBpbi1mbGlnaHQKPiArICAgICAgICAgKiBwcm9jZXNzaW5nIG9uZXMuCj4gKyAg ICAgICAgICoKPiArICAgICAgICAgKiBUT0RPOiBUaGlzIGlzIG9rIGZvciBuZXR3b3JraW5nLCBi dXQgb3RoZXIga2luZHMgb2YgZGV2aWNlcyBtaWdodAo+ICsgICAgICAgICAqIGhhdmUgcHJvYmxl bXMgd2l0aCB0aGVzZSByZXRyYW5zbWlzc2lvbnMuCj4gKyAgICAgICAgICovCj4gKyAgICAgICAg cmluZy0+bnVtID0gc3ZxLT5sYXN0X3VzZWRfaWR4Owo+ICsgICAgICAgIHJldHVybiAwOwo+ICsg ICAgfQo+ICsKPiAgICAgICByZXQgPSB2aG9zdF92ZHBhX2NhbGwoZGV2LCBWSE9TVF9HRVRfVlJJ TkdfQkFTRSwgcmluZyk7Cj4gICAgICAgdHJhY2Vfdmhvc3RfdmRwYV9nZXRfdnJpbmdfYmFzZShk ZXYsIHJpbmctPmluZGV4LCByaW5nLT5udW0pOwo+ICAgICAgIHJldHVybiByZXQ7CgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlvbiBt YWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKaHR0 cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVhbGl6 YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44E8EC433F5 for ; Mon, 28 Feb 2022 07:46:42 +0000 (UTC) Received: from localhost ([::1]:56620 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOajx-0006cG-9m for qemu-devel@archiver.kernel.org; Mon, 28 Feb 2022 02:46:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOac5-0002pQ-Ug for qemu-devel@nongnu.org; Mon, 28 Feb 2022 02:38:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28183) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOac2-0004fo-H6 for qemu-devel@nongnu.org; Mon, 28 Feb 2022 02:38:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646033909; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Wvjc6bhiBV/L81IMZEHXA+XZrxqHRvtBEx7es2Kbyc=; b=Rn9GtBcFISlL8AlYLOwwuxJN5XJqq9lXSl5MALTyf7kMcfOFz4jtZ8a2cy5MOUoCp0sjgL 9Y8terrC9nDC16Mk93yZIcmyHIjgp8AwMFIBtqRmASoj/8MIavEzDqzYZXkfTAvSrsbVSF sN6/RQavrcG826Wz/lqJbfz97yk7EYo= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-HJGHjqOCO0ecSvUtF7UALw-1; Mon, 28 Feb 2022 02:38:28 -0500 X-MC-Unique: HJGHjqOCO0ecSvUtF7UALw-1 Received: by mail-pg1-f198.google.com with SMTP id bh9-20020a056a02020900b0036c0d29eb3eso6141738pgb.9 for ; Sun, 27 Feb 2022 23:38:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0Wvjc6bhiBV/L81IMZEHXA+XZrxqHRvtBEx7es2Kbyc=; b=JGoEt5QJiR2sz3lyHZ8lDc6TxvYlAt25pMKGgjyG2nkq4AyACsp+GJbLuOxua89DsT VhGBWuZjDQJM/Tv6i6z9M0Jq/EHSVPW+Mh9GaidkPL/ozwjw6w/DnDKbBO9NKetP4Wbo nVrfhFFbz4J7A+O5TC/2gXaXr+LTsS9qHk9e7VtTwoQwud+HjBcPsEo60PqhdvFHG6Rj CV+BidX0xiFkWw3KG0s1F5TZZpgpQniTrCf0K7v4Fg8WdtlBZKBTplM+is6bO9DtEOqT Bbj0pzC+cVKDcdefIg+8is4gTB+Vp3ZM0Smtdhz6Wp1H7sTX+AJkGxgvpkDpIjFe/qyj azbA== X-Gm-Message-State: AOAM531NRyBwc6DvXhtjX/OzDBrPbrwXo++Dgs3qZvlG7IbpyZ6v0PEA fUm+qopC7aYRH0JbVn5WPfAq1eAWSvnB90dyxmtlc/hZP9plR6z/kWEgphNUjqFndpGlAO75dp+ 6R3MOvkZ7Mu5vQNM= X-Received: by 2002:a17:902:82c5:b0:151:476b:c581 with SMTP id u5-20020a17090282c500b00151476bc581mr10390675plz.158.1646033906842; Sun, 27 Feb 2022 23:38:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwP9+aMD7qkw3m78bo1fiGWJvGsGa8g0OtxpeXajuBxQA1ADkbmlTIFUUJcGIaq2AozQF7/4g== X-Received: by 2002:a17:902:82c5:b0:151:476b:c581 with SMTP id u5-20020a17090282c500b00151476bc581mr10390639plz.158.1646033906603; Sun, 27 Feb 2022 23:38:26 -0800 (PST) Received: from [10.72.13.215] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id j13-20020a63594d000000b003639cf2f9c7sm9487274pgm.71.2022.02.27.23.38.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 23:38:26 -0800 (PST) Message-ID: Date: Mon, 28 Feb 2022 15:38:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20220227134111.3254066-1-eperezma@redhat.com> <20220227134111.3254066-12-eperezma@redhat.com> From: Jason Wang In-Reply-To: <20220227134111.3254066-12-eperezma@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Peter Xu , virtualization@lists.linux-foundation.org, Eli Cohen , Eric Blake , Parav Pandit , Cindy Lu , "Fangyi \(Eric\)" , Markus Armbruster , yebiaoxiang@huawei.com, Liuxiangdong , Stefano Garzarella , Laurent Vivier , Eduardo Habkost , Richard Henderson , Gautam Dawar , Xiao W Wang , Stefan Hajnoczi , Juan Quintela , Harpreet Singh Anand , Paolo Bonzini , Lingshan Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/2/27 下午9:41, Eugenio Pérez 写道: > This is needed to achieve migration, so the destination can restore its > index. I suggest to duplicate the comment below here. Thanks > Signed-off-by: Eugenio Pérez > --- > hw/virtio/vhost-vdpa.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index 56f9f125cd..accc4024c2 100644 > --- a/hw/virtio/vhost-vdpa.c > +++ b/hw/virtio/vhost-vdpa.c > @@ -1180,8 +1180,25 @@ static int vhost_vdpa_set_vring_base(struct vhost_dev *dev, > static int vhost_vdpa_get_vring_base(struct vhost_dev *dev, > struct vhost_vring_state *ring) > { > + struct vhost_vdpa *v = dev->opaque; > int ret; > > + if (v->shadow_vqs_enabled) { > + VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, > + ring->index); > + > + /* > + * Setting base as last used idx, so destination will see as available > + * all the entries that the device did not use, including the in-flight > + * processing ones. > + * > + * TODO: This is ok for networking, but other kinds of devices might > + * have problems with these retransmissions. > + */ > + ring->num = svq->last_used_idx; > + return 0; > + } > + > ret = vhost_vdpa_call(dev, VHOST_GET_VRING_BASE, ring); > trace_vhost_vdpa_get_vring_base(dev, ring->index, ring->num); > return ret;