[PATCH resend net-next] r8169: improve error message if no dedicated PHY driver is found

[PATCH resend net-next] r8169: improve error message if no dedicated PHY driver is found

[Heiner Kallweit]

There's a number of consumer mainboards where the BIOS leaves the PHY
in a state that it's reporting an invalid PHY ID. To detect such cases
add the PHY ID to the error message if no dedicated PHY driver is found.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
- accidently sent previous version from wrong mail account
---
 drivers/net/ethernet/realtek/r8169_main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index f70e36c20..7471fae53 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5197,7 +5197,8 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
 		/* Most chip versions fail with the genphy driver.
 		 * Therefore ensure that the dedicated PHY driver is loaded.
 		 */
-		dev_err(&pdev->dev, "realtek.ko not loaded, maybe it needs to be added to initramfs?\n");
+		dev_err(&pdev->dev, "no dedicated PHY driver found for PHY ID 0x%08x, maybe realtek.ko needs to be added to initramfs?\n",
+			tp->phydev->phy_id);
 		return -EUNATCH;
 	}
 
-- 
2.26.2

Re: [PATCH resend net-next] r8169: improve error message if no dedicated PHY driver is found

[David Miller]

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Mon, 27 Apr 2020 21:07:00 +0200

> There's a number of consumer mainboards where the BIOS leaves the PHY
> in a state that it's reporting an invalid PHY ID. To detect such cases
> add the PHY ID to the error message if no dedicated PHY driver is found.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> - accidently sent previous version from wrong mail account

Applied, thanks.