From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00850C5517A for ; Wed, 11 Nov 2020 15:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 911D8206A1 for ; Wed, 11 Nov 2020 15:42:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="Ho3JBDNN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727220AbgKKPmN (ORCPT ); Wed, 11 Nov 2020 10:42:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45724 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726812AbgKKPmN (ORCPT ); Wed, 11 Nov 2020 10:42:13 -0500 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A3FC0613D1 for ; Wed, 11 Nov 2020 07:42:12 -0800 (PST) Received: by mail-il1-x144.google.com with SMTP id l12so2382578ilo.1 for ; Wed, 11 Nov 2020 07:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Z9fVURIh1ER6ryj3li/bebG5BOkx6rFg0fsV5guNvWI=; b=Ho3JBDNNIVPE4/GwgCS1VzTOC770TDnSxBlntV0nhBGRbxZ59U7hm7+NsBw51FiB0u g3/XOj+ah9TAuRr4+bcoruY7D1dHifRt0oGdxEU6ZfygBGeqWmWn4ous38dhWzM3mni/ dtGoIZHhv0siIg/+usU/s+an5Is2f65bPVOrY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Z9fVURIh1ER6ryj3li/bebG5BOkx6rFg0fsV5guNvWI=; b=F9muDKK6+h9SBii7PEgelORF+Cg47indRuQOVH8yg3pLuqcZW6tXJjkLlAJDx4TYgI wjPzWvOcfy68poXoil2ErVrLmzcZdgv9TZEfdwMXqieWvw2I0nHZ1TReCSKS3iyxyxoP t13lgCLOunZiPMQmd4CLxWQoPczmV94GwaJLTjZC1G74aY52ZmrZU/6+DCFHDHl7Ub64 h+J4I+9FjWv9/uD67Nng8LEVOy7r3ACf4mFpZIh8mIJ5M/Zbqb9Uw57m6WzxtUqcXqEJ nheMl55UgVa8blre0SkZukHgdKcezmIUc/VExykHqpTPj8U2EB3+bF2CQ8AD4Sw+zCR6 ZELQ== X-Gm-Message-State: AOAM531GR0M0vMtd2/8eKLCtxailNQ9dalc4vJDjd+8W9t/KDSlzWldv 3Hvqx5LWG1TOSkFtVy0R2sIWGw== X-Google-Smtp-Source: ABdhPJwsr569jIVesYjxm/+fgY2MvsX62MIEDQSgyZMjjD+bNdv4lH2nZ/r/ftaN0VOKuA7ob5LlTg== X-Received: by 2002:a92:c88c:: with SMTP id w12mr20306988ilo.204.1605109332217; Wed, 11 Nov 2020 07:42:12 -0800 (PST) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id i18sm1471925ile.73.2020.11.11.07.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 07:42:11 -0800 (PST) Subject: Re: [PATCH 01/13] seqnum_ops: Introduce Sequence Number Ops To: Kees Cook Cc: Matthew Wilcox , corbet@lwn.net, gregkh@linuxfoundation.org, peterz@infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20201110210316.GO17076@casper.infradead.org> <11b5153f-e092-d1c9-deb1-e81a171bb866@linuxfoundation.org> <202011101619.341C9C7E64@keescook> From: Shuah Khan Message-ID: Date: Wed, 11 Nov 2020 08:42:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <202011101619.341C9C7E64@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/10/20 5:20 PM, Kees Cook wrote: > On Tue, Nov 10, 2020 at 03:58:48PM -0700, Shuah Khan wrote: >> Yes we have some instances where unsigned is being used. I considered >> going to unsigned. Changing the API to unsigned has other ramifications >> and cascading changes to current atomic_t usages that are up counters. > > As in, existing callers expect the "read" value to be int? > Correct. In addition, these values are returned by other functions as signed and it will result in lot of churn to use unsigned. thanks, -- Shuah