From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E3B8C3815B for ; Wed, 15 Apr 2020 08:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E3B2206F9 for ; Wed, 15 Apr 2020 08:46:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="F3qihdN+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894966AbgDOIqj (ORCPT ); Wed, 15 Apr 2020 04:46:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2894960AbgDOIqK (ORCPT ); Wed, 15 Apr 2020 04:46:10 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A50A4C061A0F for ; Wed, 15 Apr 2020 01:46:09 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f13so18078060wrm.13 for ; Wed, 15 Apr 2020 01:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lb3moszYSo2LYaFHhhjcM4cay/uCeXv+Lh9QwOM6xww=; b=F3qihdN+hdMsdaequFznceWvdWp2yRYp6M0u/gv/QPRYwCuF2F2BEBTam/Ubmu2DiB kQ2LjUBrvbB+hZ2Jj1eu4mFZ8lgMGCOHya0X7hcjtf2QIDKHwMw0QARNb0d9qPXd+H4I KzgFFFraGgC73Dd8b8TRiZAIG+0uejxT3AGlQH/8z+9cTcMJoqQAB/+D9Fwl/9kgWGgM pbIPOW14C/NSHaQOOIT46SiQp5B1gjfncnD/JwBI5gQngJ/wO4Hun+WdyU+9z+ggwde4 ix0LeV+ClcRiv6mtmh4ZHgkbvoB3cWAPQNo0I+1y8hu2CnRhT0BLqu3NhQUbKAcDcgEP zRpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lb3moszYSo2LYaFHhhjcM4cay/uCeXv+Lh9QwOM6xww=; b=ay86R1iMRRfJcNiE8ZD6FSXMt8p93F5FiHqPk8W2GPA48hhf17iS7z4dg21JI+mFYn qw7oulno2p3FhwijJviD1DizMm8cZYee6M+SFT9ADMZqR8JlgMJetlLyRHrVOmDiVEqB ZPuBvw6Wvrh13EbASOJOZMN+YSY0UPiZqGA10VLLb+2rmWaZ7UFckSYV53yXJHqTRTEH Q/qazusi1w21ARS+YFqfT7GpuKO8kWdkNw2yuQNGp/cQuzIVfuLF1kDLzXMORX8RAzNa ont+jAfTiKj/vm6AS2gmewvQxporU/CvEMvwXWMN4qTkiusubfa9JEctQ+IqUFDKaudN rKKA== X-Gm-Message-State: AGi0PubqE2WfgiFHzZwKkooEkMF+XTMuHEeFYjLUzmOALN7NIKYgrhVS sSt5bmCuxTsXE0qxjeQVF1up5w== X-Google-Smtp-Source: APiQypJX2Hn8rvIm/Bda14cICmCTQkvC79OqyYyl28y3z6WA9exR5415whsbX7Vr7wHEoZBySMlD3g== X-Received: by 2002:adf:ce0a:: with SMTP id p10mr12446654wrn.89.1586940368320; Wed, 15 Apr 2020 01:46:08 -0700 (PDT) Received: from [192.168.86.34] (cpc89974-aztw32-2-0-cust43.18-1.cable.virginm.net. [86.30.250.44]) by smtp.googlemail.com with ESMTPSA id n124sm22480815wma.11.2020.04.15.01.46.07 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Apr 2020 01:46:07 -0700 (PDT) Subject: Re: [PATCH v2] nvmem: core: don't consider subnodes not matching binding To: Ahmad Fatoum Cc: devicetree@vger.kernel.org, Christian Eggers , linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20200323152850.32657-1-a.fatoum@pengutronix.de> <4e861088-c17d-0eca-6efa-c50b55fdecd1@pengutronix.de> From: Srinivas Kandagatla Message-ID: Date: Wed, 15 Apr 2020 09:46:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <4e861088-c17d-0eca-6efa-c50b55fdecd1@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/2020 09:05, Ahmad Fatoum wrote: >> - If the cell has a compatible node, it must be "nvmem-cell". >> Otherwise, a cell with a compatible node is skipped. >> This one sounds more sensible! If we go this way, it needs to be properly documented in the bindings too. >> - Adding a nvmem cell container with a compatible and making support for >> the old binding configurable Older bindings should be still supported but we should encourage to use compatible string for new additions. >> >> - Skipping cells that are malformed and lack a reg = < > property_without_ >> error Currently we only support Offset and Size with address cell and size cells of 1. Adding an extra check here to see if its malformed makes sense too! Thanks, srini > gentle ping. I can prepare another patch if you indicate which approach > you'd prefer. >