From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753332AbeCFJxe (ORCPT ); Tue, 6 Mar 2018 04:53:34 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:40589 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750897AbeCFJxc (ORCPT ); Tue, 6 Mar 2018 04:53:32 -0500 X-Google-Smtp-Source: AG47ELvrVXPOgQ9LJaXn/lnXuq516VLp69p8pwO/yflXkEwUxkaxxli812Xy37YROo6L1tkNzhENMA== Subject: Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs To: architt@codeaurora.org Cc: airlied@linux.ie, a.hajda@samsung.com, Jose.Abreu@synopsys.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <1519386277-25902-1-git-send-email-narmstrong@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: Date: Tue, 6 Mar 2018 10:53:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519386277-25902-1-git-send-email-narmstrong@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Architt, On 23/02/2018 12:44, Neil Armstrong wrote: > The Amlogic Meson GX SoCs, embedded the v2.01a controller, has been also > identified needing this workaround. > This patch adds the corresponding version to enable a single iteration for > this specific version. > > Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version") > Signed-off-by: Neil Armstrong > --- > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > index a38db40..f5018f9 100644 > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > @@ -1637,6 +1637,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > * (and possibly on the platform). So far only i.MX6Q (v1.30a) and > * i.MX6DL (v1.31a) have been identified as needing the workaround, with > * 4 and 1 iterations respectively. > + * The Amlogic Meson GX SoCs (v2.01a) have been identifies as needing > + * the workaround with a single iteration. > */ > > switch (hdmi->version) { > @@ -1644,6 +1646,7 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi) > count = 4; > break; > case 0x131a: > + case 0x201a: > count = 1; > break; > default: > This fixes a long time issue on Amlogic SoCs, is it ok for you ? Thanks, Neil From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Amlogic Meson GX SoCs Date: Tue, 6 Mar 2018 10:53:29 +0100 Message-ID: References: <1519386277-25902-1-git-send-email-narmstrong@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0465A6E602 for ; Tue, 6 Mar 2018 09:53:32 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id i3so20900141wmi.4 for ; Tue, 06 Mar 2018 01:53:32 -0800 (PST) In-Reply-To: <1519386277-25902-1-git-send-email-narmstrong@baylibre.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: architt@codeaurora.org Cc: airlied@linux.ie, Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgQXJjaGl0dCwKCk9uIDIzLzAyLzIwMTggMTI6NDQsIE5laWwgQXJtc3Ryb25nIHdyb3RlOgo+ IFRoZSBBbWxvZ2ljIE1lc29uIEdYIFNvQ3MsIGVtYmVkZGVkIHRoZSB2Mi4wMWEgY29udHJvbGxl ciwgaGFzIGJlZW4gYWxzbwo+IGlkZW50aWZpZWQgbmVlZGluZyB0aGlzIHdvcmthcm91bmQuCj4g VGhpcyBwYXRjaCBhZGRzIHRoZSBjb3JyZXNwb25kaW5nIHZlcnNpb24gdG8gZW5hYmxlIGEgc2lu Z2xlIGl0ZXJhdGlvbiBmb3IKPiB0aGlzIHNwZWNpZmljIHZlcnNpb24uCj4gCj4gRml4ZXM6IGJl NDFmYzU1ZjFhYSAoImRybTogYnJpZGdlOiBkdy1oZG1pOiBIYW5kbGUgb3ZlcmZsb3cgd29ya2Fy b3VuZCBiYXNlZCBvbiBkZXZpY2UgdmVyc2lvbiIpCj4gU2lnbmVkLW9mZi1ieTogTmVpbCBBcm1z dHJvbmcgPG5hcm1zdHJvbmdAYmF5bGlicmUuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0v YnJpZGdlL3N5bm9wc3lzL2R3LWhkbWkuYyB8IDMgKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5v cHN5cy9kdy1oZG1pLmMgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3N5bm9wc3lzL2R3LWhkbWku Ywo+IGluZGV4IGEzOGRiNDAuLmY1MDE4ZjkgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2JyaWRnZS9zeW5vcHN5cy9kdy1oZG1pLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdl L3N5bm9wc3lzL2R3LWhkbWkuYwo+IEBAIC0xNjM3LDYgKzE2MzcsOCBAQCBzdGF0aWMgdm9pZCBk d19oZG1pX2NsZWFyX292ZXJmbG93KHN0cnVjdCBkd19oZG1pICpoZG1pKQo+ICAJICogKGFuZCBw b3NzaWJseSBvbiB0aGUgcGxhdGZvcm0pLiBTbyBmYXIgb25seSBpLk1YNlEgKHYxLjMwYSkgYW5k Cj4gIAkgKiBpLk1YNkRMICh2MS4zMWEpIGhhdmUgYmVlbiBpZGVudGlmaWVkIGFzIG5lZWRpbmcg dGhlIHdvcmthcm91bmQsIHdpdGgKPiAgCSAqIDQgYW5kIDEgaXRlcmF0aW9ucyByZXNwZWN0aXZl bHkuCj4gKwkgKiBUaGUgQW1sb2dpYyBNZXNvbiBHWCBTb0NzICh2Mi4wMWEpIGhhdmUgYmVlbiBp ZGVudGlmaWVzIGFzIG5lZWRpbmcKPiArCSAqIHRoZSB3b3JrYXJvdW5kIHdpdGggYSBzaW5nbGUg aXRlcmF0aW9uLgo+ICAJICovCj4gIAo+ICAJc3dpdGNoIChoZG1pLT52ZXJzaW9uKSB7Cj4gQEAg LTE2NDQsNiArMTY0Niw3IEBAIHN0YXRpYyB2b2lkIGR3X2hkbWlfY2xlYXJfb3ZlcmZsb3coc3Ry dWN0IGR3X2hkbWkgKmhkbWkpCj4gIAkJY291bnQgPSA0Owo+ICAJCWJyZWFrOwo+ICAJY2FzZSAw eDEzMWE6Cj4gKwljYXNlIDB4MjAxYToKPiAgCQljb3VudCA9IDE7Cj4gIAkJYnJlYWs7Cj4gIAlk ZWZhdWx0Ogo+IAoKVGhpcyBmaXhlcyBhIGxvbmcgdGltZSBpc3N1ZSBvbiBBbWxvZ2ljIFNvQ3Ms IGlzIGl0IG9rIGZvciB5b3UgPwoKVGhhbmtzLApOZWlsCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=