From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E475EC8300C for ; Thu, 30 Apr 2020 10:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B45DB20787 for ; Thu, 30 Apr 2020 10:19:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TFJz3jN9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726760AbgD3KTY (ORCPT ); Thu, 30 Apr 2020 06:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725280AbgD3KTU (ORCPT ); Thu, 30 Apr 2020 06:19:20 -0400 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 545DDC035494; Thu, 30 Apr 2020 03:19:20 -0700 (PDT) Received: by mail-wm1-x343.google.com with SMTP id 188so1209357wmc.2; Thu, 30 Apr 2020 03:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=sbJYXBlwGOLyg45ji2Ben6BeJhkkj20b9i5FNHgQc7E=; b=TFJz3jN9l51rL4sTRvaVWsNqtueSOmy0YG5dmVZvHcJy4oBNjiahe+LWXBQ0omqKGM k7U8HX+i6gwboswmMM7LMM5IqcT/1ixfnPbCg01AUcEawoXsvhW+xg4wFcvwqXc43gCn YIs3qJp5bEZip/9tf6qhMdsNPfeL35Mpa1g65e2pAW+fWeuDCst9JFRU/M8BgsFUinDW 57orgljHmHwzOmTgSVrus7Z8x+jt8+/w2xmYoJvrSoURGhlCdILwZFdpxVXbagM+kb+r qUJPqKJ/EMBwrKf1/klC0EuRmjlzYmMorc7Q1VCfgjiqikXPAyLFcaqhN/744J1VABTH Yr5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=sbJYXBlwGOLyg45ji2Ben6BeJhkkj20b9i5FNHgQc7E=; b=eVl4mfW0dlC4oxXblQ8IiUuenVskuu06Ms6bGxi1cAGPUSBe5eW1PlRDcG0tQ43x0j 7txD2WPTuw++wIuAKrncABDfRpb9FkeWNkEnYtshLh5mL42PkWvkMhsy9rX6TLaywPby bPt9d6O7Y8/LzQZ3vwPJD7BzpYxhPADSUCGrZxkno6eqg0KsdMlKw8gY6el9NCwAzhON HRimerOkVI1XIhyp6aBHxp4FzpV/kiagfNeDL+Un2kWFnpbJcfr+C2OeG3wa5nFL+DvS cBKjYYQvLtLVcKqzSJSn4ph2Cb/UET0dNf168qgGtyBhinbbkdA6nc/MwNy/T2s04e41 lBLg== X-Gm-Message-State: AGi0PuZSBVobo2mHZwWZTphV4Tcj8r3DL9M6J3L0WdxmGzZ+UmmdFnUV lIHdnH233VqSvJe9Iv1uwuc= X-Google-Smtp-Source: APiQypIFiyR1IL2f8nMpAUjauJb0orpbTeK/JIXN9qbR7trpNDpfeWSNlZ611isWlDjsKZ6MpJqPYA== X-Received: by 2002:a1c:770f:: with SMTP id t15mr2141356wmi.178.1588241956107; Thu, 30 Apr 2020 03:19:16 -0700 (PDT) Received: from [192.168.43.138] ([37.142.166.235]) by smtp.gmail.com with ESMTPSA id 185sm13450326wmc.32.2020.04.30.03.19.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 03:19:15 -0700 (PDT) Subject: Re: [PATCH v7 2/7] tpm: tpm_tis: Add verify_data_integrity handle toy tpm_tis_phy_ops To: Jarkko Sakkinen Cc: Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com, alexander.steffen@infineon.com, robh+dt@kernel.org, mark.rutland@arm.com, peterhuewe@gmx.de, jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org, benoit.houyere@st.com, eajames@linux.ibm.com, joel@jms.id.au, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com, tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com, Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com, shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com, Christophe Ricard References: <20200427124931.115697-1-amirmizi6@gmail.com> <20200427124931.115697-3-amirmizi6@gmail.com> <20200429053456.GE8452@linux.intel.com> From: Amir Mizinski Message-ID: Date: Thu, 30 Apr 2020 10:19:09 +0000 User-Agent: Mozilla/5.0 (X11; Linux armv7l; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200429053456.GE8452@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-04-29 05:34, Jarkko Sakkinen wrote: > On Mon, Apr 27, 2020 at 03:49:26PM +0300, amirmizi6@gmail.com wrote: >> +    bool (*verify_data_integrity)(struct tpm_tis_data *data, const u8 *buf, >> +                      size_t len); > > Why can't the i2c driver verify this in the end of read_bytes()? > The TPM calculates the checksum of the entire command data at the end of command transmission or the checksum of the entire response data at the end of response transmission. read_bytes is not necessarily called at the end of response transmission. Same for write_bytes. > /Jarkko