* [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 17:23 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 17:23 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, daniel
Cc: intel-gfx, dri-devel, linux-kernel, Tom Rix
In insert_mappable_node(), the parameter node is
cleared late in node's use with memset.
insert_mappable_node() is a singleton, called only
from i915_gem_gtt_prepare() which itself is only
called by i915_gem_gtt_pread() and
i915_gem_gtt_pwrite_fast() where the definition of
node originates.
Instead of using memset, initialize node to 0 at it's
definitions. And remove unneeded clearing of the flags
element.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/i915/i915_gem.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2e10187cd0a0..7dbd0b325c43 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -69,7 +69,6 @@ insert_mappable_node(struct i915_ggtt *ggtt, struct drm_mm_node *node, u32 size)
if (err)
return err;
- memset(node, 0, sizeof(*node));
err = drm_mm_insert_node_in_range(&ggtt->vm.mm, node,
size, 0, I915_COLOR_UNEVICTABLE,
0, ggtt->mappable_end,
@@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
goto err_ww;
} else if (!IS_ERR(vma)) {
node->start = i915_ggtt_offset(vma);
- node->flags = 0;
} else {
ret = insert_mappable_node(ggtt, node, PAGE_SIZE);
if (ret)
@@ -381,7 +379,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj,
struct drm_i915_private *i915 = to_i915(obj->base.dev);
struct i915_ggtt *ggtt = to_gt(i915)->ggtt;
intel_wakeref_t wakeref;
- struct drm_mm_node node;
+ struct drm_mm_node node = {};
void __user *user_data;
struct i915_vma *vma;
u64 remain, offset;
@@ -538,7 +536,7 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_gem_object *obj,
struct i915_ggtt *ggtt = to_gt(i915)->ggtt;
struct intel_runtime_pm *rpm = &i915->runtime_pm;
intel_wakeref_t wakeref;
- struct drm_mm_node node;
+ struct drm_mm_node node = {};
struct i915_vma *vma;
u64 remain, offset;
void __user *user_data;
--
2.27.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 17:23 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 17:23 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, daniel
Cc: Tom Rix, intel-gfx, linux-kernel, dri-devel
In insert_mappable_node(), the parameter node is
cleared late in node's use with memset.
insert_mappable_node() is a singleton, called only
from i915_gem_gtt_prepare() which itself is only
called by i915_gem_gtt_pread() and
i915_gem_gtt_pwrite_fast() where the definition of
node originates.
Instead of using memset, initialize node to 0 at it's
definitions. And remove unneeded clearing of the flags
element.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/i915/i915_gem.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2e10187cd0a0..7dbd0b325c43 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -69,7 +69,6 @@ insert_mappable_node(struct i915_ggtt *ggtt, struct drm_mm_node *node, u32 size)
if (err)
return err;
- memset(node, 0, sizeof(*node));
err = drm_mm_insert_node_in_range(&ggtt->vm.mm, node,
size, 0, I915_COLOR_UNEVICTABLE,
0, ggtt->mappable_end,
@@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
goto err_ww;
} else if (!IS_ERR(vma)) {
node->start = i915_ggtt_offset(vma);
- node->flags = 0;
} else {
ret = insert_mappable_node(ggtt, node, PAGE_SIZE);
if (ret)
@@ -381,7 +379,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj,
struct drm_i915_private *i915 = to_i915(obj->base.dev);
struct i915_ggtt *ggtt = to_gt(i915)->ggtt;
intel_wakeref_t wakeref;
- struct drm_mm_node node;
+ struct drm_mm_node node = {};
void __user *user_data;
struct i915_vma *vma;
u64 remain, offset;
@@ -538,7 +536,7 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_gem_object *obj,
struct i915_ggtt *ggtt = to_gt(i915)->ggtt;
struct intel_runtime_pm *rpm = &i915->runtime_pm;
intel_wakeref_t wakeref;
- struct drm_mm_node node;
+ struct drm_mm_node node = {};
struct i915_vma *vma;
u64 remain, offset;
void __user *user_data;
--
2.27.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 17:23 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 17:23 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, tvrtko.ursulin,
airlied, daniel
Cc: Tom Rix, intel-gfx, linux-kernel, dri-devel
In insert_mappable_node(), the parameter node is
cleared late in node's use with memset.
insert_mappable_node() is a singleton, called only
from i915_gem_gtt_prepare() which itself is only
called by i915_gem_gtt_pread() and
i915_gem_gtt_pwrite_fast() where the definition of
node originates.
Instead of using memset, initialize node to 0 at it's
definitions. And remove unneeded clearing of the flags
element.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/i915/i915_gem.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2e10187cd0a0..7dbd0b325c43 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -69,7 +69,6 @@ insert_mappable_node(struct i915_ggtt *ggtt, struct drm_mm_node *node, u32 size)
if (err)
return err;
- memset(node, 0, sizeof(*node));
err = drm_mm_insert_node_in_range(&ggtt->vm.mm, node,
size, 0, I915_COLOR_UNEVICTABLE,
0, ggtt->mappable_end,
@@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
goto err_ww;
} else if (!IS_ERR(vma)) {
node->start = i915_ggtt_offset(vma);
- node->flags = 0;
} else {
ret = insert_mappable_node(ggtt, node, PAGE_SIZE);
if (ret)
@@ -381,7 +379,7 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj,
struct drm_i915_private *i915 = to_i915(obj->base.dev);
struct i915_ggtt *ggtt = to_gt(i915)->ggtt;
intel_wakeref_t wakeref;
- struct drm_mm_node node;
+ struct drm_mm_node node = {};
void __user *user_data;
struct i915_vma *vma;
u64 remain, offset;
@@ -538,7 +536,7 @@ i915_gem_gtt_pwrite_fast(struct drm_i915_gem_object *obj,
struct i915_ggtt *ggtt = to_gt(i915)->ggtt;
struct intel_runtime_pm *rpm = &i915->runtime_pm;
intel_wakeref_t wakeref;
- struct drm_mm_node node;
+ struct drm_mm_node node = {};
struct i915_vma *vma;
u64 remain, offset;
void __user *user_data;
--
2.27.0
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: change node clearing from memset to initialization
2022-04-16 17:23 ` Tom Rix
(?)
(?)
@ 2022-04-16 18:07 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2022-04-16 18:07 UTC (permalink / raw)
To: Tom Rix; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 7432 bytes --]
== Series Details ==
Series: drm/i915: change node clearing from memset to initialization
URL : https://patchwork.freedesktop.org/series/102762/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11508 -> Patchwork_102762v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/index.html
Participating hosts (48 -> 47)
------------------------------
Additional (2): fi-kbl-soraka fi-icl-u2
Missing (3): bat-adlm-1 fi-bsw-cyan fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_102762v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-soraka: NOTRUN -> [SKIP][1] ([fdo#109271]) +9 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
- fi-icl-u2: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-icl-u2: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][6] ([i915#1886])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-g3258: [PASS][7] -> [INCOMPLETE][8] ([i915#4785])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-hsw-g3258/igt@i915_selftest@live@hangcheck.html
* igt@kms_busy@basic@modeset:
- fi-tgl-u2: [PASS][9] -> [DMESG-WARN][10] ([i915#402]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/fi-tgl-u2/igt@kms_busy@basic@modeset.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-tgl-u2/igt@kms_busy@basic@modeset.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-soraka: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-kbl-soraka/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: NOTRUN -> [SKIP][12] ([fdo#111827]) +8 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: NOTRUN -> [SKIP][13] ([fdo#109278]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-icl-u2: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-kbl-soraka: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#533])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-icl-u2: NOTRUN -> [SKIP][16] ([i915#3555])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-icl-u2: NOTRUN -> [SKIP][17] ([i915#3301])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-icl-u2/igt@prime_vgem@basic-userptr.html
* igt@runner@aborted:
- fi-hsw-g3258: NOTRUN -> [FAIL][18] ([fdo#109271] / [i915#4312])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/fi-hsw-g3258/igt@runner@aborted.html
#### Possible fixes ####
* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][19] ([i915#3576]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/bat-adlp-6/igt@kms_busy@basic@modeset.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/bat-adlp-6/igt@kms_busy@basic@modeset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4785]: https://gitlab.freedesktop.org/drm/intel/issues/4785
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
Build changes
-------------
* Linux: CI_DRM_11508 -> Patchwork_102762v1
CI-20190529: 20190529
CI_DRM_11508: 3036e366aa958325fd0d425a608bb14558d54507 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6438: 205a47d8f70e659df620573ce409d228c5762d11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102762v1: 3036e366aa958325fd0d425a608bb14558d54507 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
7568f36b31e6 drm/i915: change node clearing from memset to initialization
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/index.html
[-- Attachment #2: Type: text/html, Size: 8382 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
2022-04-16 17:23 ` Tom Rix
(?)
@ 2022-04-16 18:33 ` Joe Perches
-1 siblings, 0 replies; 17+ messages in thread
From: Joe Perches @ 2022-04-16 18:33 UTC (permalink / raw)
To: Tom Rix, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, dri-devel, linux-kernel
On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
> In insert_mappable_node(), the parameter node is
> cleared late in node's use with memset.
> insert_mappable_node() is a singleton, called only
> from i915_gem_gtt_prepare() which itself is only
> called by i915_gem_gtt_pread() and
> i915_gem_gtt_pwrite_fast() where the definition of
> node originates.
>
> Instead of using memset, initialize node to 0 at it's
> definitions.
trivia: /it's/its/
Only reason _not_ to do this is memset is guaranteed to
zero any padding that might go to userspace.
But it doesn't seem there is any padding anyway nor is
the struct available to userspace.
So this seems fine though it might increase overall code
size a tiny bit.
I do have a caveat: see below:
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
[]
> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
> goto err_ww;
> } else if (!IS_ERR(vma)) {
> node->start = i915_ggtt_offset(vma);
> - node->flags = 0;
Why is this unneeded?
from: drm_mm_insert_node_in_range which can set node->flags
__set_bit(DRM_MM_NODE_ALLOCATED_BIT, &node->flags);
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 18:33 ` Joe Perches
0 siblings, 0 replies; 17+ messages in thread
From: Joe Perches @ 2022-04-16 18:33 UTC (permalink / raw)
To: Tom Rix, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
> In insert_mappable_node(), the parameter node is
> cleared late in node's use with memset.
> insert_mappable_node() is a singleton, called only
> from i915_gem_gtt_prepare() which itself is only
> called by i915_gem_gtt_pread() and
> i915_gem_gtt_pwrite_fast() where the definition of
> node originates.
>
> Instead of using memset, initialize node to 0 at it's
> definitions.
trivia: /it's/its/
Only reason _not_ to do this is memset is guaranteed to
zero any padding that might go to userspace.
But it doesn't seem there is any padding anyway nor is
the struct available to userspace.
So this seems fine though it might increase overall code
size a tiny bit.
I do have a caveat: see below:
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
[]
> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
> goto err_ww;
> } else if (!IS_ERR(vma)) {
> node->start = i915_ggtt_offset(vma);
> - node->flags = 0;
Why is this unneeded?
from: drm_mm_insert_node_in_range which can set node->flags
__set_bit(DRM_MM_NODE_ALLOCATED_BIT, &node->flags);
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 18:33 ` Joe Perches
0 siblings, 0 replies; 17+ messages in thread
From: Joe Perches @ 2022-04-16 18:33 UTC (permalink / raw)
To: Tom Rix, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
> In insert_mappable_node(), the parameter node is
> cleared late in node's use with memset.
> insert_mappable_node() is a singleton, called only
> from i915_gem_gtt_prepare() which itself is only
> called by i915_gem_gtt_pread() and
> i915_gem_gtt_pwrite_fast() where the definition of
> node originates.
>
> Instead of using memset, initialize node to 0 at it's
> definitions.
trivia: /it's/its/
Only reason _not_ to do this is memset is guaranteed to
zero any padding that might go to userspace.
But it doesn't seem there is any padding anyway nor is
the struct available to userspace.
So this seems fine though it might increase overall code
size a tiny bit.
I do have a caveat: see below:
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
[]
> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
> goto err_ww;
> } else if (!IS_ERR(vma)) {
> node->start = i915_ggtt_offset(vma);
> - node->flags = 0;
Why is this unneeded?
from: drm_mm_insert_node_in_range which can set node->flags
__set_bit(DRM_MM_NODE_ALLOCATED_BIT, &node->flags);
^ permalink raw reply [flat|nested] 17+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: change node clearing from memset to initialization
2022-04-16 17:23 ` Tom Rix
` (3 preceding siblings ...)
(?)
@ 2022-04-16 19:14 ` Patchwork
-1 siblings, 0 replies; 17+ messages in thread
From: Patchwork @ 2022-04-16 19:14 UTC (permalink / raw)
To: Tom Rix; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 48265 bytes --]
== Series Details ==
Series: drm/i915: change node clearing from memset to initialization
URL : https://patchwork.freedesktop.org/series/102762/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11508_full -> Patchwork_102762v1_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102762v1_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_102762v1_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102762v1_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbcpsr-suspend:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-suspend.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_universal_plane@cursor-fb-leak-pipe-b:
- {shard-tglu}: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-tglu-4/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglu-8/igt@kms_universal_plane@cursor-fb-leak-pipe-b.html
Known issues
------------
Here are the changes found in Patchwork_102762v1_full that come from known issues:
### CI changes ###
#### Issues hit ####
* boot:
- shard-apl: ([PASS][5], [PASS][6], [PASS][7], [PASS][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29]) -> ([PASS][30], [PASS][31], [PASS][32], [FAIL][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54]) ([i915#4386])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl3/boot.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl3/boot.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl2/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl2/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl2/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl2/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl1/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl1/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl1/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl8/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl8/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl8/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl7/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl6/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl6/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl6/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl4/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl4/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl4/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl3/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl1/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl1/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl2/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl2/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl2/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl2/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl3/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl3/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl3/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl6/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl8/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl8/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl8/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl8/boot.html
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-skl: [PASS][55] -> [INCOMPLETE][56] ([i915#4793])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl10/igt@gem_ctx_isolation@preservation-s3@vcs0.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl4/igt@gem_ctx_isolation@preservation-s3@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][57] -> [FAIL][58] ([i915#2842])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-glk1/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [PASS][59] -> [FAIL][60] ([i915#2842])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-kbl7/igt@gem_exec_fair@basic-pace@vcs1.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-kbl4/igt@gem_exec_fair@basic-pace@vcs1.html
* igt@gem_exec_flush@basic-wb-ro-before-default:
- shard-snb: [PASS][61] -> [SKIP][62] ([fdo#109271]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-snb7/igt@gem_exec_flush@basic-wb-ro-before-default.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-snb6/igt@gem_exec_flush@basic-wb-ro-before-default.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-apl: NOTRUN -> [DMESG-WARN][63] ([i915#180])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_lmem_swapping@heavy-random:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#4613]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@gem_lmem_swapping@heavy-random.html
* igt@gem_pxp@create-valid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][65] ([i915#4270])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb5/igt@gem_pxp@create-valid-protected-context.html
* igt@gem_userptr_blits@vma-merge:
- shard-apl: NOTRUN -> [FAIL][66] ([i915#3318])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@gem_userptr_blits@vma-merge.html
* igt@gen3_render_mixed_blits:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109289])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb6/igt@gen3_render_mixed_blits.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][68] -> [DMESG-WARN][69] ([i915#5566] / [i915#716])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl3/igt@gen9_exec_parse@allowed-single.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl5/igt@gen9_exec_parse@allowed-single.html
* igt@gen9_exec_parse@bb-start-far:
- shard-skl: [PASS][70] -> [DMESG-WARN][71] ([i915#1982])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl4/igt@gen9_exec_parse@bb-start-far.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl4/igt@gen9_exec_parse@bb-start-far.html
* igt@gen9_exec_parse@unaligned-access:
- shard-tglb: NOTRUN -> [SKIP][72] ([i915#2527] / [i915#2856])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglb8/igt@gen9_exec_parse@unaligned-access.html
* igt@kms_big_fb@4-tiled-64bpp-rotate-0:
- shard-iclb: NOTRUN -> [SKIP][73] ([i915#5286]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb6/igt@kms_big_fb@4-tiled-64bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-glk: [PASS][74] -> [DMESG-WARN][75] ([i915#118]) +2 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-glk5/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-glk2/igt@kms_big_fb@y-tiled-16bpp-rotate-0.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip:
- shard-skl: NOTRUN -> [FAIL][76] ([i915#3743])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#3777])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#3777])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#3886])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-kbl6/igt@kms_ccs@pipe-a-crc-sprite-planes-basic-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-iclb: NOTRUN -> [SKIP][80] ([fdo#109278] / [i915#3886])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb5/igt@kms_ccs@pipe-a-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#3886]) +4 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271]) +79 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@kms_ccs@pipe-d-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_chamelium@hdmi-edid-change-during-suspend:
- shard-apl: NOTRUN -> [SKIP][83] ([fdo#109271] / [fdo#111827]) +4 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@kms_chamelium@hdmi-edid-change-during-suspend.html
* igt@kms_chamelium@hdmi-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][84] ([fdo#109284] / [fdo#111827]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb5/igt@kms_chamelium@hdmi-hpd-enable-disable-mode.html
* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][85] ([fdo#109271] / [fdo#111827]) +2 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_chamelium@hdmi-hpd-storm-disable.html
* igt@kms_color@pipe-d-ctm-red-to-blue:
- shard-iclb: NOTRUN -> [SKIP][86] ([fdo#109278] / [i915#1149])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb5/igt@kms_color@pipe-d-ctm-red-to-blue.html
* igt@kms_content_protection@lic:
- shard-apl: NOTRUN -> [TIMEOUT][87] ([i915#1319])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@kms_content_protection@lic.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic:
- shard-skl: [PASS][88] -> [FAIL][89] ([i915#2346])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl7/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank@c-edp1:
- shard-skl: [PASS][90] -> [FAIL][91] ([i915#79]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl9/igt@kms_flip@flip-vs-expired-vblank@c-edp1.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][92] -> [DMESG-WARN][93] ([i915#180]) +4 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-kbl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][94] -> [DMESG-WARN][95] ([i915#180]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl8/igt@kms_flip@flip-vs-suspend@a-dp1.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl2/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@plain-flip-fb-recreate@b-edp1:
- shard-skl: [PASS][96] -> [FAIL][97] ([i915#2122]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl7/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl3/igt@kms_flip@plain-flip-fb-recreate@b-edp1.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [PASS][98] -> [FAIL][99] ([i915#4911]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-glk6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: NOTRUN -> [SKIP][100] ([fdo#109280]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu:
- shard-tglb: NOTRUN -> [SKIP][101] ([fdo#109280] / [fdo#111825])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt:
- shard-kbl: NOTRUN -> [SKIP][102] ([fdo#109271]) +26 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-indfb-pgflip-blt.html
* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a:
- shard-skl: NOTRUN -> [FAIL][103] ([i915#1188])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-edp-1-pipe-a.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d:
- shard-skl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#533])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-d.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: NOTRUN -> [FAIL][105] ([fdo#108145] / [i915#265])
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][106] ([fdo#109271] / [i915#658])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl4/igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-skl: NOTRUN -> [SKIP][107] ([fdo#109271] / [i915#658])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][108] -> [SKIP][109] ([fdo#109441])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb2/igt@kms_psr@psr2_basic.html
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb6/igt@kms_psr@psr2_basic.html
* igt@kms_vblank@pipe-d-wait-forked:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109278]) +4 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb6/igt@kms_vblank@pipe-d-wait-forked.html
* igt@perf@gen12-mi-rpc:
- shard-skl: NOTRUN -> [SKIP][111] ([fdo#109271]) +52 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@perf@gen12-mi-rpc.html
* igt@perf@polling-parameterized:
- shard-glk: [PASS][112] -> [FAIL][113] ([i915#5639])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-glk8/igt@perf@polling-parameterized.html
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-glk6/igt@perf@polling-parameterized.html
* igt@sysfs_clients@fair-3:
- shard-skl: NOTRUN -> [SKIP][114] ([fdo#109271] / [i915#2994])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl10/igt@sysfs_clients@fair-3.html
* igt@sysfs_clients@fair-7:
- shard-apl: NOTRUN -> [SKIP][115] ([fdo#109271] / [i915#2994]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl7/igt@sysfs_clients@fair-7.html
#### Possible fixes ####
* igt@gem_ctx_persistence@hostile:
- {shard-dg1}: [FAIL][116] ([i915#4883]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-dg1-12/igt@gem_ctx_persistence@hostile.html
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-dg1-16/igt@gem_ctx_persistence@hostile.html
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [FAIL][118] ([i915#2410]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-tglb7/igt@gem_ctx_persistence@many-contexts.html
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglb8/igt@gem_ctx_persistence@many-contexts.html
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][120] ([i915#3063] / [i915#3648]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-tglu-5/igt@gem_eio@unwedge-stress.html
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglu-1/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_fair@basic-flow@rcs0:
- {shard-rkl}: [FAIL][122] ([i915#2842]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@gem_exec_fair@basic-flow@rcs0.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-2/igt@gem_exec_fair@basic-flow@rcs0.html
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [FAIL][124] ([i915#2842]) -> [PASS][125] +2 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-kbl7/igt@gem_exec_fair@basic-none-vip@rcs0.html
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-kbl1/igt@gem_exec_fair@basic-none-vip@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- shard-apl: [FAIL][126] ([i915#2842]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl3/igt@gem_exec_fair@basic-none@vecs0.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl1/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [FAIL][128] ([i915#2842]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglb8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_flush@basic-wb-rw-before-default:
- shard-snb: [SKIP][130] ([fdo#109271]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-snb6/igt@gem_exec_flush@basic-wb-rw-before-default.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-snb4/igt@gem_exec_flush@basic-wb-rw-before-default.html
* igt@gem_exec_suspend@basic-s3@smem:
- shard-kbl: [DMESG-WARN][132] ([i915#180]) -> [PASS][133] +1 similar issue
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-kbl7/igt@gem_exec_suspend@basic-s3@smem.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-kbl4/igt@gem_exec_suspend@basic-s3@smem.html
* igt@gem_exec_whisper@basic-contexts-priority-all:
- {shard-rkl}: [INCOMPLETE][134] ([i915#5498]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-5/igt@gem_exec_whisper@basic-contexts-priority-all.html
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-4/igt@gem_exec_whisper@basic-contexts-priority-all.html
* igt@gem_mmap_gtt@close-race:
- {shard-rkl}: [INCOMPLETE][136] ([i915#5080]) -> [PASS][137]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-5/igt@gem_mmap_gtt@close-race.html
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@gem_mmap_gtt@close-race.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][138] ([i915#454]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-tglu-3/igt@i915_pm_dc@dc6-dpms.html
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglu-2/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@i2c:
- {shard-rkl}: [SKIP][140] ([fdo#109308]) -> [PASS][141]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@i915_pm_rpm@i2c.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@i915_pm_rpm@i2c.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][142] ([i915#1397]) -> [PASS][143]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][144] ([i915#118]) -> [PASS][145]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-glk7/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-270:
- {shard-rkl}: [SKIP][146] ([i915#1845] / [i915#4098]) -> [PASS][147] +24 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_big_fb@y-tiled-32bpp-rotate-270.html
* igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs:
- shard-glk: [FAIL][148] ([i915#5046]) -> [PASS][149]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-glk5/igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs.html
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-glk2/igt@kms_ccs@pipe-a-crc-primary-basic-yf_tiled_ccs.html
* igt@kms_color@pipe-b-ctm-max:
- {shard-rkl}: [SKIP][150] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][151] +1 similar issue
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_color@pipe-b-ctm-max.html
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_color@pipe-b-ctm-max.html
* igt@kms_concurrent@pipe-a:
- {shard-rkl}: [SKIP][152] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][153] +1 similar issue
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_concurrent@pipe-a.html
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_concurrent@pipe-a.html
* igt@kms_cursor_crc@pipe-b-cursor-64x21-random:
- {shard-rkl}: [SKIP][154] ([fdo#112022] / [i915#4070]) -> [PASS][155] +4 similar issues
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_cursor_crc@pipe-b-cursor-64x21-random.html
* igt@kms_cursor_edge_walk@pipe-a-64x64-right-edge:
- {shard-rkl}: [SKIP][156] ([i915#4070] / [i915#4098]) -> [PASS][157] +1 similar issue
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@kms_cursor_edge_walk@pipe-a-64x64-right-edge.html
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_cursor_edge_walk@pipe-a-64x64-right-edge.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- {shard-rkl}: [SKIP][158] ([fdo#111825] / [i915#4070]) -> [PASS][159] +1 similar issue
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@pipe-c-torture-move:
- {shard-rkl}: [SKIP][160] ([i915#4070]) -> [PASS][161]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-1/igt@kms_cursor_legacy@pipe-c-torture-move.html
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-4/igt@kms_cursor_legacy@pipe-c-torture-move.html
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled:
- {shard-rkl}: [SKIP][162] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][163] +2 similar issues
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-untiled.html
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-xtiled:
- {shard-rkl}: [SKIP][164] ([i915#4098] / [i915#4369]) -> [PASS][165]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-xtiled.html
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-xtiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [FAIL][166] ([i915#79]) -> [PASS][167] +1 similar issue
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl2/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl8/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-suspend@c-dp1:
- shard-apl: [DMESG-WARN][168] ([i915#180]) -> [PASS][169] +4 similar issues
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-apl8/igt@kms_flip@flip-vs-suspend@c-dp1.html
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-apl2/igt@kms_flip@flip-vs-suspend@c-dp1.html
* igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1:
- shard-skl: [FAIL][170] ([i915#2122]) -> [PASS][171] +1 similar issue
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl2/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl8/igt@kms_flip@plain-flip-fb-recreate-interruptible@c-edp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling:
- shard-iclb: [SKIP][172] ([i915#3701]) -> [PASS][173]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb1/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu:
- {shard-rkl}: [SKIP][174] ([i915#1849] / [i915#4098]) -> [PASS][175] +19 similar issues
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_frontbuffer_tracking@fbcpsr-rgb101010-draw-mmap-cpu.html
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b:
- {shard-rkl}: [SKIP][176] ([i915#4098]) -> [PASS][177] +1 similar issue
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-4/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b.html
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-b.html
* igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
- {shard-rkl}: [SKIP][178] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][179]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][180] ([fdo#108145] / [i915#265]) -> [PASS][181]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-edp-1-planes-upscale-downscale:
- shard-iclb: [SKIP][182] ([i915#5235]) -> [PASS][183] +2 similar issues
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-edp-1-planes-upscale-downscale.html
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-c-edp-1-planes-upscale-downscale.html
* igt@kms_properties@plane-properties-atomic:
- {shard-rkl}: [SKIP][184] ([i915#1849]) -> [PASS][185]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_properties@plane-properties-atomic.html
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_properties@plane-properties-atomic.html
* igt@kms_psr@cursor_plane_move:
- {shard-rkl}: [SKIP][186] ([i915#1072]) -> [PASS][187] +2 similar issues
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-rkl-2/igt@kms_psr@cursor_plane_move.html
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-rkl-6/igt@kms_psr@cursor_plane_move.html
* igt@perf@polling-small-buf:
- shard-skl: [FAIL][188] ([i915#1722]) -> [PASS][189]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl9/igt@perf@polling-small-buf.html
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl9/igt@perf@polling-small-buf.html
* igt@sysfs_heartbeat_interval@precise@vcs0:
- {shard-dg1}: [FAIL][190] ([i915#1755]) -> [PASS][191]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-dg1-16/igt@sysfs_heartbeat_interval@precise@vcs0.html
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-dg1-12/igt@sysfs_heartbeat_interval@precise@vcs0.html
#### Warnings ####
* igt@gem_eio@unwedge-stress:
- shard-tglb: [FAIL][192] ([i915#232]) -> [TIMEOUT][193] ([i915#3063] / [i915#3648])
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-tglb1/igt@gem_eio@unwedge-stress.html
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-tglb7/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_balancer@parallel:
- shard-iclb: [SKIP][194] ([i915#4525]) -> [DMESG-WARN][195] ([i915#5614]) +1 similar issue
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb8/igt@gem_exec_balancer@parallel.html
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb1/igt@gem_exec_balancer@parallel.html
* igt@gem_exec_balancer@parallel-keep-submit-fence:
- shard-iclb: [DMESG-WARN][196] ([i915#5614]) -> [SKIP][197] ([i915#4525]) +1 similar issue
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb2/igt@gem_exec_balancer@parallel-keep-submit-fence.html
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb6/igt@gem_exec_balancer@parallel-keep-submit-fence.html
* igt@kms_color@pipe-c-deep-color:
- shard-skl: [SKIP][198] ([fdo#109271] / [i915#1888]) -> [SKIP][199] ([fdo#109271])
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-skl7/igt@kms_color@pipe-c-deep-color.html
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-skl3/igt@kms_color@pipe-c-deep-color.html
* igt@kms_psr2_su@page_flip-p010:
- shard-iclb: [FAIL][200] ([i915#4148]) -> [SKIP][201] ([fdo#109642] / [fdo#111068] / [i915#658])
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb2/igt@kms_psr2_su@page_flip-p010.html
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb1/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-iclb: [SKIP][202] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][203] ([i915#4148])
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11508/shard-iclb8/igt@kms_psr2_su@page_flip-xrgb8888.html
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/shard-iclb2/igt@kms_psr2_su@page_flip-xrgb8888.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112022]: https://bugs.freedesktop.org/show_bug.cgi?id=112022
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1836]: https://gitlab.freedesktop.org/drm/intel/issues/1836
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2232]: https://gitlab.freedesktop.org/drm/intel/issues/2232
[i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2849]: https://gitlab.freedesktop.org/drm/intel/issues/2849
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3063]: https://gitlab.freedesktop.org/drm/intel/issues/3063
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3319]: https://gitlab.freedesktop.org/drm/intel/issues/3319
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3648]: https://gitlab.freedesktop.org/drm/intel/issues/3648
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3701]: https://gitlab.freedesktop.org/drm/intel/issues/3701
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3736]: https://gitlab.freedesktop.org/drm/intel/issues/3736
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3777]: https://gitlab.freedesktop.org/drm/intel/issues/3777
[i915#3810]: https://gitlab.freedesktop.org/drm/intel/issues/3810
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4148]: https://gitlab.freedesktop.org/drm/intel/issues/4148
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4278]: https://gitlab.freedesktop.org/drm/intel/issues/4278
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4386]: https://gitlab.freedesktop.org/drm/intel/issues/4386
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4793]: https://gitlab.freedesktop.org/drm/intel/issues/4793
[i915#4807]: https://gitlab.freedesktop.org/drm/intel/issues/4807
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4842]: https://gitlab.freedesktop.org/drm/intel/issues/4842
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4853]: https://gitlab.freedesktop.org/drm/intel/issues/4853
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4883]: https://gitlab.freedesktop.org/drm/intel/issues/4883
[i915#4886]: https://gitlab.freedesktop.org/drm/intel/issues/4886
[i915#4893]: https://gitlab.freedesktop.org/drm/intel/issues/4893
[i915#4911]: https://gitlab.freedesktop.org/drm/intel/issues/4911
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5046]: https://gitlab.freedesktop.org/drm/intel/issues/5046
[i915#5080]: https://gitlab.freedesktop.org/drm/intel/issues/5080
[i915#5115]: https://gitlab.freedesktop.org/drm/intel/issues/5115
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5498]: https://gitlab.freedesktop.org/drm/intel/issues/5498
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#5614]: https://gitlab.freedesktop.org/drm/intel/issues/5614
[i915#5639]: https://gitlab.freedesktop.org/drm/intel/issues/5639
[i915#5701]: https://gitlab.freedesktop.org/drm/intel/issues/5701
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_11508 -> Patchwork_102762v1
CI-20190529: 20190529
CI_DRM_11508: 3036e366aa958325fd0d425a608bb14558d54507 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6438: 205a47d8f70e659df620573ce409d228c5762d11 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102762v1: 3036e366aa958325fd0d425a608bb14558d54507 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102762v1/index.html
[-- Attachment #2: Type: text/html, Size: 51024 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
2022-04-16 18:33 ` Joe Perches
(?)
@ 2022-04-16 20:48 ` Tom Rix
-1 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 20:48 UTC (permalink / raw)
To: Joe Perches, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On 4/16/22 11:33 AM, Joe Perches wrote:
> On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
>> In insert_mappable_node(), the parameter node is
>> cleared late in node's use with memset.
>> insert_mappable_node() is a singleton, called only
>> from i915_gem_gtt_prepare() which itself is only
>> called by i915_gem_gtt_pread() and
>> i915_gem_gtt_pwrite_fast() where the definition of
>> node originates.
>>
>> Instead of using memset, initialize node to 0 at it's
>> definitions.
> trivia: /it's/its/
>
> Only reason _not_ to do this is memset is guaranteed to
> zero any padding that might go to userspace.
>
> But it doesn't seem there is any padding anyway nor is
> the struct available to userspace.
>
> So this seems fine though it might increase overall code
> size a tiny bit.
>
> I do have a caveat: see below:
>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> []
>> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
>> goto err_ww;
>> } else if (!IS_ERR(vma)) {
>> node->start = i915_ggtt_offset(vma);
>> - node->flags = 0;
> Why is this unneeded?
node = {} initializes all of node's elements to 0, including this one.
Tom
>
> from: drm_mm_insert_node_in_range which can set node->flags
>
> __set_bit(DRM_MM_NODE_ALLOCATED_BIT, &node->flags);
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 20:48 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 20:48 UTC (permalink / raw)
To: Joe Perches, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On 4/16/22 11:33 AM, Joe Perches wrote:
> On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
>> In insert_mappable_node(), the parameter node is
>> cleared late in node's use with memset.
>> insert_mappable_node() is a singleton, called only
>> from i915_gem_gtt_prepare() which itself is only
>> called by i915_gem_gtt_pread() and
>> i915_gem_gtt_pwrite_fast() where the definition of
>> node originates.
>>
>> Instead of using memset, initialize node to 0 at it's
>> definitions.
> trivia: /it's/its/
>
> Only reason _not_ to do this is memset is guaranteed to
> zero any padding that might go to userspace.
>
> But it doesn't seem there is any padding anyway nor is
> the struct available to userspace.
>
> So this seems fine though it might increase overall code
> size a tiny bit.
>
> I do have a caveat: see below:
>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> []
>> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
>> goto err_ww;
>> } else if (!IS_ERR(vma)) {
>> node->start = i915_ggtt_offset(vma);
>> - node->flags = 0;
> Why is this unneeded?
node = {} initializes all of node's elements to 0, including this one.
Tom
>
> from: drm_mm_insert_node_in_range which can set node->flags
>
> __set_bit(DRM_MM_NODE_ALLOCATED_BIT, &node->flags);
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 20:48 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 20:48 UTC (permalink / raw)
To: Joe Perches, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, dri-devel, linux-kernel
On 4/16/22 11:33 AM, Joe Perches wrote:
> On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
>> In insert_mappable_node(), the parameter node is
>> cleared late in node's use with memset.
>> insert_mappable_node() is a singleton, called only
>> from i915_gem_gtt_prepare() which itself is only
>> called by i915_gem_gtt_pread() and
>> i915_gem_gtt_pwrite_fast() where the definition of
>> node originates.
>>
>> Instead of using memset, initialize node to 0 at it's
>> definitions.
> trivia: /it's/its/
>
> Only reason _not_ to do this is memset is guaranteed to
> zero any padding that might go to userspace.
>
> But it doesn't seem there is any padding anyway nor is
> the struct available to userspace.
>
> So this seems fine though it might increase overall code
> size a tiny bit.
>
> I do have a caveat: see below:
>
>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> []
>> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
>> goto err_ww;
>> } else if (!IS_ERR(vma)) {
>> node->start = i915_ggtt_offset(vma);
>> - node->flags = 0;
> Why is this unneeded?
node = {} initializes all of node's elements to 0, including this one.
Tom
>
> from: drm_mm_insert_node_in_range which can set node->flags
>
> __set_bit(DRM_MM_NODE_ALLOCATED_BIT, &node->flags);
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
2022-04-16 20:48 ` [Intel-gfx] " Tom Rix
(?)
@ 2022-04-16 21:04 ` Joe Perches
-1 siblings, 0 replies; 17+ messages in thread
From: Joe Perches @ 2022-04-16 21:04 UTC (permalink / raw)
To: Tom Rix, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote:
> On 4/16/22 11:33 AM, Joe Perches wrote:
> > On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
> > > In insert_mappable_node(), the parameter node is
> > > cleared late in node's use with memset.
> > > insert_mappable_node() is a singleton, called only
> > > from i915_gem_gtt_prepare() which itself is only
> > > called by i915_gem_gtt_pread() and
> > > i915_gem_gtt_pwrite_fast() where the definition of
> > > node originates.
> > >
> > > Instead of using memset, initialize node to 0 at it's
> > > definitions.
> > trivia: /it's/its/
> >
> > Only reason _not_ to do this is memset is guaranteed to
> > zero any padding that might go to userspace.
> >
> > But it doesn't seem there is any padding anyway nor is
> > the struct available to userspace.
> >
> > So this seems fine though it might increase overall code
> > size a tiny bit.
> >
> > I do have a caveat: see below:
> >
> > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > []
> > > @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
> > > goto err_ww;
> > > } else if (!IS_ERR(vma)) {
> > > node->start = i915_ggtt_offset(vma);
> > > - node->flags = 0;
> > Why is this unneeded?
>
> node = {} initializes all of node's elements to 0, including this one.
true, but could the call to insert_mappable_node combined with the
retry goto in i915_gem_gtt_prepare set this to non-zero?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 21:04 ` Joe Perches
0 siblings, 0 replies; 17+ messages in thread
From: Joe Perches @ 2022-04-16 21:04 UTC (permalink / raw)
To: Tom Rix, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote:
> On 4/16/22 11:33 AM, Joe Perches wrote:
> > On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
> > > In insert_mappable_node(), the parameter node is
> > > cleared late in node's use with memset.
> > > insert_mappable_node() is a singleton, called only
> > > from i915_gem_gtt_prepare() which itself is only
> > > called by i915_gem_gtt_pread() and
> > > i915_gem_gtt_pwrite_fast() where the definition of
> > > node originates.
> > >
> > > Instead of using memset, initialize node to 0 at it's
> > > definitions.
> > trivia: /it's/its/
> >
> > Only reason _not_ to do this is memset is guaranteed to
> > zero any padding that might go to userspace.
> >
> > But it doesn't seem there is any padding anyway nor is
> > the struct available to userspace.
> >
> > So this seems fine though it might increase overall code
> > size a tiny bit.
> >
> > I do have a caveat: see below:
> >
> > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > []
> > > @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
> > > goto err_ww;
> > > } else if (!IS_ERR(vma)) {
> > > node->start = i915_ggtt_offset(vma);
> > > - node->flags = 0;
> > Why is this unneeded?
>
> node = {} initializes all of node's elements to 0, including this one.
true, but could the call to insert_mappable_node combined with the
retry goto in i915_gem_gtt_prepare set this to non-zero?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 21:04 ` Joe Perches
0 siblings, 0 replies; 17+ messages in thread
From: Joe Perches @ 2022-04-16 21:04 UTC (permalink / raw)
To: Tom Rix, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, dri-devel, linux-kernel
On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote:
> On 4/16/22 11:33 AM, Joe Perches wrote:
> > On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
> > > In insert_mappable_node(), the parameter node is
> > > cleared late in node's use with memset.
> > > insert_mappable_node() is a singleton, called only
> > > from i915_gem_gtt_prepare() which itself is only
> > > called by i915_gem_gtt_pread() and
> > > i915_gem_gtt_pwrite_fast() where the definition of
> > > node originates.
> > >
> > > Instead of using memset, initialize node to 0 at it's
> > > definitions.
> > trivia: /it's/its/
> >
> > Only reason _not_ to do this is memset is guaranteed to
> > zero any padding that might go to userspace.
> >
> > But it doesn't seem there is any padding anyway nor is
> > the struct available to userspace.
> >
> > So this seems fine though it might increase overall code
> > size a tiny bit.
> >
> > I do have a caveat: see below:
> >
> > > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> > []
> > > @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
> > > goto err_ww;
> > > } else if (!IS_ERR(vma)) {
> > > node->start = i915_ggtt_offset(vma);
> > > - node->flags = 0;
> > Why is this unneeded?
>
> node = {} initializes all of node's elements to 0, including this one.
true, but could the call to insert_mappable_node combined with the
retry goto in i915_gem_gtt_prepare set this to non-zero?
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
2022-04-16 21:04 ` [Intel-gfx] " Joe Perches
(?)
@ 2022-04-16 22:25 ` Tom Rix
-1 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 22:25 UTC (permalink / raw)
To: Joe Perches, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, dri-devel, linux-kernel
On 4/16/22 2:04 PM, Joe Perches wrote:
> On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote:
>> On 4/16/22 11:33 AM, Joe Perches wrote:
>>> On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
>>>> In insert_mappable_node(), the parameter node is
>>>> cleared late in node's use with memset.
>>>> insert_mappable_node() is a singleton, called only
>>>> from i915_gem_gtt_prepare() which itself is only
>>>> called by i915_gem_gtt_pread() and
>>>> i915_gem_gtt_pwrite_fast() where the definition of
>>>> node originates.
>>>>
>>>> Instead of using memset, initialize node to 0 at it's
>>>> definitions.
>>> trivia: /it's/its/
>>>
>>> Only reason _not_ to do this is memset is guaranteed to
>>> zero any padding that might go to userspace.
>>>
>>> But it doesn't seem there is any padding anyway nor is
>>> the struct available to userspace.
>>>
>>> So this seems fine though it might increase overall code
>>> size a tiny bit.
>>>
>>> I do have a caveat: see below:
>>>
>>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>>> []
>>>> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
>>>> goto err_ww;
>>>> } else if (!IS_ERR(vma)) {
>>>> node->start = i915_ggtt_offset(vma);
>>>> - node->flags = 0;
>>> Why is this unneeded?
>> node = {} initializes all of node's elements to 0, including this one.
> true, but could the call to insert_mappable_node combined with the
> retry goto in i915_gem_gtt_prepare set this to non-zero?
Yikes!
I'll add that back.
Thanks for pointing it out.
Tom
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 22:25 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 22:25 UTC (permalink / raw)
To: Joe Perches, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On 4/16/22 2:04 PM, Joe Perches wrote:
> On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote:
>> On 4/16/22 11:33 AM, Joe Perches wrote:
>>> On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
>>>> In insert_mappable_node(), the parameter node is
>>>> cleared late in node's use with memset.
>>>> insert_mappable_node() is a singleton, called only
>>>> from i915_gem_gtt_prepare() which itself is only
>>>> called by i915_gem_gtt_pread() and
>>>> i915_gem_gtt_pwrite_fast() where the definition of
>>>> node originates.
>>>>
>>>> Instead of using memset, initialize node to 0 at it's
>>>> definitions.
>>> trivia: /it's/its/
>>>
>>> Only reason _not_ to do this is memset is guaranteed to
>>> zero any padding that might go to userspace.
>>>
>>> But it doesn't seem there is any padding anyway nor is
>>> the struct available to userspace.
>>>
>>> So this seems fine though it might increase overall code
>>> size a tiny bit.
>>>
>>> I do have a caveat: see below:
>>>
>>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>>> []
>>>> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
>>>> goto err_ww;
>>>> } else if (!IS_ERR(vma)) {
>>>> node->start = i915_ggtt_offset(vma);
>>>> - node->flags = 0;
>>> Why is this unneeded?
>> node = {} initializes all of node's elements to 0, including this one.
> true, but could the call to insert_mappable_node combined with the
> retry goto in i915_gem_gtt_prepare set this to non-zero?
Yikes!
I'll add that back.
Thanks for pointing it out.
Tom
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: change node clearing from memset to initialization
@ 2022-04-16 22:25 ` Tom Rix
0 siblings, 0 replies; 17+ messages in thread
From: Tom Rix @ 2022-04-16 22:25 UTC (permalink / raw)
To: Joe Perches, jani.nikula, joonas.lahtinen, rodrigo.vivi,
tvrtko.ursulin, airlied, daniel
Cc: intel-gfx, linux-kernel, dri-devel
On 4/16/22 2:04 PM, Joe Perches wrote:
> On Sat, 2022-04-16 at 13:48 -0700, Tom Rix wrote:
>> On 4/16/22 11:33 AM, Joe Perches wrote:
>>> On Sat, 2022-04-16 at 13:23 -0400, Tom Rix wrote:
>>>> In insert_mappable_node(), the parameter node is
>>>> cleared late in node's use with memset.
>>>> insert_mappable_node() is a singleton, called only
>>>> from i915_gem_gtt_prepare() which itself is only
>>>> called by i915_gem_gtt_pread() and
>>>> i915_gem_gtt_pwrite_fast() where the definition of
>>>> node originates.
>>>>
>>>> Instead of using memset, initialize node to 0 at it's
>>>> definitions.
>>> trivia: /it's/its/
>>>
>>> Only reason _not_ to do this is memset is guaranteed to
>>> zero any padding that might go to userspace.
>>>
>>> But it doesn't seem there is any padding anyway nor is
>>> the struct available to userspace.
>>>
>>> So this seems fine though it might increase overall code
>>> size a tiny bit.
>>>
>>> I do have a caveat: see below:
>>>
>>>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
>>> []
>>>> @@ -328,7 +327,6 @@ static struct i915_vma *i915_gem_gtt_prepare(struct drm_i915_gem_object *obj,
>>>> goto err_ww;
>>>> } else if (!IS_ERR(vma)) {
>>>> node->start = i915_ggtt_offset(vma);
>>>> - node->flags = 0;
>>> Why is this unneeded?
>> node = {} initializes all of node's elements to 0, including this one.
> true, but could the call to insert_mappable_node combined with the
> retry goto in i915_gem_gtt_prepare set this to non-zero?
Yikes!
I'll add that back.
Thanks for pointing it out.
Tom
>
>
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2022-04-16 22:25 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 17:23 [PATCH] drm/i915: change node clearing from memset to initialization Tom Rix
2022-04-16 17:23 ` [Intel-gfx] " Tom Rix
2022-04-16 17:23 ` Tom Rix
2022-04-16 18:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2022-04-16 18:33 ` [PATCH] " Joe Perches
2022-04-16 18:33 ` [Intel-gfx] " Joe Perches
2022-04-16 18:33 ` Joe Perches
2022-04-16 20:48 ` Tom Rix
2022-04-16 20:48 ` Tom Rix
2022-04-16 20:48 ` [Intel-gfx] " Tom Rix
2022-04-16 21:04 ` Joe Perches
2022-04-16 21:04 ` Joe Perches
2022-04-16 21:04 ` [Intel-gfx] " Joe Perches
2022-04-16 22:25 ` Tom Rix
2022-04-16 22:25 ` [Intel-gfx] " Tom Rix
2022-04-16 22:25 ` Tom Rix
2022-04-16 19:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.