All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "lars@engebretsen.ch" <lars@engebretsen.ch>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "jic23@kernel.org" <jic23@kernel.org>
Subject: Re: [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro
Date: Wed, 15 Apr 2020 05:43:21 +0000	[thread overview]
Message-ID: <d11920433cd3c6476c1c0da18846b7d41cd1fde3.camel@analog.com> (raw)
In-Reply-To: <20200414184237.23018-1-lars@engebretsen.ch>

On Tue, 2020-04-14 at 20:42 +0200, Lars Engebretsen wrote:

A description of the change is required to describe the change.
I think I mentioned this in my email, but I was lazy to provide an example.

Description of changes are required even for the smallest of changes; I think
it's mostly so that people always keep their brains trained to describe all
changes.

So here, you could say something like:
---------------------------------------------------------------------------
This change removes the semi-colon from the devm_iio_device_register() macro
which seems to have been added by accident via commit 63b19547cc3d9 ("iio: Use
macro magic to avoid manual assign of driver_module").
---------------------------------------------------------------------------

Make sure commit comments stay within a 75 column width limit.
And make sure you add a version tag for the next patch/re-send.
i.e. do  git format-patch -v2  [or v3 for 3rd version,]

And it's a good idea to add a changelog after the line with '---' in the patch
file. Text after that line gets ignored for the commit description.
Something like:

Changelog v1 -> v2:
* added commit change description


> Signed-off-by: Lars Engebretsen <lars@engebretsen.ch>
> ---
>  include/linux/iio/iio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index d63884a54939..76ba7c9fd3e0 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -597,7 +597,7 @@ void iio_device_unregister(struct iio_dev *indio_dev);
>   * 0 on success, negative error number on failure.
>   */
>  #define devm_iio_device_register(dev, indio_dev) \
> -	__devm_iio_device_register((dev), (indio_dev), THIS_MODULE);
> +	__devm_iio_device_register((dev), (indio_dev), THIS_MODULE)
>  int __devm_iio_device_register(struct device *dev, struct iio_dev *indio_dev,
>  			       struct module *this_mod);
>  int iio_push_event(struct iio_dev *indio_dev, u64 ev_code, s64 timestamp);

  reply	other threads:[~2020-04-15  5:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-14 18:42 [PATCH] iio: core: remove extra semi-colon from devm_iio_device_register() macro Lars Engebretsen
2020-04-15  5:43 ` Ardelean, Alexandru [this message]
2020-04-15 10:10   ` Lars Engebretsen
  -- strict thread matches above, loose matches on Subject: below --
2020-04-14 18:41 Lars Engebretsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d11920433cd3c6476c1c0da18846b7d41cd1fde3.camel@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@engebretsen.ch \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.