From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78F46C43142 for ; Wed, 1 Aug 2018 01:39:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2681220894 for ; Wed, 1 Aug 2018 01:39:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2681220894 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732978AbeHADWR (ORCPT ); Tue, 31 Jul 2018 23:22:17 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:47924 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732855AbeHADWR (ORCPT ); Tue, 31 Jul 2018 23:22:17 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3327687A74; Wed, 1 Aug 2018 01:39:13 +0000 (UTC) Received: from [10.72.12.57] (ovpn-12-57.pek2.redhat.com [10.72.12.57]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B3622026D7E; Wed, 1 Aug 2018 01:39:10 +0000 (UTC) Subject: Re: [PATCH net-next 2/2] virtio-net: get rid of unnecessary container of rq stats To: Toshiaki Makita Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <1533030219-9904-1-git-send-email-jasowang@redhat.com> <1533030219-9904-2-git-send-email-jasowang@redhat.com> From: Jason Wang Message-ID: Date: Wed, 1 Aug 2018 09:39:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 01 Aug 2018 01:39:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Wed, 01 Aug 2018 01:39:13 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jasowang@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018年07月31日 18:02, Toshiaki Makita wrote: > On 2018/07/31 18:43, Jason Wang wrote: >> We don't maintain tx counters in rx stats any more. There's no need >> for an extra container of rq stats. >> >> Cc: Toshiaki Makita >> Signed-off-by: Jason Wang >> --- >> drivers/net/virtio_net.c | 80 ++++++++++++++++++++++-------------------------- >> 1 file changed, 36 insertions(+), 44 deletions(-) >> >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >> index 72d3f68..14f661c 100644 >> --- a/drivers/net/virtio_net.c >> +++ b/drivers/net/virtio_net.c >> @@ -87,7 +87,8 @@ struct virtnet_sq_stats { >> u64 kicks; >> }; >> >> -struct virtnet_rq_stat_items { >> +struct virtnet_rq_stats { >> + struct u64_stats_sync syncp; >> u64 packets; >> u64 bytes; >> u64 drops; >> @@ -98,17 +99,8 @@ struct virtnet_rq_stat_items { >> u64 kicks; >> }; >> >> -struct virtnet_rq_stats { >> - struct u64_stats_sync syncp; >> - struct virtnet_rq_stat_items items; >> -}; > I'm not thinking removing sq stat is needed but even if it is I want to > keep virtnet_rq_stats to avoid allocating unnecessary u64_stats_syncp on > stack in virtnet_receive. I would just remove virtnet_rx_stats if necessary. It's a nop on 64bit machines. And an unsigned on 32bit. So it's overhead could be ignored I think. Thanks >> - >> -struct virtnet_rx_stats { >> - struct virtnet_rq_stat_items rx; >> -}; >> - From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH net-next 2/2] virtio-net: get rid of unnecessary container of rq stats Date: Wed, 1 Aug 2018 09:39:08 +0800 Message-ID: References: <1533030219-9904-1-git-send-email-jasowang@redhat.com> <1533030219-9904-2-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, mst@redhat.com To: Toshiaki Makita Return-path: In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org CgpPbiAyMDE45bm0MDfmnIgzMeaXpSAxODowMiwgVG9zaGlha2kgTWFraXRhIHdyb3RlOgo+IE9u IDIwMTgvMDcvMzEgMTg6NDMsIEphc29uIFdhbmcgd3JvdGU6Cj4+IFdlIGRvbid0IG1haW50YWlu IHR4IGNvdW50ZXJzIGluIHJ4IHN0YXRzIGFueSBtb3JlLiBUaGVyZSdzIG5vIG5lZWQKPj4gZm9y IGFuIGV4dHJhIGNvbnRhaW5lciBvZiBycSBzdGF0cy4KPj4KPj4gQ2M6IFRvc2hpYWtpIE1ha2l0 YSA8bWFraXRhLnRvc2hpYWtpQGxhYi5udHQuY28uanA+Cj4+IFNpZ25lZC1vZmYtYnk6IEphc29u IFdhbmcgPGphc293YW5nQHJlZGhhdC5jb20+Cj4+IC0tLQo+PiAgIGRyaXZlcnMvbmV0L3ZpcnRp b19uZXQuYyB8IDgwICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQo+PiAgIDEgZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA0NCBkZWxldGlvbnMo LSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3ZpcnRpb19uZXQuYyBiL2RyaXZlcnMv bmV0L3ZpcnRpb19uZXQuYwo+PiBpbmRleCA3MmQzZjY4Li4xNGY2NjFjIDEwMDY0NAo+PiAtLS0g YS9kcml2ZXJzL25ldC92aXJ0aW9fbmV0LmMKPj4gKysrIGIvZHJpdmVycy9uZXQvdmlydGlvX25l dC5jCj4+IEBAIC04Nyw3ICs4Nyw4IEBAIHN0cnVjdCB2aXJ0bmV0X3NxX3N0YXRzIHsKPj4gICAJ dTY0IGtpY2tzOwo+PiAgIH07Cj4+ICAgCj4+IC1zdHJ1Y3QgdmlydG5ldF9ycV9zdGF0X2l0ZW1z IHsKPj4gK3N0cnVjdCB2aXJ0bmV0X3JxX3N0YXRzIHsKPj4gKwlzdHJ1Y3QgdTY0X3N0YXRzX3N5 bmMgc3luY3A7Cj4+ICAgCXU2NCBwYWNrZXRzOwo+PiAgIAl1NjQgYnl0ZXM7Cj4+ICAgCXU2NCBk cm9wczsKPj4gQEAgLTk4LDE3ICs5OSw4IEBAIHN0cnVjdCB2aXJ0bmV0X3JxX3N0YXRfaXRlbXMg ewo+PiAgIAl1NjQga2lja3M7Cj4+ICAgfTsKPj4gICAKPj4gLXN0cnVjdCB2aXJ0bmV0X3JxX3N0 YXRzIHsKPj4gLQlzdHJ1Y3QgdTY0X3N0YXRzX3N5bmMgc3luY3A7Cj4+IC0Jc3RydWN0IHZpcnRu ZXRfcnFfc3RhdF9pdGVtcyBpdGVtczsKPj4gLX07Cj4gSSdtIG5vdCB0aGlua2luZyByZW1vdmlu ZyBzcSBzdGF0IGlzIG5lZWRlZCBidXQgZXZlbiBpZiBpdCBpcyBJIHdhbnQgdG8KPiBrZWVwIHZp cnRuZXRfcnFfc3RhdHMgdG8gYXZvaWQgYWxsb2NhdGluZyB1bm5lY2Vzc2FyeSB1NjRfc3RhdHNf c3luY3Agb24KPiBzdGFjayBpbiB2aXJ0bmV0X3JlY2VpdmUuIEkgd291bGQganVzdCByZW1vdmUg dmlydG5ldF9yeF9zdGF0cyBpZiBuZWNlc3NhcnkuCgpJdCdzIGEgbm9wIG9uIDY0Yml0IG1hY2hp bmVzLiBBbmQgYW4gdW5zaWduZWQgb24gMzJiaXQuIFNvIGl0J3Mgb3ZlcmhlYWQgCmNvdWxkIGJl IGlnbm9yZWQgSSB0aGluay4KClRoYW5rcwoKPj4gLQo+PiAtc3RydWN0IHZpcnRuZXRfcnhfc3Rh dHMgewo+PiAtCXN0cnVjdCB2aXJ0bmV0X3JxX3N0YXRfaXRlbXMgcng7Cj4+IC19Owo+PiAtCgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXph dGlvbiBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5v cmcKaHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmly dHVhbGl6YXRpb24=