From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E382C54EAA for ; Fri, 27 Jan 2023 19:20:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.485902.753333 (Exim 4.92) (envelope-from ) id 1pLUGG-0002AS-LW; Fri, 27 Jan 2023 19:19:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 485902.753333; Fri, 27 Jan 2023 19:19:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pLUGG-0002AL-IX; Fri, 27 Jan 2023 19:19:44 +0000 Received: by outflank-mailman (input) for mailman id 485902; Fri, 27 Jan 2023 19:19:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pLUGF-0002AD-GI for xen-devel@lists.xenproject.org; Fri, 27 Jan 2023 19:19:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1pLUGE-0006KB-Ur; Fri, 27 Jan 2023 19:19:42 +0000 Received: from gw1.octic.net ([88.97.20.152] helo=[10.0.1.240]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1pLUGE-00013e-Oq; Fri, 27 Jan 2023 19:19:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=uHaXHL/FVNly5UZIdc3Ga9SPTYKmG02IgzTGGybur6I=; b=Yq4FK+kW1oOq9Rl6jhjyICqw8B g5k31CFRoq4rmZeEbQqcPF5Bsqkps4CDo3bU2CogYFdVsHA3r35IwQcgiIBp6C1MwCV2qkqpEZ2zz 4LU1FHqNlSNxP3hHwdfDdSDWx1JKKD92pBflVKvAzk9Dlyh/uXjNJJhglTFkm9ATO6Bg=; Message-ID: Date: Fri, 27 Jan 2023 19:19:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v4 10/14] xen/arm32: head: Widen the use of the temporary mapping Content-Language: en-US From: Julien Grall To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Luca.Fancellu@arm.com, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20230113101136.479-1-julien@xen.org> <20230113101136.479-11-julien@xen.org> <0271e540-d3b0-fb9b-0f66-015abb45231c@amd.com> <5c18827c-ffc2-1c31-bd7c-812ca05c4bc3@xen.org> In-Reply-To: <5c18827c-ffc2-1c31-bd7c-812ca05c4bc3@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 24/01/2023 19:43, Julien Grall wrote: >>> -        /* >>> -         * This will override the link to boot_second in >>> XEN_FIRST_SLOT. >>> -         * The page-tables are not live yet. So no need to use >>> -         * break-before-make. >>> -         */ >>>           create_table_entry boot_pgtable, boot_second_id, r9, 1 >>>           create_table_entry boot_second_id, boot_third_id, r9, 2 >> Do we need to duplicate this if we just did the same in >> create_page_tables before branching to >> use_temporary_mapping? > > Hmmm... Possibly not. I will give a try and let you know. I confirm this is not necessary. So I have removed the two lines. Cheers, -- Julien Grall