All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caleb Connolly <caleb@connolly.tech>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sdm845: Enable user LEDs on DB845c
Date: Fri, 01 Jul 2022 18:49:16 +0000	[thread overview]
Message-ID: <d12442a6-a0f1-0cb4-caa0-b7bb22fff28d@connolly.tech> (raw)
In-Reply-To: <20220505022706.1692554-3-bjorn.andersson@linaro.org>



On 05/05/2022 03:27, Bjorn Andersson wrote:
> The DB845c has 4 "user LEDs", the last one is already supported as it's
> just wired to a gpio. Now that the LPG binding is in place we can wire
> up the other 3 LEDs as well.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Reviewed-by: Caleb Connolly <caleb@connolly.tech>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 31 ++++++++++++++++++++++
>   1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> index 194ebeb3259c..e4d3de0a1e6d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -5,6 +5,7 @@
>
>   /dts-v1/;
>
> +#include <dt-bindings/leds/common.h>
>   #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>   #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
>   #include <dt-bindings/sound/qcom,q6afe.h>
> @@ -606,6 +607,36 @@ resin {
>   	};
>   };
>
> +&pmi8998_lpg {
> +	status = "okay";
> +
> +	qcom,power-source = <1>;
> +
> +	led@3 {
> +		reg = <3>;
> +		color = <LED_COLOR_ID_GREEN>;
> +		function = LED_FUNCTION_HEARTBEAT;
> +		function-enumerator = <3>;
> +
> +		linux,default-trigger = "heartbeat";
> +		default-state = "on";
> +	};
> +
> +	led@4 {
> +		reg = <4>;
> +		color = <LED_COLOR_ID_GREEN>;
> +		function = LED_FUNCTION_INDICATOR;
> +		function-enumerator = <2>;
> +	};
> +
> +	led@5 {
> +		reg = <5>;
> +		color = <LED_COLOR_ID_GREEN>;
> +		function = LED_FUNCTION_INDICATOR;
> +		function-enumerator = <1>;
> +	};
> +};
> +
>   /* QUAT I2S Uses 4 I2S SD Lines for audio on LT9611 HDMI Bridge */
>   &q6afedai {
>   	qi2s@22 {
> --
> 2.35.1
>

--
Kind Regards,
Caleb


  parent reply	other threads:[~2022-07-01 18:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-05  2:27 [PATCH 0/4] arm64: dts: qcom: Add a few LPG LEDs Bjorn Andersson
2022-05-05  2:27 ` [PATCH 1/4] arm64: dts: qcom: Add LPG to pm8916, pm8994, pmi8994 and pmi8998 Bjorn Andersson
2022-07-01 18:46   ` Caleb Connolly
2022-05-05  2:27 ` [PATCH 2/4] arm64: dts: qcom: sdm845: Enable user LEDs on DB845c Bjorn Andersson
2022-05-30  7:06   ` Pavel Machek
2022-06-30  3:54     ` Bjorn Andersson
2022-07-01 18:49   ` Caleb Connolly [this message]
2022-05-05  2:27 ` [PATCH 3/4] arm64: dts: qcom: pmi8994: Define MPP block Bjorn Andersson
2022-07-04 16:33   ` Dmitry Baryshkov
2022-05-05  2:27 ` [PATCH 4/4] arm64: dts: qcom: db820c: Add user LEDs Bjorn Andersson
2022-07-04 16:33   ` Dmitry Baryshkov
2022-07-01  6:08 ` [PATCH 0/4] arm64: dts: qcom: Add a few LPG LEDs Dylan Van Assche
2022-07-07  2:31 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d12442a6-a0f1-0cb4-caa0-b7bb22fff28d@connolly.tech \
    --to=caleb@connolly.tech \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.