All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Martin Weber <martin.weber@br-automation.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] V4L2_PIX_FMT_GREYSCALE for coda960 JPEG Encoder
Date: Thu, 11 Nov 2021 17:17:55 +0100	[thread overview]
Message-ID: <d125181203cd03cfb01eb5b4d86770b74d8d7b77.camel@pengutronix.de> (raw)
In-Reply-To: <VI1PR0602MB35495D33CD3DD897F0A41D5ED3929@VI1PR0602MB3549.eurprd06.prod.outlook.com>

Hi Martin,

On Tue, 2021-11-09 at 11:43 +0000, Martin Weber wrote:
> support greyscale pix fmt input for coda9_jpeg_encoder. The hardware
> supports it, so allow V4L2 Mem2Mem JPEG Encoder use it as well. Tested
> on an i.MX6QP.
> 
> Signed-off-by: Martin S. Weber <martin.weber@br-automation.com>

thank you for the patch! I never tested grayscale encoding, so I didn't
expect it to work out of the box :)

The code is fine, just a small formal issue: the subject should be in
the style used in the media subsystem. For example:

  media: coda: V4L2_PIX_FMT_GREY for coda960 JPEG encoder

(note that there is no V4L2_PIX_FMT_GREYSCALE). Please resend a v2 with
the subject fixed and feel free to add:

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

  reply	other threads:[~2021-11-11 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 11:43 [PATCH] V4L2_PIX_FMT_GREYSCALE for coda960 JPEG Encoder Martin Weber
2021-11-11 16:17 ` Philipp Zabel [this message]
2021-11-15 14:39   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d125181203cd03cfb01eb5b4d86770b74d8d7b77.camel@pengutronix.de \
    --to=p.zabel@pengutronix.de \
    --cc=linux-media@vger.kernel.org \
    --cc=martin.weber@br-automation.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.