All of lore.kernel.org
 help / color / mirror / Atom feed
From: "chengjian (D)" <cj.chengjian@huawei.com>
To: Jiri Kosina <jikos@kernel.org>,
	"chenzefeng (A)" <chenzefeng2@huawei.com>
Cc: "hjl.tools@gmail.com" <hjl.tools@gmail.com>,
	"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
	"sjenning@redhat.com" <sjenning@redhat.com>,
	"vojtech@suse.com" <vojtech@suse.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"live-patching@vger.kernel.org" <live-patching@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Xiexiuqi (Xie XiuQi)" <xiexiuqi@huawei.com>
Subject: Re: [PATCH] x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32
Date: Mon, 18 Feb 2019 13:29:11 +0800	[thread overview]
Message-ID: <d137b1a4-ae46-f529-15a0-cdc8fbfc6bbe@huawei.com> (raw)
In-Reply-To: <nycvar.YFH.7.76.1902150826400.11598@cbobk.fhfr.pm>

Hi，Jiri


This patch should be merged into 4.4 stable,

which still use klp_write_module_reloc.


https://elixir.bootlin.com/linux/v4.4.174/source/arch/x86/kernel/livepatch.c


ZeFeng may have sent a stable(4.4-y) patch to the wrong mail-list(mainline).


Thanks.

On 2019/2/15 15:28, Jiri Kosina wrote:
> On Fri, 15 Feb 2019, chenzefeng (A) wrote:
>
>> On x86-64, for 32-bit PC-relacive branches, we can generate PLT32
>> relocation, instead of PC32 relocation. and R_X86_64_PLT32 can be
>> treated the same as R_X86_64_PC32 since linux kernel doesn't use PLT.
>>
>> In linux 4.4 commit b21ebf2fb4cd ("x86: Treat R_X86_64_PLT32 as
>> R_X86_64_PC32") been fixed for the module loading, but not fixed for
>> livepatch relocation, which will fail to load livepatch with the error
>> message as follow: relocation failed for symbol <symbol name> at <symbol
>> address>
>>
>> Signed-off-by: chenzefeng <chenzefeng2@huawei.com>
> What kernel version is this patch based on? We've got rid of x86-specific
> module loading stub and offloaded all the relocation handling to generic
> kmod loader long time ago.
>



  parent reply	other threads:[~2019-02-18  5:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15  2:01 [PATCH] x86: livepatch: Treat R_X86_64_PLT32 as R_X86_64_PC32 chenzefeng (A)
2019-02-15  7:28 ` Jiri Kosina
2019-02-15  8:17   ` 答复: " chenzefeng (A)
2019-02-15  9:05     ` Petr Mladek
2019-02-18  5:29   ` chengjian (D) [this message]
2019-02-18  9:22     ` Petr Mladek
2019-02-18 11:47 ` gregkh
2019-02-19  8:16 chenzefeng (A)
2019-02-19  8:20 chenzefeng (A)
2019-02-20 12:37 chenzefeng (A)
2019-02-21  8:42 ` Petr Mladek
2019-02-21 11:47 ` gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d137b1a4-ae46-f529-15a0-cdc8fbfc6bbe@huawei.com \
    --to=cj.chengjian@huawei.com \
    --cc=chenzefeng2@huawei.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hjl.tools@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jikos@kernel.org \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=sjenning@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=vojtech@suse.com \
    --cc=x86@kernel.org \
    --cc=xiexiuqi@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.