From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57896)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1dRTaH-0003GQ-8t
	for qemu-devel@nongnu.org; Sat, 01 Jul 2017 21:21:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1dRTaG-00051S-Ib
	for qemu-devel@nongnu.org; Sat, 01 Jul 2017 21:21:57 -0400
Sender: Richard Henderson <rth7680@gmail.com>
References: <149865219962.17063.10630533069463266646.stgit@frigg.lan>
	<149865728578.17063.13455172137587126808.stgit@frigg.lan>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <d13da25b-0bad-73a2-1b6b-0af4e4a1dcb8@twiddle.net>
Date: Sat, 1 Jul 2017 18:21:48 -0700
MIME-Version: 1.0
In-Reply-To: <149865728578.17063.13455172137587126808.stgit@frigg.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v11 21/29] target/arm: [tcg] Port to
 breakpoint_check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?Q?Llu=c3=ads_Vilanova?= <vilanova@ac.upc.edu>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, "Emilio G. Cota" <cota@braap.org>, "open list:ARM" <qemu-arm@nongnu.org>, Paolo Bonzini <pbonzini@redhat.com>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>

On 06/28/2017 06:41 AM, Lluís Vilanova wrote:
> -        if (unlikely(dc->base.is_jmp > DISAS_NEXT)) {
> -            break;
> -        }
> -

Surely this doesn't go away til the final conversion.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~