From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/5] drm/i915: Wrap tasklet_struct for abuse Date: Thu, 10 May 2018 18:08:33 +0100 Message-ID: References: <20180509142801.28130-1-chris@chris-wilson.co.uk> <20180509142801.28130-2-chris@chris-wilson.co.uk> <7744bdb0-6320-39eb-41df-204e94cc24a2@linux.intel.com> <152596818655.19716.15751108971734864320@mail.alporthouse.com> <86122f1b-7022-5dfd-9bed-fcd8fab4e0c1@linux.intel.com> <152596916718.19716.1574559307186052501@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 728056EFD3 for ; Thu, 10 May 2018 17:08:36 +0000 (UTC) In-Reply-To: <152596916718.19716.1574559307186052501@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEwLzA1LzIwMTggMTc6MTksIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA1LTEwIDE3OjE1OjQ2KQo+Pgo+PiBPbiAxMC8wNS8yMDE4IDE3OjAz LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTA1 LTEwIDE2OjQ5OjAzKQo+Pj4+Cj4+Pj4gT24gMDkvMDUvMjAxOCAxNToyNywgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBJbiB0aGUgbmV4dCBmZXcgcGF0Y2hlcywgd2Ugd2FudCB0byBhYnVzZSB0 YXNrbGV0IHRvIGF2b2lkIGtzb2Z0aXJxZAo+Pj4+PiBsYXRlbmN5IGFsb25nIGNyaXRpY2FsIHBh dGhzLiBUbyBtYWtlIHRoYXQgYWJ1c2UgZWFzaWx5IHRvIHN3YWxsb3csCj4+Pj4+IGZpcnN0IGNv YXQgdGhlIHRhc2tsZXQgaW4gYSBsaXR0bGUgc3ludGFjdGljIHN1Z2FyLgo+Pj4+Pgo+Pj4+PiBT aWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPj4+ Pj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4+Pj4+IC0t LQo+Pj4+PiArc3RhdGljIGlubGluZSB2b2lkIGk5MTVfdGFza2xldF91bmxvY2soc3RydWN0IGk5 MTVfdGFza2xldCAqdCkKPj4+Pj4gK3sKPj4+Pj4gKyAgICAgdGFza2xldF9lbmFibGUoJnQtPmJh c2UpOwo+Pj4+PiArfQo+Pj4+Cj4+Pj4gSSBhZ3JlZSBrZWVwaW5nIHRoZSBvcmlnaW5hbCBuYW1p bmcgZm9yIGtpbGwvZW5hYmxlL2Rpc2FibGUgd291bGQgYmUgYmV0dGVyLgo+Pj4+Cj4+Pj4+ICsK Pj4+Pj4gK3N0YXRpYyBpbmxpbmUgdm9pZCBpOTE1X3Rhc2tsZXRfc2V0X2Z1bmMoc3RydWN0IGk5 MTVfdGFza2xldCAqdCwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgdm9pZCAoKmZ1bmMpKHVuc2lnbmVkIGxvbmcgZGF0YSksCj4+Pj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcgZGF0YSkKPj4+Pj4gK3sKPj4+ Pj4gKyAgICAgaTkxNV90YXNrbGV0X2xvY2sodCk7Cj4+Pj4+ICsKPj4+Pj4gKyAgICAgdC0+YmFz ZS5mdW5jID0gZnVuYzsKPj4+Pj4gKyAgICAgdC0+YmFzZS5kYXRhID0gZGF0YTsKPj4+Pj4gKwo+ Pj4+PiArICAgICBpOTE1X3Rhc2tsZXRfdW5sb2NrKHQpOwo+Pj4+Cj4+Pj4gSSBraW5kIG9mIHJl bWVtYmVyIHNvbWV0aGluZyBhYm91dCBpc3N1ZXMgd2UgaGFkIHdpdGggcGxhY2luZwo+Pj4+IHRh c2tsZXRfZGlzYWJsZSBwbGFjZWQgaW4gc29tZSBjb250ZXh0cy4gSG0uLiBpZiBvbmx5IEkgY291 bGQgcmVjYWxsIHRoZQo+Pj4+IGRldGFpbHMuIEl0J3MgcHJvYmFibHkgZmluZS4gSSBjYW5ub3Qg Y29tZSB1cCB3aXRoIGlkZWFzIG9uIGhvdyB0bwo+Pj4+IHByb3RlY3QgYWdhaW5zdCB0aGF0LiBH RU1fQlVHX09OKGluX2lycSgpIHx8IGluX3NvZnRpcnEoKSk/IFRvbyBmYXIKPj4+PiBmZXRjaGVk IHByb2JhYmx5Lgo+Pj4KPj4+IFdoZW4gd2UgZ2V0IGl0IHdyb25nLCBDSSBjb21wbGFpbnMgd2l0 aCBhIGxvY2sgdXAuIEl0IGNhbm5vdCBiZSB1c2VkIGluCj4+PiBhdG9taWMgY29udGV4dCBhcyBp dCB1c2VzIHlpZWxkKCkgdG8ga2ljayB0aGUgdGFza2xldCAoYXMgaXQgbWF5IGJlIG9uCj4+PiB0 aGUgbG9jYWwgY3B1KS4KPj4+Cj4+Pj4+IEBAIC0yMjA5LDcgKzIyMDgsMTAgQEAgc3RhdGljIHZv aWQgZXhlY2xpc3RzX3NldF9kZWZhdWx0X3N1Ym1pc3Npb24oc3RydWN0IGludGVsX2VuZ2luZV9j cyAqZW5naW5lKQo+Pj4+PiAgICAgICAgIGVuZ2luZS0+c3VibWl0X3JlcXVlc3QgPSBleGVjbGlz dHNfc3VibWl0X3JlcXVlc3Q7Cj4+Pj4+ICAgICAgICAgZW5naW5lLT5jYW5jZWxfcmVxdWVzdHMg PSBleGVjbGlzdHNfY2FuY2VsX3JlcXVlc3RzOwo+Pj4+PiAgICAgICAgIGVuZ2luZS0+c2NoZWR1 bGUgPSBleGVjbGlzdHNfc2NoZWR1bGU7Cj4+Pj4+IC0gICAgIGVuZ2luZS0+ZXhlY2xpc3RzLnRh c2tsZXQuZnVuYyA9IGV4ZWNsaXN0c19zdWJtaXNzaW9uX3Rhc2tsZXQ7Cj4+Pj4+ICsKPj4+Pj4g KyAgICAgaTkxNV90YXNrbGV0X3NldF9mdW5jKCZlbmdpbmUtPmV4ZWNsaXN0cy50YXNrbGV0LAo+ Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgZXhlY2xpc3RzX3N1Ym1pc3Npb25fdGFz a2xldCwKPj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICh1bnNpZ25lZCBsb25nKWVu Z2luZSk7Cj4+Pj4KPj4+PiBPciBlbGltaW5hdGUgdGhlIGFib3ZlIGRpbGVtbWEgYnkgcmVtb3Zp bmcgdGhlIGRhdGEgcGFyYW1ldGVyIGZyb20KPj4+PiBpOTE1X3Rhc2tsZXRfc2V0X2Z1bmMgc2lu Y2UgaXQgbG9va3MgaXQgaXMgbm90IG5lZWRlZCBhdCB0aGUgbW9tZW50Pwo+Pj4KPj4+IEl0IGRv ZXNuJ3QgZWxpbWluYXRlIHRoZSBkaWxlbW1hLCB1cGRhdGluZyB0aGUgZnVuYyBpdHNlbGYgcmFp c2VzIHRoZQo+Pj4gcXVlc3Rpb24gb2Ygd2hhdCBpZiB0aGUgdGFza2xldCBpcyBydW5uaW5nIGF0 IHRoYXQgdGltZSwgd2hhdCB3YXMgdGhlCj4+PiBjYWxsZXIgdGhpbmtpbmcgd291bGQgaGFwcGVu Pwo+Pgo+PiBXZWxsIHNhbWUgYXMgaXQgY2FuIGRvIG5vdyBzbyB5b3UgY291bGQgZHJvcCB0YXNr bGV0X2Rpc2FibGUvZW5hYmxlCj4+IHRoZW4uIEF0IGxlYXN0IEkgYXNzdW1lZCB0aGUgcHVycG9z ZSBpcyBmb3IgYXRvbWljaXR5IG9mIGZ1bmMvZGF0YSB1cGRhdGVzLgo+IAo+IFN1cmUsIGl0IG1v c3RseSB0aGVyZSB0byBjYXRjaCB1c2luZyBpdCBmcm9tIHNpbGx5IGNpcmN1bXN0YW5jZXMgd2hl cmUKPiB0aGUgdGFza2xldCBtYXkgYmUgYmVpbmcgY2FsbGVkIGFzIHRoZSBjaGFuZ2Ugb2NjdXJz LiBTaG91bGQgbmV2ZXIKPiBoYXBwZW4sIHNvIEkgYmV0IGl0IGRvZXMuCgpZb3UgY291bGQgZG8g c2ltaWxhciBieSBhc3NlcnRpbmcgdGFza2xldCBpcyBlaXRoZXIgZGlzYWJsZWQsIG9yIGF0IAps ZWFzdCBub3QgcnVubmluZy4KCj4+PiBJIGV4cGVjdCB0YXNrbGV0cyB3aWxsIHN0YXJ0IHBhc3Np bmcgdGhlbXNlbHZlcyB0byB0aGUgZnVuYyBhbmQKPj4+IGVsaW1pbmF0ZSB0aGUgZGF0YSBwYXJh bWV0ZXJzIHRoZW1zZWx2ZXMgYXQgc29tZSBwb2ludCBpbiB0aGUgbWlkIHRlcm0uCj4+Cj4+IE5l ZWRzIHRvIGJlIHRhc2tsZXRfZGlzYWJsZV9ub3N5bmMgdGhlbiwgb3IgaXQgd2lsbCBoYW5nLiBC dXQgdGhlbiBpdAo+PiBsb3NlcyBpdHMgcHVycG9zZSBhbnl3YXkuIFNvIEkgYW0gY29uZnVzZWQu Cj4gCj4gSSB3YXMganVzdCByZWZlcnJpbmcgdG8gbXkgaG9wZSB0aGF0IHRoZSB1bnNpZ25lZCBs b25nIGRhdGEgcGFyYW1ldGVyCj4gd2lsbCBiZSBtb3ZlZCB0byB0aGUgZ3JlYXQgZHVzdGJpbiBv ZiBoaXN0b3J5LiBJZiB0aW1lcnMgY2FuIG1ha2UgdGhlCj4gbGVhcCwgc28gY2FuIHRhc2tsZXRz IQoKSSBqdXN0IGRvbid0IHNlZSB0aGUgcG9pbnQgaW4gYWRkaW5nIHRoZSBzZWNvbmQgcGFyYW1l dGVyIG5vdy4gSSBtZWFuIAppdCdzIG5vdCBhIGJpZyBkZWFsLCBidXQgSSBkb24ndCBzZWUgaXQg dXNlZnVsLgoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK