All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michael.christie@oracle.com>
To: Muneendra <muneendra.kumar@broadcom.com>,
	linux-scsi@vger.kernel.org, hare@suse.de
Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com
Subject: Re: [PATCH v3 03/17] scsi: No retries on abort success
Date: Mon, 19 Oct 2020 14:05:15 -0500	[thread overview]
Message-ID: <d13fc9bd-a5da-134f-df21-33f8ac14f7b8@oracle.com> (raw)
In-Reply-To: <1602732462-10443-4-git-send-email-muneendra.kumar@broadcom.com>

On 10/14/20 10:27 PM, Muneendra wrote:
>   check_type:
> +	/*
> +	 * Check whether caller has decided not to do retries on
> +	 * abort success by setting the SCMD_NORETRIES_ABORT bit
> +	 */
> +	if ((test_bit(SCMD_NORETRIES_ABORT, &scmd->state)) &&
> +		(scmd->request->cmd_flags & REQ_FAILFAST_TRANSPORT)) {
> +		set_host_byte(scmd, DID_TRANSPORT_MARGINAL);

Hey, one other thing that might be confusing me is this check and the 
naming. The 0/17 email description and the SCMD_NORETRIES_ABORT name 
makes me think we want to only run this if the cmd timedout and we went 
through the SCSI EH TMF operations. However, I think this will end up 
failing other errors with DID_TRANSPORT_MARGINAL right?

Did you want just the the SCSI EH timeout/abort case to hit this or any 
errors that hit this code path?

> +		return 1;
> +	}
> +

  parent reply	other threads:[~2020-10-19 19:05 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-15  3:27 [PATCH v3 00/17] scsi: Support to handle Intermittent errors Muneendra
2020-10-15  3:27 ` [PATCH v3 01/17] scsi: Added a new definition in scsi_cmnd.h Muneendra
2020-10-15  3:27 ` [PATCH v3 02/17] scsi: Added a new error code in scsi.h Muneendra
2020-10-15  3:27 ` [PATCH v3 03/17] scsi: No retries on abort success Muneendra
2020-10-16 18:37   ` Mike Christie
2020-10-19 19:05   ` Mike Christie [this message]
2020-10-19 19:26     ` Muneendra Kumar M
2020-10-20 19:53       ` Mike Christie
2020-10-20 20:18         ` Mike Christie
2020-10-21 18:51           ` Muneendra Kumar M
2020-10-15  3:27 ` [PATCH v3 04/17] scsi: Added routine to set/clear SCMD_NORETRIES_ABORT bit for outstanding io on scsi_dev Muneendra
2020-10-15  3:27 ` [PATCH v3 05/17] scsi_transport_fc: Added a new rport state FC_PORTSTATE_MARGINAL Muneendra
2020-10-16 19:52   ` Mike Christie
2020-10-19 10:47     ` Muneendra Kumar M
2020-10-19 16:10       ` Michael Christie
2020-10-19 16:19         ` Michael Christie
2020-10-19 17:16           ` Hannes Reinecke
2020-10-19 17:31             ` Muneendra Kumar M
2020-10-19 18:55               ` Mike Christie
2020-10-19 19:03                 ` Muneendra Kumar M
2020-10-20 18:24                   ` Benjamin Marzinski
2020-10-20  6:03                 ` Hannes Reinecke
2020-10-19 18:03             ` Muneendra Kumar M
2020-10-19 18:44               ` Mike Christie
2020-10-19 18:55                 ` Muneendra Kumar M
2020-10-20 16:48                   ` Mike Christie
2020-10-20 17:19                     ` Muneendra Kumar M
2020-10-20 18:44                       ` Benjamin Marzinski
2020-10-20 18:14                   ` Benjamin Marzinski
2020-10-15  3:27 ` [PATCH v3 06/17] scsi_transport_fc: Added store fucntionality to set the rport port_state using sysfs Muneendra
2020-10-15 14:05   ` kernel test robot
2020-10-15 14:05     ` kernel test robot
2020-10-16 18:34   ` Mike Christie
2020-10-19 10:52     ` Muneendra Kumar M
2020-10-15  3:27 ` [PATCH v3 07/17] scsi:lpfc: Added changes to fc_remote_port_chkready Muneendra
2020-10-15  3:27 ` [PATCH v3 08/17] scsi:qla2xx: " Muneendra
2020-10-15  3:27 ` [PATCH v3 09/17] scsi:qedf: " Muneendra
2020-10-15  3:27 ` [PATCH v3 10/17] scsi:libfc: " Muneendra
2020-10-15  3:27 ` [PATCH v3 11/17] scsi:ibmvfc: " Muneendra
2020-10-15  3:27 ` [PATCH v3 12/17] scsi:fnic: " Muneendra
2020-10-15  3:27 ` [PATCH v3 13/17] scsi:bnx2fc: " Muneendra
2020-10-15  3:27 ` [PATCH v3 14/17] scsi:csio: " Muneendra
2020-10-15  3:27 ` [PATCH v3 15/17] scsi:bfa: " Muneendra
2020-10-15  3:27 ` [PATCH v3 16/17] scsi:zfcp: " Muneendra
2020-10-22 16:50   ` Benjamin Block
2020-10-15  3:27 ` [PATCH v3 17/17] scsi:mpt: " Muneendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d13fc9bd-a5da-134f-df21-33f8ac14f7b8@oracle.com \
    --to=michael.christie@oracle.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=jsmart2021@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mkumar@redhat.com \
    --cc=muneendra.kumar@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.