All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>, qemu-devel@nongnu.org
Cc: Anton Nefedov <anton.nefedov@virtuozzo.com>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v3 0/3] kvm: report available guest crash parameters
Date: Wed, 15 Feb 2017 17:47:45 +0100	[thread overview]
Message-ID: <d150ddd6-ba35-b2d2-28be-231949927d3d@redhat.com> (raw)
In-Reply-To: <1487053524-18674-1-git-send-email-den@openvz.org>

On 14/02/2017 07:25, Denis V. Lunev wrote:
> Windows reports BSOD parameters through Hyper-V crash MSRs. This
> information is very useful for initial crash analysis and thus
> it would be nice to see it in the QEMU log file. There is suitable
> log mask for the purpose.
> 
> Linux guest does not provide this information, but still it would
> be nice to log that we have crashed.
> 
> Changes from v3:
> - existing kvm_cpu_synchronize_state() used to fetch HV crash MSRs
>   (hence, no separate storage for these MSRs in struct X86CPU anymore)

Nice. :)

> - qapi_free_GuestPanicInformation() used to release memory
> 
> Changes from v2:
> - fixed PPC compilation
> 
> Changes since v1:
> - patches resplit
> - created property to query crash parameters
> - crash parameters added to panic event
> 
> Signed-off-by: Anton Nefedov <anton.nefedov@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> CC: Marcelo Tosatti <mtosatti@redhat.com>
> CC: Richard Henderson <rth@twiddle.net>
> CC: Eduardo Habkost <ehabkost@redhat.com>
> CC: Eric Blake <eblake@redhat.com>
> CC: Markus Armbruster <armbru@redhat.com>
> 
> Anton Nefedov (3):
>   i386/cpu: add crash-information QOM property
>   report guest crash information in GUEST_PANICKED event
>   vl: log available guest crash information
> 
>  hw/misc/pvpanic.c       |  2 +-
>  hw/ppc/spapr_rtas.c     |  3 ++-
>  include/qom/cpu.h       | 10 +++++++++
>  include/sysemu/kvm.h    |  2 ++
>  include/sysemu/sysemu.h |  2 +-
>  kvm-all.c               |  3 ++-
>  qapi-schema.json        | 24 +++++++++++++++++++++
>  qapi/event.json         |  6 ++++--
>  qom/cpu.c               | 11 ++++++++++
>  stubs/Makefile.objs     |  1 +
>  stubs/kvm-crash.c       |  8 +++++++
>  target/i386/cpu.c       | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
>  target/i386/cpu.h       |  3 +++
>  target/i386/kvm.c       | 41 ++++++++++++++++++++++++++++++++++++
>  target/s390x/kvm.c      |  4 ++--
>  vl.c                    | 23 ++++++++++++++++++---
>  16 files changed, 187 insertions(+), 11 deletions(-)
>  create mode 100644 stubs/kvm-crash.c
> 

Queued for 2.9, thanks!

Paolo

  parent reply	other threads:[~2017-02-15 16:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-14  6:25 [Qemu-devel] [PATCH v3 0/3] kvm: report available guest crash parameters Denis V. Lunev
2017-02-14  6:25 ` [Qemu-devel] [PATCH v4 1/3] i386/cpu: add crash-information QOM property Denis V. Lunev
2017-02-15 19:41   ` Eric Blake
2017-02-20  0:53     ` Markus Armbruster
2017-02-20 18:32   ` Daniel P. Berrange
2017-02-14  6:25 ` [Qemu-devel] [PATCH v4 2/3] report guest crash information in GUEST_PANICKED event Denis V. Lunev
2017-02-15 19:43   ` Eric Blake
2017-02-14  6:25 ` [Qemu-devel] [PATCH v4 3/3] vl: log available guest crash information Denis V. Lunev
2017-02-15 16:47 ` Paolo Bonzini [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-02-13  7:08 [Qemu-devel] [PATCH v3 0/3] kvm: report available guest crash parameters Denis V. Lunev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d150ddd6-ba35-b2d2-28be-231949927d3d@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=anton.nefedov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@openvz.org \
    --cc=ehabkost@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.