Hi Andy,

On 5.01.2022 13:24, kernel test robot wrote:
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on linusw-pinctrl/devel]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Rafa-Mi-ecki/dt-bindings-pinctrl-Add-binding-for-BCM4908-pinctrl/20211222-191252
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
> config: ia64-randconfig-r036-20220105 (https://download.01.org/0day-ci/archive/20220105/202201052056.f2jSr4cB-lkp(a)intel.com/config)
> compiler: ia64-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>          chmod +x ~/bin/make.cross
>          # https://github.com/0day-ci/linux/commit/337a257cc34c7f7e883bf90ccade5bf4fb71684b
>          git remote add linux-review https://github.com/0day-ci/linux
>          git fetch --no-tags linux-review Rafa-Mi-ecki/dt-bindings-pinctrl-Add-binding-for-BCM4908-pinctrl/20211222-191252
>          git checkout 337a257cc34c7f7e883bf90ccade5bf4fb71684b
>          # save the config file to linux build tree
>          mkdir build_dir
>          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>     ia64-linux-ld: drivers/pinctrl/bcm/pinctrl-bcm4908.o: in function `pinconf_generic_dt_node_to_map_group':
>>> pinctrl-bcm4908.c:(.text+0x262): undefined reference to `pinconf_generic_dt_node_to_map'
>>> ia64-linux-ld: drivers/pinctrl/bcm/pinctrl-bcm4908.o:(.data.rel.ro+0x78): undefined reference to `pinconf_generic_dt_free_map'

Above answers your old question (see below) ;)


On 16.12.2021 20:55, Andy Shevchenko wrote:> On Thu, Dec 16, 2021 at 1:25 AM Rafał Miłecki <zajec5@gmail.com> wrote:
 >>
 >> From: Rafał Miłecki <rafal@milecki.pl>
 >>
 >> BCM4908 has its own pins layout so it needs a custom binding and a Linux
 >> driver.
 >
 > ...
 >
 >> +config PINCTRL_BCM4908
 >> +       bool "Broadcom BCM4908 pinmux driver"
 >
 > Why not tristate?
 >
 >> +       depends on OF && (ARCH_BCM4908 || COMPILE_TEST)
 >
 > Is there really dependency to OF?

Yes, without OF pinconf_generic_dt_node_to_map() is not available.