From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751948AbcIICLj (ORCPT ); Thu, 8 Sep 2016 22:11:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:37231 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751667AbcIICLf (ORCPT ); Thu, 8 Sep 2016 22:11:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,303,1470726000"; d="scan'208";a="876683830" From: Kuppuswamy Sathyanarayanan To: andriy.shevchenko@linux.intel.com, wharms@bfs.de Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, david.a.cohen@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Subject: [PATCH v3 3/3] intel-mid: Move boundry check to the start of init code Date: Thu, 8 Sep 2016 19:07:10 -0700 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: <1473210255-227672-1-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> References: <1473210255-227672-1-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Moved the instance boundary check to the start of the pcal9555a platform init code. This will prevent unnecessary initialization on instance boundary error. Signed-off-by: Kuppuswamy Sathyanarayanan --- arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c b/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c index cde764e..4e5dd95 100644 --- a/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c +++ b/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c @@ -34,6 +34,12 @@ static void __init *pcal9555a_platform_data(void *info) char intr_pin_name[SFI_NAME_LEN + 1]; int gpio_base, intr; + if (nr >= PCAL9555A_NUM) { + pr_err("%s: Too many instances, only %d supported\n", __func__, + PCAL9555A_NUM); + return ERR_PTR(-ENOMEM); + } + snprintf(base_pin_name, sizeof(base_pin_name), "%s_base", type); snprintf(intr_pin_name, sizeof(intr_pin_name), "%s_int", type); @@ -47,12 +53,6 @@ static void __init *pcal9555a_platform_data(void *info) return NULL; } - if (nr >= PCAL9555A_NUM) { - pr_err("%s: Too many instances, only %d supported\n", __func__, - PCAL9555A_NUM); - return ERR_PTR(-ENOMEM); - } - pcal9555a = &pcal9555a_pdata[nr++]; pcal9555a->gpio_base = gpio_base; -- 2.7.4 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuppuswamy Sathyanarayanan Date: Fri, 09 Sep 2016 02:07:10 +0000 Subject: [PATCH v3 3/3] intel-mid: Move boundry check to the start of init code Message-Id: List-Id: References: <1473210255-227672-1-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> In-Reply-To: <1473210255-227672-1-git-send-email-sathyanarayanan.kuppuswamy@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: andriy.shevchenko@linux.intel.com, wharms@bfs.de Cc: dan.carpenter@oracle.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, david.a.cohen@linux.intel.com, sathyanarayanan.kuppuswamy@linux.intel.com Moved the instance boundary check to the start of the pcal9555a platform init code. This will prevent unnecessary initialization on instance boundary error. Signed-off-by: Kuppuswamy Sathyanarayanan --- arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c b/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c index cde764e..4e5dd95 100644 --- a/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c +++ b/arch/x86/platform/intel-mid/device_libs/platform_pcal9555a.c @@ -34,6 +34,12 @@ static void __init *pcal9555a_platform_data(void *info) char intr_pin_name[SFI_NAME_LEN + 1]; int gpio_base, intr; + if (nr >= PCAL9555A_NUM) { + pr_err("%s: Too many instances, only %d supported\n", __func__, + PCAL9555A_NUM); + return ERR_PTR(-ENOMEM); + } + snprintf(base_pin_name, sizeof(base_pin_name), "%s_base", type); snprintf(intr_pin_name, sizeof(intr_pin_name), "%s_int", type); @@ -47,12 +53,6 @@ static void __init *pcal9555a_platform_data(void *info) return NULL; } - if (nr >= PCAL9555A_NUM) { - pr_err("%s: Too many instances, only %d supported\n", __func__, - PCAL9555A_NUM); - return ERR_PTR(-ENOMEM); - } - pcal9555a = &pcal9555a_pdata[nr++]; pcal9555a->gpio_base = gpio_base; -- 2.7.4