From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751924AbdAVSPc (ORCPT ); Sun, 22 Jan 2017 13:15:32 -0500 Received: from mout.web.de ([217.72.192.78]:52824 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbdAVSPZ (ORCPT ); Sun, 22 Jan 2017 13:15:25 -0500 Subject: [PATCH 5/9] KVM: Improve size determinations in kvm_vcpu_ioctl() To: kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= References: Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Sun, 22 Jan 2017 19:15:12 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:VTSKFWfalS83eoOkYxsgukRrvDunV08NVTb+wJF5C8lCg0ZeHVP b+eFm3x3qSFP4eANu+HUHqcyJROD9/hEaFmM7lwMO/l1C8HMauMdlf571KfTyjKlfYfVLlV vcZzwZfnenm8vjynjz7Z3+GkmrpPRCcf+EbwgvmeK1Qzd26dXwC69HS6EVvbMQIa4yTAt9P CM2FPtDNA6ijI1Nf+OiEA== X-UI-Out-Filterresults: notjunk:1;V01:K0:1cUxSvJ/OV4=:yEkx0Jr8Oijn0s1cWByHgl lbbjafVH2L30u4434x+ZyZ+WrtWmVnoxiEHXPCPd8cGf56yqSgE2h7K8fQrfQbkwTZWn4OFj3 hq8lET2kfNHOaYQIiI5pO8P3hILK5AwBMxNzhI+Q22WCDjzuU4n1JzzVNjT4sj+yKyWm+XRss A+/M+8VyBBcdIVICv7hNkj1Qyc6hCfgRIr6qDZS+wQ0IZEMh0rdqa5thjHqzWQvx7Ulu5cKS7 6z0l2DCwDxAPPdC9svPlm2byWGdgcVlpujmmw6YTHrsYDMP7Jagw+z+gI55lksRYFfQdwFpqC hr/hWYCCUX/Ggp69dq21EidLv59zYvYU/ck1fVWDx5wnaNYR2zPCN0AGRTFld0qc3QR6Zs7FN FJKX8n+n52by81i1H24wGWritdWWKgfJDbOJVSTR9cUAFyPe/isjGRYK3vpmUei+SId+P+Koh kaTzYnKCcsvwIEOndv18fJFZLYbPl+GO038lmtmWzHzb1wsKpmV/2TraLBucDd20JQSQpXGAl GbawVNJ5qSHhmh0QHNlndgpXmsjUv3SdzdiIeOModRYyP3gVQ9PsbhOwnV9XRPbgYrwEf4q4S ERBTEbNAWlbgxsI0ZknAYjtJr5qQz11btSmaELLFD51AHj+rkCO4+fn5qfwzVBBE5Xda1GHGc LrimrI/KvXt7bZBMk2HACoRJWL/OehHYVCe247jev/3yxBsBUL/klOce3Tdl3NNZvUdHsRNlL 58PNFRIfzhqOcBIQNFMmSICovJzPXRzLVaju9u8tFV/u6dN0yshmFu1RWAkHOUM1w6xV3BvoV /HaujUw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 22 Jan 2017 17:11:16 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- virt/kvm/kvm_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 9d463b7a3912..6a74a3796b3f 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2569,7 +2569,7 @@ static long kvm_vcpu_ioctl(struct file *filp, case KVM_GET_REGS: { struct kvm_regs *kvm_regs; - kvm_regs = kzalloc(sizeof(struct kvm_regs), GFP_KERNEL); + kvm_regs = kzalloc(sizeof(*kvm_regs), GFP_KERNEL); if (!kvm_regs) { r = -ENOMEM; goto put_vcpu; @@ -2577,7 +2577,7 @@ static long kvm_vcpu_ioctl(struct file *filp, r = kvm_arch_vcpu_ioctl_get_regs(vcpu, kvm_regs); if (r) goto free_regs; - if (copy_to_user(argp, kvm_regs, sizeof(struct kvm_regs))) + if (copy_to_user(argp, kvm_regs, sizeof(*kvm_regs))) r = -EFAULT; free_regs: kfree(kvm_regs); @@ -2598,7 +2598,7 @@ static long kvm_vcpu_ioctl(struct file *filp, case KVM_GET_SREGS: { struct kvm_sregs *kvm_sregs; - kvm_sregs = kzalloc(sizeof(struct kvm_sregs), GFP_KERNEL); + kvm_sregs = kzalloc(sizeof(*kvm_sregs), GFP_KERNEL); if (!kvm_sregs) { r = -ENOMEM; goto put_vcpu; @@ -2606,7 +2606,7 @@ static long kvm_vcpu_ioctl(struct file *filp, r = kvm_arch_vcpu_ioctl_get_sregs(vcpu, kvm_sregs); if (r) goto free_sregs; - if (copy_to_user(argp, kvm_sregs, sizeof(struct kvm_sregs))) + if (copy_to_user(argp, kvm_sregs, sizeof(*kvm_sregs))) r = -EFAULT; free_sregs: kfree(kvm_sregs); @@ -2697,7 +2697,7 @@ static long kvm_vcpu_ioctl(struct file *filp, case KVM_GET_FPU: { struct kvm_fpu *fpu; - fpu = kzalloc(sizeof(struct kvm_fpu), GFP_KERNEL); + fpu = kzalloc(sizeof(*fpu), GFP_KERNEL); if (!fpu) { r = -ENOMEM; goto put_vcpu; @@ -2705,7 +2705,7 @@ static long kvm_vcpu_ioctl(struct file *filp, r = kvm_arch_vcpu_ioctl_get_fpu(vcpu, fpu); if (r) goto free_fpu; - if (copy_to_user(argp, fpu, sizeof(struct kvm_fpu))) + if (copy_to_user(argp, fpu, sizeof(*fpu))) r = -EFAULT; free_fpu: kfree(fpu); -- 2.11.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 22 Jan 2017 18:15:12 +0000 Subject: [PATCH 5/9] KVM: Improve size determinations in kvm_vcpu_ioctl() Message-Id: List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= Cc: LKML , kernel-janitors@vger.kernel.org From: Markus Elfring Date: Sun, 22 Jan 2017 17:11:16 +0100 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- virt/kvm/kvm_main.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 9d463b7a3912..6a74a3796b3f 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -2569,7 +2569,7 @@ static long kvm_vcpu_ioctl(struct file *filp, case KVM_GET_REGS: { struct kvm_regs *kvm_regs; - kvm_regs = kzalloc(sizeof(struct kvm_regs), GFP_KERNEL); + kvm_regs = kzalloc(sizeof(*kvm_regs), GFP_KERNEL); if (!kvm_regs) { r = -ENOMEM; goto put_vcpu; @@ -2577,7 +2577,7 @@ static long kvm_vcpu_ioctl(struct file *filp, r = kvm_arch_vcpu_ioctl_get_regs(vcpu, kvm_regs); if (r) goto free_regs; - if (copy_to_user(argp, kvm_regs, sizeof(struct kvm_regs))) + if (copy_to_user(argp, kvm_regs, sizeof(*kvm_regs))) r = -EFAULT; free_regs: kfree(kvm_regs); @@ -2598,7 +2598,7 @@ static long kvm_vcpu_ioctl(struct file *filp, case KVM_GET_SREGS: { struct kvm_sregs *kvm_sregs; - kvm_sregs = kzalloc(sizeof(struct kvm_sregs), GFP_KERNEL); + kvm_sregs = kzalloc(sizeof(*kvm_sregs), GFP_KERNEL); if (!kvm_sregs) { r = -ENOMEM; goto put_vcpu; @@ -2606,7 +2606,7 @@ static long kvm_vcpu_ioctl(struct file *filp, r = kvm_arch_vcpu_ioctl_get_sregs(vcpu, kvm_sregs); if (r) goto free_sregs; - if (copy_to_user(argp, kvm_sregs, sizeof(struct kvm_sregs))) + if (copy_to_user(argp, kvm_sregs, sizeof(*kvm_sregs))) r = -EFAULT; free_sregs: kfree(kvm_sregs); @@ -2697,7 +2697,7 @@ static long kvm_vcpu_ioctl(struct file *filp, case KVM_GET_FPU: { struct kvm_fpu *fpu; - fpu = kzalloc(sizeof(struct kvm_fpu), GFP_KERNEL); + fpu = kzalloc(sizeof(*fpu), GFP_KERNEL); if (!fpu) { r = -ENOMEM; goto put_vcpu; @@ -2705,7 +2705,7 @@ static long kvm_vcpu_ioctl(struct file *filp, r = kvm_arch_vcpu_ioctl_get_fpu(vcpu, fpu); if (r) goto free_fpu; - if (copy_to_user(argp, fpu, sizeof(struct kvm_fpu))) + if (copy_to_user(argp, fpu, sizeof(*fpu))) r = -EFAULT; free_fpu: kfree(fpu); -- 2.11.0