From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick DELAUNAY <patrick.delaunay@st.com>
Date: Mon, 10 Dec 2018 11:01:59 +0000
Subject: [U-Boot] [PATCH v2 1/2] spl_spi: Read default speed and mode
 values from DT
In-Reply-To: <CAAh8qsx0KV0TGu3pKzM-Yg5xdXNExRTUYA_HRi00yWqy2sPpwg@mail.gmail.com>
References: <1542648790-21362-1-git-send-email-patrick.delaunay@st.com>
 <1542648790-21362-2-git-send-email-patrick.delaunay@st.com>
 <7828272b-a824-d56f-9e46-159d7d959859@gmail.com>
 <28c7e7892f2a4b09b9ec5f3a4039716e@SFHDAG6NODE3.st.com>
 <CAAh8qswHteqKOH8QEOBx-AD9999deyUzP9P6_smDmWsx0O8D4w@mail.gmail.com>
 <2426327b2d2b4568a1e03d8594045c85@SFHDAG6NODE3.st.com>
 <CAAh8qsx0KV0TGu3pKzM-Yg5xdXNExRTUYA_HRi00yWqy2sPpwg@mail.gmail.com>
Message-ID: <d16a1c79e1414715a56bb905bdcf2d93@GPXDAG6NODE6.st.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Simon,

> From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> Sent: mardi 27 novembre 2018 13:55
> Subject: Re: [PATCH v2 1/2] spl_spi: Read default speed and mode values from DT
> 
> On Tue, Nov 27, 2018 at 1:33 PM Patrick DELAUNAY
> <patrick.delaunay@st.com> wrote:
> >
> > Hi Simon,
> >
> > > From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> > > Sent: mardi 27 novembre 2018 09:11
> >
> > >
> > > On Tue, Nov 27, 2018 at 9:06 AM Patrick DELAUNAY
> > > <patrick.delaunay@st.com> wrote:
> > > >
> > > > Hi Simon,
> > > >
> > > > > -----Original Message-----
> > > > > From: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> > > > > Sent: lundi 19 novembre 2018 20:09
> > > > >
> > > > > On 19.11.2018 18:33, Patrick Delaunay wrote:
> > > > >
> > > > > I do think it would be nice to invert the logic. That way, we
> > > > > could get completely rid of those two CONFIG_SF_DEFAULT settings
> > > > > for DM_SPI_FLASH boards (and eventually for all boards - when's
> > > > > the deadline
> > > for that?).
> > > > > But there are other places that still do it like you do here, so
> > > > > it's probably better to change them all at once...
> > > >
> > > > Agree with you.
> > > >
> > > > In fact I hesitate with directly change the header file
> > > >
> > > > #ifdef CONFIG_DM_SPI_FLASH
> > > >         /* In DM mode defaults will be taken from DT */
> > > >         #define CONFIG_SF_DEFAULT_SPEED 0
> > > >         #define CONFIG_SF_DEFAULT_MODE 0 #endif
> > >
> > > This looks correct to me.
> > >
> > > > But I am afraid of the potential impacts (define is used in many
> > > > boards), but I think it sould be more cleaner way to force the
> > > > expected
> > > behavior.
> > >
> > > Can't we just push this and fix whatever it breaks?
> >
> > Yes I can push it, what is the correct patch strategy.
> >
> > 1/ accept this patch (for short term solution) and propose a update after (I can
> do it next week).
> 
> I'm totally OK with 1, yes. That's why I've already sent my reviewed-by. But I
> would really appreciate a later update, this got me confused already... ;-)

For information I send the new serie today named  
"[PATCH 0/7] Remove defines for SPI default speed and mode"

http://patchwork.ozlabs.org/project/uboot/list/?series=80769 

Finally I propose to remove the 2 defines when the SPI DM migration will be completed.

> Regards,
> Simon

Regards Patrick.