From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A953C6778A for ; Sun, 1 Jul 2018 12:03:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C0F923C25 for ; Sun, 1 Jul 2018 12:03:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C0F923C25 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbeGAMDA (ORCPT ); Sun, 1 Jul 2018 08:03:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:53460 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751899AbeGAMC6 (ORCPT ); Sun, 1 Jul 2018 08:02:58 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6257CAE57; Sun, 1 Jul 2018 12:02:56 +0000 (UTC) Subject: Re: [RFC net-next 07/15] net: lora: Add Semtech SX1276 To: netdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jian-Hong Pan , Jiri Pirko , Marcel Holtmann , "David S . Miller" , Matthias Brugger , Janus Piwek , =?UTF-8?Q?Michael_R=c3=b6der?= , Dollar Chen , Ken Yu References: <20180701110804.32415-1-afaerber@suse.de> <20180701110804.32415-8-afaerber@suse.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Autocrypt: addr=afaerber@suse.de; prefer-encrypt=mutual; keydata= xsFNBE6W6ZQBEAC/BIukDnkVenIkK9O14UucicBIVvRB5WSMHC23msS+R2h915mW7/vXfn+V 0nrr5ECmEg/5OjujKf0x/uhJYrsxcp45nDyYCk+RYoOJmGzzUFya1GvT/c04coZ8VmgFUWGE vCfhHJro85dZUL99IoLP21VXEVlCPyIngSstikeuf14SY17LPTN1aIpGQDI2Qt8HHY1zOVWv iz53aiFLFeIVhQlBmOABH2Ifr2M9loRC9yOyGcE2GhlzgyHGlQxEVGFn/QptX6iYbtaTBTU0 c72rpmbe1Nec6hWuzSwu2uE8lF+HYcYi+22ml1XBHNMBeAdSEbSfDbwc///8QKtckUzbDvME S8j4KuqQhwvYkSg7dV9rs53WmjO2Wd4eygkC3tBhPM5s38/6CVGl3ABiWJs3kB08asUNy8Wk juusU/nRJbXDzxu1d+hv0d+s5NOBy/5+7Pa6HeyBnh1tUmCs5/f1D/cJnuzzYwAmZTHFUsfQ ygGBRRKpAVu0VxCFNPSYKW0ULi5eZV6bcj+NAhtafGsWcv8WPFXgVE8s2YU38D1VtlBvCo5/ 0MPtQORqAQ/Itag1EHHtnfuK3MBtA0fNxQbb2jha+/oMAi5hKpmB/zAlFoRtYHwjFPFldHfv Iljpe1S0rDASaF9NsQPfUBEm7dA5UUkyvvi00HZ3e7/uyBGb0QARAQABzSJBbmRyZWFzIEbD pHJiZXIgPGFmYWVyYmVyQHN1c2UuZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAUCTqGJnQIZAQAKCRD6LtEtPn4BPzetD/4rF6k/HF+9U9KqykfJaWdUHJvXpI85 Roab12rQbiIrL4hVEYKrYwPEKpCf+FthXpgOq+JdTGJ831DMlTx7Ed5/QJ9KAAQuhZlSNjSc +FNobJm7EbFv9jWFjQC0JcOl17Ji1ikgRcIRDCul1nQh9jCdfh1b848GerZmzteNdT9afRJm 7rrvMqXs1Y52/dTlfIW0ygMA2n5Vv3EwykXJOPF6fRimkErKO84sFMNg0eJV9mXs+Zyionfi g2sZJfVeKjkDqjxy7sDDBZZR68I9HWq5VJQrXqQkCZUvtr6TBLI+uiDLbGRUDNxA3wgjVdS2 v9bhjYceSOHpKU+h3H2S8ju9rjhOADT2F5lUQMTSpjlzglh8IatV5rXLGkXEyum4MzMo2sCE Cr+GD6i2M3pHCtaIVV3xV0nRGALa6DdF7jBWqM54KHaKsE883kFH2+6ARcPCPrnPm7LX98h2 4VpG984ysoq6fpzHHG/KCaYCEOe1bpr3Plmmp3sqj0utA6lwzJy0hj5dqug+lqmg7QKAnxl+ porgluoY56U0X0PIVBc0yO0dWqRxtylJa9kDX/TKwFYNVddMn2NQNjOJXzx2H9hf0We7rG7+ F/vgwALVVYbiTzvp2L0XATTv/oX4BHagAa/Qc3dIsBYJH+KVhBp+ZX4uguxk4xlc2hm75b1s cqeAD87BTQROlumUARAAzd7eu+tw/52FB7xQZWDv5aF+6CAkoz7AuY4s1fo0AQQDqjLOdpQF bifdH7B8SnsA4eo0syfs+1tZW6nn9hdy1GHEMbeuvdhNwkhEfYGDYpSue7oVxB4jajKvRHAP VcewKZIxvIiZ5aSp5n1Bd7B0c0C443DHiWE/0XWSpvbU7fTzTNvdz+2OZmGtqCn610gBqScv 1BOiP3OfLly8ghxcJsos23c0mkB/1iWlzh3UMFIGrzsK3sZJ/3uRaLYFimmqqPlSwFqx3b0M 1gFdHWKfOpvQ4wwP5P10xwvqNXLWC30wB1QmJGD/X8aAoVNnGsmEL7GcWF4cLoOSRidSoccz znShE+Ap+FVDD6MRyesNT4D67l792//B38CGJRdELtNacdwazaFgxH9O85Vnd70ZC7fIcwzG yg/4ZEf96DlAvrSOnu/kgklofEYdzpZmW+Fqas6cnk6ZaHa35uHuBPesdE13MVz5TeiHGQTW xP1jbgWQJGPvJZ+htERT8SZGBQRb1paoRd1KWQ1mlr3CQvXtfA/daq8p/wL48sXrKNwedrLV iZOeJOFwfpJgsFU4xLoO/8N0RNFsnelBgWgZE3ZEctEd4BsWFUw+czYCPYfqOcJ556QUGA9y DeDcxSitpYrNIvpk4C5CHbvskVLKPIUVXxTNl8hAGo1Ahm1VbNkYlocAEQEAAcLBXwQYAQIA CQUCTpbplAIbDAAKCRD6LtEtPn4BPzA6D/9TbSBOPM99SHPX9JiEQAw4ITCBF2oTWeZQ6RJg RKpB15lzyPfyFbNSceJp9dCiwDWe+pzKaX6KYOFZ5+YTS0Ph2eCR+uT2l6Mt6esAun8dvER/ xlPDW7p88dwGUcV8mHEukWdurSEDTj8V3K29vpgvIgRq2lHCn2wqRQBGpiJAt72Vg0HxUlwN GAJNvhpeW8Yb43Ek7lWExkUgOfNsDCTvDInF8JTFtEXMnUcPxC0d/GdAuvBilL9SlmzvoDIZ 5k2k456bkY3+3/ydDvKU5WIgThydyCEQUHlmE6RdA3C1ccIrIvKjVEwSH27Pzy5jKQ78qnhv dtLLAavOXyBJnOGlNDOpOyBXfv02x91RoRiyrSIM7dKmMEINKQlAMgB/UU/6B+mvzosbs5d3 4FPzBLuuRz9WYzXmnC460m2gaEVk1GjpidBWw0yY6kgnAM3KhwCFSecqUQCvwKFDGSXDDbCr w08b3GDk40UoCoUq9xrGfhlf05TUSFTg2NlSrK7+wAEsTUgs2ZYLpHyEeftoDDnKpM4ghs/O ceCeyZUP1zSgRSjgITQp691Uli5Nd1mIzaaM8RjOE/Rw67FwgblKR6HAhSy/LYw1HVOu+Ees RAEdbtRt37A8brlb/ENxbLd9SGC8/j20FQjit7oPNMkTJDs7Uo2eb7WxOt5pSTVVqZkv7Q== Organization: SUSE Linux GmbH Message-ID: Date: Sun, 1 Jul 2018 14:02:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180701110804.32415-8-afaerber@suse.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 01.07.2018 um 13:07 schrieb Andreas Färber: > diff --git a/drivers/net/lora/sx1276.c b/drivers/net/lora/sx1276.c > new file mode 100644 > index 000000000000..d6732111247a > --- /dev/null > +++ b/drivers/net/lora/sx1276.c [...] > +static int sx1276_probe(struct spi_device *spi) > +{ > + struct net_device *netdev; > + struct sx1276_priv *priv; > + int rst, dio[6], ret, model, i; > + u32 freq_xosc, freq_band; > + unsigned long long freq_rf; > + u8 val; > + > + rst = of_get_named_gpio(spi->dev.of_node, "reset-gpio", 0); > + if (rst == -ENOENT) > + dev_warn(&spi->dev, "no reset GPIO available, ignoring"); > + > + for (i = 0; i < 6; i++) { > + dio[i] = of_get_named_gpio(spi->dev.of_node, "dio-gpios", i); > + if (dio[i] == -ENOENT) > + dev_dbg(&spi->dev, "DIO%d not available, ignoring", i); > + else { > + ret = gpio_direction_input(dio[i]); > + if (ret) > + dev_err(&spi->dev, "couldn't set DIO%d to input", i); > + } > + } > + > + if (gpio_is_valid(rst)) { > + gpio_set_value(rst, 1); > + udelay(100); > + gpio_set_value(rst, 0); > + msleep(5); > + } > + > + spi->bits_per_word = 8; > + spi_setup(spi); > + > + ret = sx1276_read_single(spi, REG_VERSION, &val); > + if (ret) { > + dev_err(&spi->dev, "version read failed"); > + return ret; > + } > + > + if (val == 0x22) > + model = 1272; > + else { > + if (gpio_is_valid(rst)) { > + gpio_set_value(rst, 0); > + udelay(100); > + gpio_set_value(rst, 1); > + msleep(5); > + } > + > + ret = sx1276_read_single(spi, REG_VERSION, &val); > + if (ret) { > + dev_err(&spi->dev, "version read failed"); > + return ret; > + } > + > + if (val == 0x12) > + model = 1276; > + else { > + dev_err(&spi->dev, "transceiver not recognized (RegVersion = 0x%02x)", (unsigned)val); > + return -EINVAL; > + } > + } [snip] To counter my own point, this file of course still has leftover model detection heuristics; should check for the of_device_id match instead! SX1272 vs. SX1276 have the reset pin inverted, so - knowing which model it's supposed to be - we can do the right reset from the start and, if it doesn't work, report an error to the user. Also I should update that code to use gpiod, as seen in later patches. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?UTF-8?Q?Andreas_F=c3=a4rber?=) Date: Sun, 1 Jul 2018 14:02:55 +0200 Subject: [RFC net-next 07/15] net: lora: Add Semtech SX1276 In-Reply-To: <20180701110804.32415-8-afaerber@suse.de> References: <20180701110804.32415-1-afaerber@suse.de> <20180701110804.32415-8-afaerber@suse.de> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 01.07.2018 um 13:07 schrieb Andreas F?rber: > diff --git a/drivers/net/lora/sx1276.c b/drivers/net/lora/sx1276.c > new file mode 100644 > index 000000000000..d6732111247a > --- /dev/null > +++ b/drivers/net/lora/sx1276.c [...] > +static int sx1276_probe(struct spi_device *spi) > +{ > + struct net_device *netdev; > + struct sx1276_priv *priv; > + int rst, dio[6], ret, model, i; > + u32 freq_xosc, freq_band; > + unsigned long long freq_rf; > + u8 val; > + > + rst = of_get_named_gpio(spi->dev.of_node, "reset-gpio", 0); > + if (rst == -ENOENT) > + dev_warn(&spi->dev, "no reset GPIO available, ignoring"); > + > + for (i = 0; i < 6; i++) { > + dio[i] = of_get_named_gpio(spi->dev.of_node, "dio-gpios", i); > + if (dio[i] == -ENOENT) > + dev_dbg(&spi->dev, "DIO%d not available, ignoring", i); > + else { > + ret = gpio_direction_input(dio[i]); > + if (ret) > + dev_err(&spi->dev, "couldn't set DIO%d to input", i); > + } > + } > + > + if (gpio_is_valid(rst)) { > + gpio_set_value(rst, 1); > + udelay(100); > + gpio_set_value(rst, 0); > + msleep(5); > + } > + > + spi->bits_per_word = 8; > + spi_setup(spi); > + > + ret = sx1276_read_single(spi, REG_VERSION, &val); > + if (ret) { > + dev_err(&spi->dev, "version read failed"); > + return ret; > + } > + > + if (val == 0x22) > + model = 1272; > + else { > + if (gpio_is_valid(rst)) { > + gpio_set_value(rst, 0); > + udelay(100); > + gpio_set_value(rst, 1); > + msleep(5); > + } > + > + ret = sx1276_read_single(spi, REG_VERSION, &val); > + if (ret) { > + dev_err(&spi->dev, "version read failed"); > + return ret; > + } > + > + if (val == 0x12) > + model = 1276; > + else { > + dev_err(&spi->dev, "transceiver not recognized (RegVersion = 0x%02x)", (unsigned)val); > + return -EINVAL; > + } > + } [snip] To counter my own point, this file of course still has leftover model detection heuristics; should check for the of_device_id match instead! SX1272 vs. SX1276 have the reset pin inverted, so - knowing which model it's supposed to be - we can do the right reset from the start and, if it doesn't work, report an error to the user. Also I should update that code to use gpiod, as seen in later patches. Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Graham Norton HRB 21284 (AG N?rnberg)