From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BD5AC07E95 for ; Fri, 2 Jul 2021 22:02:01 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04166613D8 for ; Fri, 2 Jul 2021 22:01:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04166613D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 01A2F80A22; Sat, 3 Jul 2021 00:01:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="K946qhXJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BF62E80C68; Sat, 3 Jul 2021 00:01:55 +0200 (CEST) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DCA2680796 for ; Sat, 3 Jul 2021 00:01:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wr1-x431.google.com with SMTP id t15so10747772wry.11 for ; Fri, 02 Jul 2021 15:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vDTgW18Sefby2eBbYwTtzqqR0tg9TEfGaetqy27lxP4=; b=K946qhXJW8gmKISnOHbeyzKFPFLNft24iC+VD45gAyFL8yQuzcnU5HV90syCTE7pB3 bLCXOxDlM7jxo1e/S5GSSEQWLmZX08ig0XG7OXHkyFb0R2K/78tgpM6bzAkQSTpt+x+V IpJZ/lvytAcz0Be/PeiYi2IpAl3SZd8kLPLTG5v0r7FO4MFl+u5lcXi8LTCTHH1c+1iZ PzIs/bjgwfY3OruKU3Q+Pk/XqyB5KMmivXux/RGv4BFEKnhj0LvgW2+4TBeH9XRfx7Iw Fv8DlLt6QhIF3QK5LUhioowCbjVezLnMQL0GzF4xEhrVWGRw9VVZtXY0Sz8INr+rCSt+ QQpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vDTgW18Sefby2eBbYwTtzqqR0tg9TEfGaetqy27lxP4=; b=JeLFTYgELdl2SjH3XsHxZJTqhqY+4I6sroHFAl4FdbYk0H6sJTg1wSN1rVg4YfufDa uwP195Q4YiP3QhXIkb+/1n2CrrWAeiasf4TDt8zXWdwRC41pBQ7MFiUGtclZ69HJB4Lz PF8GWMwM4KanW2r6GTDqUVM1pxyJacLzVPhSDPi/VPfceh3wmaeFJp4z09AQbv8Y3azl eKdwAbgklaZ9dGIGk9PdXdnsWxatmk/daNH/hKp/RnMb9g7uaiO1+t3W1gfhGQzywV/g Flhv/h1K45NMzs6PoKk0EwiM7kUmmMPWmZfcY6AE5AZU7DmJdbTon5deUoiXMp1FaluT V36Q== X-Gm-Message-State: AOAM5335y3cBxX2Z4YE7WEBfGHPfJr2sakU+aUND8xqoMQZaC+aKejuy qvfEMH/UU5MhFaRjMkD7/M7vAw== X-Google-Smtp-Source: ABdhPJylFfhNpILuKE3ny7JjZaG8NfvaL9u65nVJSuD2AVmBrSWkZiWJrsSB8Wy1wNn+r4hIRkgkBA== X-Received: by 2002:a5d:530f:: with SMTP id e15mr1868263wrv.217.1625263312203; Fri, 02 Jul 2021 15:01:52 -0700 (PDT) Received: from ?IPv6:2001:861:44c0:66c0:8479:1ac8:3f76:3b5e? ([2001:861:44c0:66c0:8479:1ac8:3f76:3b5e]) by smtp.gmail.com with ESMTPSA id m17sm4713333wrr.6.2021.07.02.15.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jul 2021 15:01:51 -0700 (PDT) Subject: Re: [PATCH] configs: libretech: set SPI mode to 0 To: Da Xue Cc: U-Boot Mailing List , u-boot-amlogic@groups.io, Marek Vasut , Tom Rini References: From: Neil Armstrong Organization: Baylibre Message-ID: Date: Sat, 3 Jul 2021 00:01:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 02/07/2021 23:11, Da Xue wrote: > Kconfig defaults to mode 3 if CONFIG_SF_DEFAULT_MODE is not set. > It becomes an issue since meson_spifc does not support SPI_CPHA. > Needed after commit e2e95e5e25421fbef499e21bf94a5339701f9a99. > > Signed-off-by:Da Xue > --- >  configs/libretech-ac_defconfig       | 1 + >  configs/libretech-cc_v2_defconfig    | 1 + >  configs/libretech-s905d-pc_defconfig | 1 + >  configs/libretech-s912-pc_defconfig  | 1 + >  4 files changed, 4 insertions(+) > > diff --git a/configs/libretech-ac_defconfig b/configs/libretech-ac_defconfig > index ec51f2ad38..9abbcad3c0 100644 > --- a/configs/libretech-ac_defconfig > +++ b/configs/libretech-ac_defconfig > @@ -39,6 +39,7 @@ CONFIG_MMC_MESON_GX=y >  CONFIG_MTD=y >  CONFIG_DM_MTD=y >  CONFIG_DM_SPI_FLASH=y > +CONFIG_SF_DEFAULT_MODE=0x0 >  CONFIG_SPI_FLASH_GIGADEVICE=y >  CONFIG_SPI_FLASH_SPANSION=y >  CONFIG_PHY_MESON_GXL=y > diff --git a/configs/libretech-cc_v2_defconfig b/configs/libretech-cc_v2_defconfig > index 97c8a9e47b..7dc6ed2f29 100644 > --- a/configs/libretech-cc_v2_defconfig > +++ b/configs/libretech-cc_v2_defconfig > @@ -35,6 +35,7 @@ CONFIG_MMC_MESON_GX=y >  CONFIG_MTD=y >  CONFIG_DM_MTD=y >  CONFIG_DM_SPI_FLASH=y > +CONFIG_SF_DEFAULT_MODE=0x0 >  CONFIG_SPI_FLASH_GIGADEVICE=y >  CONFIG_PHY_MESON_GXL=y >  CONFIG_DM_ETH=y > diff --git a/configs/libretech-s905d-pc_defconfig b/configs/libretech-s905d-pc_defconfig > index c0301a0aa0..93523c23cf 100644 > --- a/configs/libretech-s905d-pc_defconfig > +++ b/configs/libretech-s905d-pc_defconfig > @@ -36,6 +36,7 @@ CONFIG_SARADC_MESON=y >  CONFIG_MMC_MESON_GX=y >  CONFIG_MTD=y >  CONFIG_DM_SPI_FLASH=y > +CONFIG_SF_DEFAULT_MODE=0x0 >  CONFIG_SPI_FLASH_GIGADEVICE=y >  CONFIG_PHY_REALTEK=y >  CONFIG_DM_ETH=y > diff --git a/configs/libretech-s912-pc_defconfig b/configs/libretech-s912-pc_defconfig > index e2faea6242..669f000f7f 100644 > --- a/configs/libretech-s912-pc_defconfig > +++ b/configs/libretech-s912-pc_defconfig > @@ -35,6 +35,7 @@ CONFIG_SARADC_MESON=y >  CONFIG_MMC_MESON_GX=y >  CONFIG_MTD=y >  CONFIG_DM_SPI_FLASH=y > +CONFIG_SF_DEFAULT_MODE=0x0 >  CONFIG_SPI_FLASH_GIGADEVICE=y >  CONFIG_PHY_REALTEK=y >  CONFIG_DM_ETH=y > -- > 2.30.2 > > Thanks, Applying to u-boot-amlogic & sending PR to have it in this release Neil