From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED75C433EF for ; Thu, 13 Jan 2022 12:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233593AbiAMMcG (ORCPT ); Thu, 13 Jan 2022 07:32:06 -0500 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:50506 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbiAMMcA (ORCPT ); Thu, 13 Jan 2022 07:32:00 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 8CAA53F1C5 for ; Thu, 13 Jan 2022 12:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642077119; bh=FS/F/TlvVCSdyoU7kWP8bufXKEAoLhbWFtD9KWwk3o4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=wVOU3am2ORQVz8wG6HMZI5BuJjmUdYY4GS9nXFn5TFz52sqTsPtoQtTVedgEceHnG afHP0AFJV0kbzbCjuiBNk6XvEB1/jdZRF8K6yH+PrSbFAM2NXBFjSb1cSn6autTMll 75WUsBjOeEn27zVb4UAZW3FLUmzDT4luui1MsmCLsmqIyD+/uTmDQS0N7bkqtfQyGR SMLutnATCDrzsPNb4qGFBA8W8ro2ZTmhYqLFWDScQ2bf/x2VbuTuAiFJnij9muWkzM Slvl8QQedoJa6qB+TBhGrhrnYV2lb7cHWjJBQhLOfN9OVeKNvHUXMon/TINWmEA92v ZeVH1n6r9vrvg== Received: by mail-wm1-f69.google.com with SMTP id s17-20020a7bc0d1000000b00348737ba2a2so3530773wmh.2 for ; Thu, 13 Jan 2022 04:31:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FS/F/TlvVCSdyoU7kWP8bufXKEAoLhbWFtD9KWwk3o4=; b=5YOiYEzUjbHUviA1W8iFO1aWszDFLSka16mhKe07oJegvw+6BJiNZQyp3tc3uF5hwT p3Pw8tAB8ofy/JnpHWIJc2PNBpFh2A17hJuyY5dH8et8lJ5aIUEZPEjqFaNaiejVamVe /XUI8U9HTJLx0C2DDPDZsJqh7hIjDd3DnS8hiEVTmONbwnPxX/4eUheSZBBAY7eLuJSE pjzj1z8Ic77PfoQ583WS2KGgzQjr/p0+C+WWm6qOWElbt3R3fFQ/9YHZW3SmLqesTs6p f3CuU4vAzo/+J3y994RUTBISENF2waUFpq6Q3q+I7XIpQ76xhLkbQLG/S17t1hiz3koN JOWA== X-Gm-Message-State: AOAM5338BqK60q8xsc/cIVGorKdlX+23uTcmVhhP6oBDkhLtCuny0HTK Hen1i8g3A2YvApDcaEch+M+TqNIYcDK5WH2M9Y3Gtxk1S9sLwu6mDyBZxF2ZEDtEdhSrqMXMJlO Uha0Y+CQdofhb7hpUvIIrojfhL1n5abVk9GyJbO/L+g== X-Received: by 2002:a5d:420e:: with SMTP id n14mr3724224wrq.293.1642077119255; Thu, 13 Jan 2022 04:31:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQfIKQD3y1atrGTO3ll5AyBzkhE238ZBX+7qN6TR3TyZPEQWe0UjPAwheqscqdBIG0C76OOA== X-Received: by 2002:a5d:420e:: with SMTP id n14mr3724211wrq.293.1642077119106; Thu, 13 Jan 2022 04:31:59 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id n7sm2398562wms.46.2022.01.13.04.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 04:31:58 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 13:31:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 00/23] Add support for Tesla Full Self-Driving (FSD) SoC Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com References: <20220113121143.22280-1-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-1-alim.akhtar@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/2022 13:11, Alim Akhtar wrote: > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > as well as several IPs. > > Patches 1 to 8 provide support for the clock controller > (which is designed similarly to Exynos SoCs). > > The remaining changes provide pinmux support, initial device tree support, > and SPI, ADC, and MCT IP functionality. Does FSD have some version number? The FDS, especially in compatibles, looks quite generic, so what will happen if a newer SoC comes later? You would have: - tesla,fsd-pinctrl - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) This will be extra confusing, because fsd-pinctrl looks like the generic one, while it is specific... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62041C433EF for ; Thu, 13 Jan 2022 12:50:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FAtPrrA7oGfoh40SdNNBaDzv4Uj6TKWhmYRcIEQR/EI=; b=a7yi/FEvcUe//j +L315HmMRdzNbSTplSI/u7x80p0pnHpfTLOuGLWLMVtm1XFTh9JZwPcZZjTHLksHaG0z/Gd3CyvDx 0vy0Z0S7AwbtRAw0k7SRozJoPjw1CJUnvqL/toXkJuXvKnMaUqNulQmlvF48yYEVG5ucR7gq8J4LK Oa+m8EKScPbPWMFNRlh4hrsMeidyGG8Tw3T7+KpHfDAeRKElQc5kqgpdb+RvbEzePRTG8v2niZNCf HumvXS4T0XZ5eru7zr+DnGzjJBAHHU7Ibgz1sVNEFXHSP+/XqsUyWVYKxh580Q+d4k0ferl5+dLug i2XtdbG0XKl4M613JCAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7zXK-005umE-HM; Thu, 13 Jan 2022 12:49:05 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n7zGs-005prU-6a for linux-arm-kernel@lists.infradead.org; Thu, 13 Jan 2022 12:32:03 +0000 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id C1DF33F1E1 for ; Thu, 13 Jan 2022 12:31:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1642077119; bh=FS/F/TlvVCSdyoU7kWP8bufXKEAoLhbWFtD9KWwk3o4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=wVOU3am2ORQVz8wG6HMZI5BuJjmUdYY4GS9nXFn5TFz52sqTsPtoQtTVedgEceHnG afHP0AFJV0kbzbCjuiBNk6XvEB1/jdZRF8K6yH+PrSbFAM2NXBFjSb1cSn6autTMll 75WUsBjOeEn27zVb4UAZW3FLUmzDT4luui1MsmCLsmqIyD+/uTmDQS0N7bkqtfQyGR SMLutnATCDrzsPNb4qGFBA8W8ro2ZTmhYqLFWDScQ2bf/x2VbuTuAiFJnij9muWkzM Slvl8QQedoJa6qB+TBhGrhrnYV2lb7cHWjJBQhLOfN9OVeKNvHUXMon/TINWmEA92v ZeVH1n6r9vrvg== Received: by mail-wm1-f69.google.com with SMTP id az9-20020a05600c600900b0034692565ca8so5756969wmb.9 for ; Thu, 13 Jan 2022 04:31:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FS/F/TlvVCSdyoU7kWP8bufXKEAoLhbWFtD9KWwk3o4=; b=3e44CGAHxsOVYNEhVsukO3cgjBeu3N0RGPk+spJlS7s08Y1u2O14vxfueaf0P50Sqr q+GmtM96MmhdBj0ArZ+tl4nS2maDla9dppQTVWrk05O3YUr/NuZ3QHj4gAt8iPQFBHPp 9f3P1BxmUn+7MWKPLCf+AKWUb3F8PpBKp3BwlPtj9tvuZfbh9oiSrZsgK297ijRqzMvv ckkgrnw2e6UYFPyalgLFDvS9lDebBL5vDHDYMpvvyLebLr18GrEvGgFMrfFyZyAgAlSs YpbU4HJzm4S61A7EkjEP1qOpe7o7rRO96YFdm3k/MeI5PkQ/7TFO5rk/wc/LHAnKJdp4 ey9A== X-Gm-Message-State: AOAM531D9su6XxcBX6lg2hGSnZC9csqv1KECVLHbIYY5kKGHI1Qx5poE 0McCUujS2PEk/vCw6smvaYAzVGk39AJleVcK/loS7CFfMUElsgLTTOkzSAgheBXrPSifUDXoh4u bBsuBE+jXBBXsp4eHZs4RzaHQi8WWfQguNQfJhGx8l4gqDJ6SYxdf X-Received: by 2002:a5d:420e:: with SMTP id n14mr3724217wrq.293.1642077119254; Thu, 13 Jan 2022 04:31:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQfIKQD3y1atrGTO3ll5AyBzkhE238ZBX+7qN6TR3TyZPEQWe0UjPAwheqscqdBIG0C76OOA== X-Received: by 2002:a5d:420e:: with SMTP id n14mr3724211wrq.293.1642077119106; Thu, 13 Jan 2022 04:31:59 -0800 (PST) Received: from [192.168.0.29] (xdsl-188-155-168-84.adslplus.ch. [188.155.168.84]) by smtp.gmail.com with ESMTPSA id n7sm2398562wms.46.2022.01.13.04.31.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Jan 2022 04:31:58 -0800 (PST) Message-ID: Date: Thu, 13 Jan 2022 13:31:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH 00/23] Add support for Tesla Full Self-Driving (FSD) SoC Content-Language: en-US To: Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: soc@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, olof@lixom.net, linus.walleij@linaro.org, catalin.marinas@arm.com, robh+dt@kernel.org, s.nawrocki@samsung.com, linux-samsung-soc@vger.kernel.org, pankaj.dubey@samsung.com References: <20220113121143.22280-1-alim.akhtar@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20220113121143.22280-1-alim.akhtar@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_043202_441378_997376D0 X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/01/2022 13:11, Alim Akhtar wrote: > This patch set adds basic support for the Tesla Full Self-Driving (FSD) > SoC. This SoC contains three clusters of four Cortex-A72 CPUs, > as well as several IPs. > > Patches 1 to 8 provide support for the clock controller > (which is designed similarly to Exynos SoCs). > > The remaining changes provide pinmux support, initial device tree support, > and SPI, ADC, and MCT IP functionality. Does FSD have some version number? The FDS, especially in compatibles, looks quite generic, so what will happen if a newer SoC comes later? You would have: - tesla,fsd-pinctrl - tesla,fsd-xxxx-pinctrl (where xxxx could be some new version) This will be extra confusing, because fsd-pinctrl looks like the generic one, while it is specific... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel