From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ACC4C433E1 for ; Thu, 2 Jul 2020 17:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2838D20870 for ; Thu, 2 Jul 2020 17:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593712746; bh=LiNf/oCR5xMtevLJEVXBqNNKcCAHHJBxiwRz04agoFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=twTR7fU2l4WhC7fkxgQ4aB4IcS/d6+tK5jgjEB96+ZqZ0QAhP0gfgEBFlO9sFmXK7 Jeaw2rG4SqRmXUAhcCuAzo4kjRV4H+U4z+IVl6P5tNFFuvLhgNQ8BB4da3Q4BU//BD oNrU6Zq+g3vzaWpX53QRaJLGyEzaEEIgdyQbMW/0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727914AbgGBR7E (ORCPT ); Thu, 2 Jul 2020 13:59:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:51986 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbgGBR7E (ORCPT ); Thu, 2 Jul 2020 13:59:04 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52A9720737; Thu, 2 Jul 2020 17:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593712743; bh=LiNf/oCR5xMtevLJEVXBqNNKcCAHHJBxiwRz04agoFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jMpwBH2mioxgNjTAwQkjJpfcUhIWXt5XWb5sP5oVkYJrQGOWeo/mDsBSAdUW8bYVt SHUK1h9zjeZY8/04WvNLGrfO1ARjnvt/hkXzAZBd7rTxWVFX4sds6Va2oJRR3Qinsy y1Z1l9rvas+7lJv5H4aNTynD1JdD9fMiINsNcW8Y= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jr3UD-008VH4-L0; Thu, 02 Jul 2020 18:59:01 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 02 Jul 2020 18:59:01 +0100 From: Marc Zyngier To: Grzegorz Jaszczyk Cc: tglx@linutronix.de, jason@lakedaemon.net, s-anna@ti.com, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com Subject: Re: [PATCHv3 5/6] irqchip/irq-pruss-intc: Add support for ICSSG INTC on K3 SoCs In-Reply-To: <1593699479-1445-6-git-send-email-grzegorz.jaszczyk@linaro.org> References: <1593699479-1445-1-git-send-email-grzegorz.jaszczyk@linaro.org> <1593699479-1445-6-git-send-email-grzegorz.jaszczyk@linaro.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: grzegorz.jaszczyk@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, s-anna@ti.com, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-02 15:17, Grzegorz Jaszczyk wrote: > From: Suman Anna > > The K3 AM65x and J721E SoCs have the next generation of the PRU-ICSS > IP, > commonly called ICSSG. The PRUSS INTC present within the ICSSG supports > more System Events (160 vs 64), more Interrupt Channels and Host > Interrupts > (20 vs 10) compared to the previous generation PRUSS INTC instances. > The > first 2 and the last 10 of these host interrupt lines are used by the > PRU and other auxiliary cores and sub-modules within the ICSSG, with 8 > host interrupts connected to MPU. The host interrupts 5, 6, 7 are also > connected to the other ICSSG instances within the SoC and can be > partitioned as per system integration through the board dts files. > > Enhance the PRUSS INTC driver to add support for this ICSSG INTC > instance. This support is added using specific compatible and match > data and updating the code to use this data instead of the current > hard-coded macros. The INTC config structure is updated to use the > higher events and channels on all SoCs, while limiting the actual > processing to only the relevant number of events/channels/interrupts. > > Signed-off-by: Suman Anna > Signed-off-by: Grzegorz Jaszczyk > --- > v2->v3: > - Change patch order: use it directly after "irqchip/irq-pruss-intc: > Implement irq_{get,set}_irqchip_state ops" and before new > "irqchip/irq-pruss-intc: Add event mapping support" in order to > reduce > diff. The diff would be even smaller if you introduced a variable number of inputs the first place, i.e. in patch #2. Most if this patch just retrofits it. Please squash these changes into that initial patch, and only add the platform stuff here. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D5BBC433E0 for ; Thu, 2 Jul 2020 18:00:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E6042073E for ; Thu, 2 Jul 2020 18:00:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ajl3mNBX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="jMpwBH2m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E6042073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ix8wL9Af44O4eiJhA7zzRSrCdGoOpE1zxU2SCqOkAGQ=; b=ajl3mNBXid/GdLSXL4if4ilyv uwU8g6MmfG8fYEhatKPisHg0XN7u/ttV/rnPjB9wZkDF1MgGDuVyQ/eLtNCbMta8xdjMLg4wDEDUi LvgL+C37QQ/nht7l29m1WBUdHuh/jA+JUr6qiR5MUDoVwVVdAhVjzyYctvBe3ui1yQUptMtM+QZZH Jj1nAHWuvr0q4a31i4RZDBsMo1Jy5xKKv6y77s2F5mznV69RFXZFqyrmWPJ4y45RUDC5CqeRGiHMD EwawRDMFg/n5rmFykL36bIk3JooxMcY6ZCkWkN4CXVBVs7lj9yBdC1APkksQceO7occLkoWx0TFDW j+FdzmSuw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr3UJ-0006RQ-7E; Thu, 02 Jul 2020 17:59:07 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr3UG-0006QS-Az for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 17:59:05 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 52A9720737; Thu, 2 Jul 2020 17:59:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593712743; bh=LiNf/oCR5xMtevLJEVXBqNNKcCAHHJBxiwRz04agoFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jMpwBH2mioxgNjTAwQkjJpfcUhIWXt5XWb5sP5oVkYJrQGOWeo/mDsBSAdUW8bYVt SHUK1h9zjeZY8/04WvNLGrfO1ARjnvt/hkXzAZBd7rTxWVFX4sds6Va2oJRR3Qinsy y1Z1l9rvas+7lJv5H4aNTynD1JdD9fMiINsNcW8Y= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jr3UD-008VH4-L0; Thu, 02 Jul 2020 18:59:01 +0100 MIME-Version: 1.0 Date: Thu, 02 Jul 2020 18:59:01 +0100 From: Marc Zyngier To: Grzegorz Jaszczyk Subject: Re: [PATCHv3 5/6] irqchip/irq-pruss-intc: Add support for ICSSG INTC on K3 SoCs In-Reply-To: <1593699479-1445-6-git-send-email-grzegorz.jaszczyk@linaro.org> References: <1593699479-1445-1-git-send-email-grzegorz.jaszczyk@linaro.org> <1593699479-1445-6-git-send-email-grzegorz.jaszczyk@linaro.org> User-Agent: Roundcube Webmail/1.4.5 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: grzegorz.jaszczyk@linaro.org, tglx@linutronix.de, jason@lakedaemon.net, s-anna@ti.com, robh+dt@kernel.org, lee.jones@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, david@lechnology.com, wmills@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_135904_503987_2F524C21 X-CRM114-Status: GOOD ( 16.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, jason@lakedaemon.net, linux-kernel@vger.kernel.org, robh+dt@kernel.org, tglx@linutronix.de, lee.jones@linaro.org, wmills@ti.com, linux-arm-kernel@lists.infradead.org, david@lechnology.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-07-02 15:17, Grzegorz Jaszczyk wrote: > From: Suman Anna > > The K3 AM65x and J721E SoCs have the next generation of the PRU-ICSS > IP, > commonly called ICSSG. The PRUSS INTC present within the ICSSG supports > more System Events (160 vs 64), more Interrupt Channels and Host > Interrupts > (20 vs 10) compared to the previous generation PRUSS INTC instances. > The > first 2 and the last 10 of these host interrupt lines are used by the > PRU and other auxiliary cores and sub-modules within the ICSSG, with 8 > host interrupts connected to MPU. The host interrupts 5, 6, 7 are also > connected to the other ICSSG instances within the SoC and can be > partitioned as per system integration through the board dts files. > > Enhance the PRUSS INTC driver to add support for this ICSSG INTC > instance. This support is added using specific compatible and match > data and updating the code to use this data instead of the current > hard-coded macros. The INTC config structure is updated to use the > higher events and channels on all SoCs, while limiting the actual > processing to only the relevant number of events/channels/interrupts. > > Signed-off-by: Suman Anna > Signed-off-by: Grzegorz Jaszczyk > --- > v2->v3: > - Change patch order: use it directly after "irqchip/irq-pruss-intc: > Implement irq_{get,set}_irqchip_state ops" and before new > "irqchip/irq-pruss-intc: Add event mapping support" in order to > reduce > diff. The diff would be even smaller if you introduced a variable number of inputs the first place, i.e. in patch #2. Most if this patch just retrofits it. Please squash these changes into that initial patch, and only add the platform stuff here. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel