From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22610C12002 for ; Mon, 19 Jul 2021 04:22:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E18E2610C7 for ; Mon, 19 Jul 2021 04:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229878AbhGSEZq (ORCPT ); Mon, 19 Jul 2021 00:25:46 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:27312 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229512AbhGSEZp (ORCPT ); Mon, 19 Jul 2021 00:25:45 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R771e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=xianting.tian@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UgB0hYy_1626668564; Received: from B-LB6YLVDL-0141.local(mailfrom:xianting.tian@linux.alibaba.com fp:SMTPD_---0UgB0hYy_1626668564) by smtp.aliyun-inc.com(127.0.0.1); Mon, 19 Jul 2021 12:22:45 +0800 Subject: Re: [PATCH] virtio-balloon: Use virtio_find_vqs() helper To: Jason Wang , Xianting Tian , mst@redhat.com, david@redhat.com Cc: virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <1626190724-7942-1-git-send-email-xianting_tian@126.com> From: tianxianting Message-ID: Date: Mon, 19 Jul 2021 12:22:44 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org thanks, I checked, actually all virtio drivers have switched to use the helper after this one merged. 在 2021/7/19 上午11:46, Jason Wang 写道: > > 在 2021/7/16 下午8:46, tianxianting 写道: >> Do you interest in this patch? just little improvment:) >> >> 在 2021/7/13 下午11:38, Xianting Tian 写道: >>> From: Xianting Tian >>> >>> Use the helper virtio_find_vqs(). >>> >>> Signed-off-by: Xianting Tian >>> --- >>>   drivers/virtio/virtio_balloon.c | 4 ++-- >>>   1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/virtio/virtio_balloon.c >>> b/drivers/virtio/virtio_balloon.c >>> index 510e931..18e0bf3 100644 >>> --- a/drivers/virtio/virtio_balloon.c >>> +++ b/drivers/virtio/virtio_balloon.c >>> @@ -531,8 +531,8 @@ static int init_vqs(struct virtio_balloon *vb) >>>           callbacks[VIRTIO_BALLOON_VQ_REPORTING] = balloon_ack; >>>       } >>>   -    err = vb->vdev->config->find_vqs(vb->vdev, >>> VIRTIO_BALLOON_VQ_MAX, >>> -                     vqs, callbacks, names, NULL, NULL); >>> +    err = virtio_find_vqs(vb->vdev, VIRTIO_BALLOON_VQ_MAX, vqs, >>> +                callbacks, names, NULL); >>>       if (err) >>>           return err; >> > > Acked-by: Jason Wang > > Maybe it's better to convert all the drivers that doesn't use > virtio_find_vqs{_ctx}. > > Thanks