* [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock
@ 2014-06-11 11:05 Phil Edworthy
2014-06-12 15:35 ` Laurent Pinchart
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Phil Edworthy @ 2014-06-11 11:05 UTC (permalink / raw)
To: linux-sh
This patch adds a default PCIe bus clock node.
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
v2:
- Use a default PCIe bus clock in the device's dtsi
arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 7eb882c..13b4e63 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -487,6 +487,14 @@
clock-output-names = "extal";
};
+ /* External PCIe clock - can be overridden by the board */
+ pcie_bus_clk: pcie_bus_clk {
+ compatible = "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <100000000>;
+ clock-output-names = "pcie_bus";
+ };
+
/*
* The external audio clocks are configured as 0 Hz fixed frequency clocks by
* default. Boards that provide audio clocks should override them.
--
2.0.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock
2014-06-11 11:05 [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock Phil Edworthy
@ 2014-06-12 15:35 ` Laurent Pinchart
2014-06-12 16:23 ` Phil Edworthy
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2014-06-12 15:35 UTC (permalink / raw)
To: linux-sh
Hi Phil,
Thank you for the patch.
On Wednesday 11 June 2014 12:05:48 Phil Edworthy wrote:
> This patch adds a default PCIe bus clock node.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> ---
> v2:
> - Use a default PCIe bus clock in the device's dtsi
>
> arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> index 7eb882c..13b4e63 100644
> --- a/arch/arm/boot/dts/r8a7790.dtsi
> +++ b/arch/arm/boot/dts/r8a7790.dtsi
> @@ -487,6 +487,14 @@
> clock-output-names = "extal";
> };
>
> + /* External PCIe clock - can be overridden by the board */
> + pcie_bus_clk: pcie_bus_clk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <100000000>;
> + clock-output-names = "pcie_bus";
As the clock isn't present on all r8a7790 boards, how about making it disabled
(status = "disabled") by default ?
> + };
> +
> /*
> * The external audio clocks are configured as 0 Hz fixed frequency
> clocks by * default. Boards that provide audio clocks should override them.
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock
2014-06-11 11:05 [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock Phil Edworthy
2014-06-12 15:35 ` Laurent Pinchart
@ 2014-06-12 16:23 ` Phil Edworthy
2014-06-13 7:45 ` Simon Horman
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Phil Edworthy @ 2014-06-12 16:23 UTC (permalink / raw)
To: linux-sh
Hi Laurent,
On 12 June 2014 16:35, Laurent wrote:
> On Wednesday 11 June 2014 12:05:48 Phil Edworthy wrote:
> > This patch adds a default PCIe bus clock node.
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > ---
> > v2:
> > - Use a default PCIe bus clock in the device's dtsi
> >
> > arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi
> b/arch/arm/boot/dts/r8a7790.dtsi
> > index 7eb882c..13b4e63 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > @@ -487,6 +487,14 @@
> > clock-output-names = "extal";
> > };
> >
> > + /* External PCIe clock - can be overridden by the board */
> > + pcie_bus_clk: pcie_bus_clk {
> > + compatible = "fixed-clock";
> > + #clock-cells = <0>;
> > + clock-frequency = <100000000>;
> > + clock-output-names = "pcie_bus";
>
> As the clock isn't present on all r8a7790 boards, how about making it disabled
> (status = "disabled") by default ?
Ah, right. I hadn't considered that the clock could also be disabled. Ok...
> > + };
> > +
> > /*
> > * The external audio clocks are configured as 0 Hz fixed
> frequency
> > clocks by * default. Boards that provide audio clocks should override them.
Thanks
Phil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock
2014-06-11 11:05 [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock Phil Edworthy
2014-06-12 15:35 ` Laurent Pinchart
2014-06-12 16:23 ` Phil Edworthy
@ 2014-06-13 7:45 ` Simon Horman
2014-06-13 7:48 ` Phil Edworthy
2014-06-13 7:52 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-06-13 7:45 UTC (permalink / raw)
To: linux-sh
On Thu, Jun 12, 2014 at 04:23:59PM +0000, Phil Edworthy wrote:
> Hi Laurent,
>
> On 12 June 2014 16:35, Laurent wrote:
> > On Wednesday 11 June 2014 12:05:48 Phil Edworthy wrote:
> > > This patch adds a default PCIe bus clock node.
> > >
> > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > > ---
> > > v2:
> > > - Use a default PCIe bus clock in the device's dtsi
> > >
> > > arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
> > > 1 file changed, 8 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi
> > b/arch/arm/boot/dts/r8a7790.dtsi
> > > index 7eb882c..13b4e63 100644
> > > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > > @@ -487,6 +487,14 @@
> > > clock-output-names = "extal";
> > > };
> > >
> > > + /* External PCIe clock - can be overridden by the board */
> > > + pcie_bus_clk: pcie_bus_clk {
> > > + compatible = "fixed-clock";
> > > + #clock-cells = <0>;
> > > + clock-frequency = <100000000>;
> > > + clock-output-names = "pcie_bus";
> >
> > As the clock isn't present on all r8a7790 boards, how about making it disabled
> > (status = "disabled") by default ?
>
> Ah, right. I hadn't considered that the clock could also be disabled. Ok...
Hi Phil,
Am I right in thinking that this change is the only
issue outstanding for the entire series?
If so, could you repost the entire series with that change?
>
> > > + };
> > > +
> > > /*
> > > * The external audio clocks are configured as 0 Hz fixed
> > frequency
> > > clocks by * default. Boards that provide audio clocks should override them.
>
> Thanks
> Phil
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock
2014-06-11 11:05 [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock Phil Edworthy
` (2 preceding siblings ...)
2014-06-13 7:45 ` Simon Horman
@ 2014-06-13 7:48 ` Phil Edworthy
2014-06-13 7:52 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Phil Edworthy @ 2014-06-13 7:48 UTC (permalink / raw)
To: linux-sh
Hi Simon,
On 13 June 2014 08:45, Simon wrote:
> On Thu, Jun 12, 2014 at 04:23:59PM +0000, Phil Edworthy wrote:
> > Hi Laurent,
> >
> > On 12 June 2014 16:35, Laurent wrote:
> > > On Wednesday 11 June 2014 12:05:48 Phil Edworthy wrote:
> > > > This patch adds a default PCIe bus clock node.
> > > >
> > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > > > ---
> > > > v2:
> > > > - Use a default PCIe bus clock in the device's dtsi
> > > >
> > > > arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
> > > > 1 file changed, 8 insertions(+)
> > > >
> > > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi
> > > b/arch/arm/boot/dts/r8a7790.dtsi
> > > > index 7eb882c..13b4e63 100644
> > > > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > > > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > > > @@ -487,6 +487,14 @@
> > > > clock-output-names = "extal";
> > > > };
> > > >
> > > > + /* External PCIe clock - can be overridden by the board */
> > > > + pcie_bus_clk: pcie_bus_clk {
> > > > + compatible = "fixed-clock";
> > > > + #clock-cells = <0>;
> > > > + clock-frequency = <100000000>;
> > > > + clock-output-names = "pcie_bus";
> > >
> > > As the clock isn't present on all r8a7790 boards, how about making it
> disabled
> > > (status = "disabled") by default ?
> >
> > Ah, right. I hadn't considered that the clock could also be disabled. Ok...
>
> Hi Phil,
>
> Am I right in thinking that this change is the only
> issue outstanding for the entire series?
>
> If so, could you repost the entire series with that change?
Sure, I was planning on doing that this morning, after I've finished some other work!
Cheers
Phil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock
2014-06-11 11:05 [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock Phil Edworthy
` (3 preceding siblings ...)
2014-06-13 7:48 ` Phil Edworthy
@ 2014-06-13 7:52 ` Simon Horman
4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2014-06-13 7:52 UTC (permalink / raw)
To: linux-sh
On Fri, Jun 13, 2014 at 07:48:58AM +0000, Phil Edworthy wrote:
> Hi Simon,
>
> On 13 June 2014 08:45, Simon wrote:
> > On Thu, Jun 12, 2014 at 04:23:59PM +0000, Phil Edworthy wrote:
> > > Hi Laurent,
> > >
> > > On 12 June 2014 16:35, Laurent wrote:
> > > > On Wednesday 11 June 2014 12:05:48 Phil Edworthy wrote:
> > > > > This patch adds a default PCIe bus clock node.
> > > > >
> > > > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> > > > > ---
> > > > > v2:
> > > > > - Use a default PCIe bus clock in the device's dtsi
> > > > >
> > > > > arch/arm/boot/dts/r8a7790.dtsi | 8 ++++++++
> > > > > 1 file changed, 8 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm/boot/dts/r8a7790.dtsi
> > > > b/arch/arm/boot/dts/r8a7790.dtsi
> > > > > index 7eb882c..13b4e63 100644
> > > > > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > > > > +++ b/arch/arm/boot/dts/r8a7790.dtsi
> > > > > @@ -487,6 +487,14 @@
> > > > > clock-output-names = "extal";
> > > > > };
> > > > >
> > > > > + /* External PCIe clock - can be overridden by the board */
> > > > > + pcie_bus_clk: pcie_bus_clk {
> > > > > + compatible = "fixed-clock";
> > > > > + #clock-cells = <0>;
> > > > > + clock-frequency = <100000000>;
> > > > > + clock-output-names = "pcie_bus";
> > > >
> > > > As the clock isn't present on all r8a7790 boards, how about making it
> > disabled
> > > > (status = "disabled") by default ?
> > >
> > > Ah, right. I hadn't considered that the clock could also be disabled. Ok...
> >
> > Hi Phil,
> >
> > Am I right in thinking that this change is the only
> > issue outstanding for the entire series?
> >
> > If so, could you repost the entire series with that change?
>
> Sure, I was planning on doing that this morning, after I've finished some other work!
Great, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-06-13 7:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-11 11:05 [PATCH v2 2/7] ARM: shmobile: r8a7790: Add default PCIe bus clock Phil Edworthy
2014-06-12 15:35 ` Laurent Pinchart
2014-06-12 16:23 ` Phil Edworthy
2014-06-13 7:45 ` Simon Horman
2014-06-13 7:48 ` Phil Edworthy
2014-06-13 7:52 ` Simon Horman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.