All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Fraser <nfraser@codeweavers.com>
To: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	Ian Rogers <irogers@google.com>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Song Liu <songliubraving@fb.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Kim Phillips <kim.phillips@amd.com>,
	Tommi Rantala <tommi.t.rantala@nokia.com>,
	Remi Bernon <rbernon@codeweavers.com>,
	linux-kernel@vger.kernel.org
Cc: Ulrich Czekalla <uczekalla@codeweavers.com>,
	Huw Davies <huw@codeweavers.com>
Subject: [PATCH 0/4] perf: Fix archive/debugcache PE files
Date: Wed, 10 Feb 2021 14:17:12 -0500	[thread overview]
Message-ID: <d1c87379-8837-a5e7-eb44-f063ca0f4766@codeweavers.com> (raw)

Hello perf maintainers,

I have some patches to get "perf archive" working with PE binaries (e.g.
Wine DLLs or Windows executables.) The PE support in perf is fairly new and
"perf archive" hasn't been updated to work with it. In getting this working
I've come across a number of bugs in perf that these patches aim to fix.
The patches are independent and can be committed in any order.

Some of these are because build-ids are now variable width. Build-ids in PE
files are always 16-byte GUIDs; much of the existing code still assumes a
20-byte SHA-1 build-id. I've tried to make the minimal amount of changes to
allow 16-byte build-ids to work with a debugcache from a perf archive.

I'm new to kernel development so I apologize if I'm doing this incorrectly.

Thanks,

Nick

Nicholas Fraser (4):
  perf buildid-cache: Don't skip 16-byte build-ids
  perf report: Load PE files from debug cache only
  perf archive: Fix filtering of empty build-ids
  perf report: Fix return value when loading PE DSO

 tools/perf/perf-archive.sh |  3 +--
 tools/perf/util/build-id.c |  5 +++--
 tools/perf/util/build-id.h |  4 +++-
 tools/perf/util/symbol.c   | 12 ++++--------
 4 files changed, 11 insertions(+), 13 deletions(-)

-- 
2.30.0


             reply	other threads:[~2021-02-10 19:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 19:17 Nicholas Fraser [this message]
2021-02-16 20:37 ` [PATCH 1/2] perf report: Remove redundant libbfd checks Nicholas Fraser
2021-02-16 21:05   ` Nicholas Fraser
2021-02-16 21:06     ` [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id Nicholas Fraser
2021-02-17 19:53       ` Jiri Olsa
2021-02-18 19:39   ` [PATCH 1/2] perf report: Remove redundant libbfd checks Arnaldo Carvalho de Melo
2021-02-18 19:42     ` Nicholas Fraser
2021-02-18 19:45       ` Arnaldo Carvalho de Melo
2021-02-16 20:38 ` [PATCH 2/2] perf buildid-cache: Add test for 16-byte build-id Nicholas Fraser
2021-02-16 21:04   ` Nicholas Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1c87379-8837-a5e7-eb44-f063ca0f4766@codeweavers.com \
    --to=nfraser@codeweavers.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=fche@redhat.com \
    --cc=huw@codeweavers.com \
    --cc=irogers@google.com \
    --cc=jolsa@redhat.com \
    --cc=kim.phillips@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rbernon@codeweavers.com \
    --cc=songliubraving@fb.com \
    --cc=tommi.t.rantala@nokia.com \
    --cc=uczekalla@codeweavers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.