From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFwPb-0002qE-0q for qemu-devel@nongnu.org; Thu, 23 Jun 2016 00:38:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFwPX-0004d1-Sx for qemu-devel@nongnu.org; Thu, 23 Jun 2016 00:38:42 -0400 Received: from mail-wm0-x232.google.com ([2a00:1450:400c:c09::232]:34554) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFwPX-0004cn-MM for qemu-devel@nongnu.org; Thu, 23 Jun 2016 00:38:39 -0400 Received: by mail-wm0-x232.google.com with SMTP id 187so1267033wmz.1 for ; Wed, 22 Jun 2016 21:38:39 -0700 (PDT) Sender: Paolo Bonzini References: <20160623000809.4522-1-marcandre.lureau@redhat.com> <20160623000809.4522-6-marcandre.lureau@redhat.com> From: Paolo Bonzini Message-ID: Date: Thu, 23 Jun 2016 06:38:35 +0200 MIME-Version: 1.0 In-Reply-To: <20160623000809.4522-6-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org Cc: armbru@redhat.com On 23/06/2016 02:08, marcandre.lureau@redhat.com wrote: > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > from generated qapi commands registry. > > Note: this commit requires a 'make clean' prior to make, since the > generated files do not depend on Makefile (due to a cyclic rule > introduced in 4115852bb0). > > Signed-off-by: Marc-André Lureau What is the cyclic dependency? Paolo