From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33E81C6FD1C for ; Thu, 23 Mar 2023 13:49:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231764AbjCWNtp (ORCPT ); Thu, 23 Mar 2023 09:49:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbjCWNto (ORCPT ); Thu, 23 Mar 2023 09:49:44 -0400 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E29931BF3; Thu, 23 Mar 2023 06:49:42 -0700 (PDT) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32N9c7VF012773; Thu, 23 Mar 2023 13:49:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=tiJIvhSMcmuYRxWaz3r/96shZ0YPRflIp+RPKVv0cgk=; b=SQsaqvpXZISeuUhweleScm5ohD3Ux+e2rJ9K9+/yhNuovgi8aDdH3zEj7VSuAJ+ii9xa Sz2myH+25VkxrITPyXj+9IjXMDh/ioLEuXL/lKFmyKW9A7YqQ3JY2PtVkRL4lWzYsyJq dauv2yNrimyvD3UVuQVRU02mL7GUgx9haGgIfleyerv1D30mASX+B/rciUZaBXH3HgZa d49kmGeMziTjhm2PyOqVuL2CUoS6VrOB0FWkR0VUQf39qfGlre88kuprC3rPLS+KlWCj LGnosdY66fXHy/waxbx2URceYOvIRoMa7fs11IZTvzQfcitMk5hQ4ll+FvuIrgjcUfkX yw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pgm9x8jsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 13:49:36 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32NDnZAJ013552 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 13:49:35 GMT Received: from [10.50.6.215] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Mar 2023 06:49:31 -0700 Message-ID: Date: Thu, 23 Mar 2023 19:19:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , "Krzysztof Kozlowski" , Bjorn Andersson , Rob Herring CC: , , , , Sibi Sankar , Rajendra Nayak References: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com> <859ec5d4-4cb6-1d8a-33b6-91df071e07a1@linaro.org> From: Souradeep Chowdhury In-Reply-To: <859ec5d4-4cb6-1d8a-33b6-91df071e07a1@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 6moZO2YWwhlDV0CpwPloEUSrwI998dKx X-Proofpoint-ORIG-GUID: 6moZO2YWwhlDV0CpwPloEUSrwI998dKx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_21,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxlogscore=984 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303230105 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 3/22/2023 9:59 PM, Krzysztof Kozlowski wrote: > On 22/03/2023 14:46, Souradeep Chowdhury wrote: >>>> + - const: qcom,mpm2-sleep-counter >>> >>> SoC specific compatible. >>> >> >> This is a generic Module Power Manager Sleep Counter which is present in >> all Qcom Socs, so SoC specific compatible is not given here. > > Not really a good reason and it is actually very difficult to verify > this. If I understand correctly any moment FW can change and this will > stop being valid, so no. Ack > >> >>>> + >>>> + reg: >>>> + items: >>>> + - description: MPM Sleep Counter Base >>> >>> just maxItems: 1 >>> >> >> Ack >>>> + >>>> + clock-frequency: >>>> + description: Frequency for the sleep counter >>> >>> Since this does not have clocks, what frequency you are setting here? >> >> Module Power Manager(MPM) Sleep Counter is a clock that starts ticking >> from Primary Boot Loader(PBL) Stage. This is usually a 32 Khz clock and >> the frequency for the same is stored here. > > You just said all devices have the same MPM, so I would argue that all > devices have the same clock. > > Anyway, this is a legacy property. Ack. Will drop clock frequency. > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 300CAC6FD1C for ; Thu, 23 Mar 2023 13:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1Mukewdmj4vemLdoovAPaYRT/uHb5Y7VNrFnK20JodA=; b=A6QrvuW1YQn+w8 ug+8U6DVYnCqIn1Y1JaxCzKkReonRRUT2p7wTUXZiiwuUw+VYST3F71HMca+1cj1zNm11/n92+Uzj ZZc9pAOwgNnUK8UaU995J2LolbiyT+vY7+lnxRYIHCeFmvVDN6MVGrn1jnppXZb5n5GAGBVrQcSUS w+f4HOfYDXUR/6hb10DC+fl+98tiVSGH8cDGRHxBoYpzIkoOkjGo/OAFwlv3zUebUaTC23vU87bx9 suhesL4HEyf6OzjoEvqyLRhF8Rzf3xuBzhkARvE9TkIb0cb4ffpsOjxiV/Omkz7f7OFHCxGzIY+qM lThu+O998NkLMWtz7p6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pfLK2-00252z-0N; Thu, 23 Mar 2023 13:49:42 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pfLJz-00252H-0H for linux-arm-kernel@lists.infradead.org; Thu, 23 Mar 2023 13:49:40 +0000 Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 32N9c7VF012773; Thu, 23 Mar 2023 13:49:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=tiJIvhSMcmuYRxWaz3r/96shZ0YPRflIp+RPKVv0cgk=; b=SQsaqvpXZISeuUhweleScm5ohD3Ux+e2rJ9K9+/yhNuovgi8aDdH3zEj7VSuAJ+ii9xa Sz2myH+25VkxrITPyXj+9IjXMDh/ioLEuXL/lKFmyKW9A7YqQ3JY2PtVkRL4lWzYsyJq dauv2yNrimyvD3UVuQVRU02mL7GUgx9haGgIfleyerv1D30mASX+B/rciUZaBXH3HgZa d49kmGeMziTjhm2PyOqVuL2CUoS6VrOB0FWkR0VUQf39qfGlre88kuprC3rPLS+KlWCj LGnosdY66fXHy/waxbx2URceYOvIRoMa7fs11IZTvzQfcitMk5hQ4ll+FvuIrgjcUfkX yw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3pgm9x8jsf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 13:49:36 +0000 Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 32NDnZAJ013552 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 13:49:35 GMT Received: from [10.50.6.215] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 23 Mar 2023 06:49:31 -0700 Message-ID: Date: Thu, 23 Mar 2023 19:19:27 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V1 2/4] dt-bindings: soc: qcom,mpm-sleep-counter: Add the dtschema Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Konrad Dybcio , "Krzysztof Kozlowski" , Bjorn Andersson , Rob Herring CC: , , , , Sibi Sankar , Rajendra Nayak References: <576e53a1d0ef218536da976102b4cc207436ec1d.1679403696.git.quic_schowdhu@quicinc.com> <859ec5d4-4cb6-1d8a-33b6-91df071e07a1@linaro.org> From: Souradeep Chowdhury In-Reply-To: <859ec5d4-4cb6-1d8a-33b6-91df071e07a1@linaro.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: 6moZO2YWwhlDV0CpwPloEUSrwI998dKx X-Proofpoint-ORIG-GUID: 6moZO2YWwhlDV0CpwPloEUSrwI998dKx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-22_21,2023-03-22_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 mlxlogscore=984 adultscore=0 spamscore=0 impostorscore=0 priorityscore=1501 clxscore=1015 mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303150002 definitions=main-2303230105 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230323_064939_130610_DD8C50A6 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/22/2023 9:59 PM, Krzysztof Kozlowski wrote: > On 22/03/2023 14:46, Souradeep Chowdhury wrote: >>>> + - const: qcom,mpm2-sleep-counter >>> >>> SoC specific compatible. >>> >> >> This is a generic Module Power Manager Sleep Counter which is present in >> all Qcom Socs, so SoC specific compatible is not given here. > > Not really a good reason and it is actually very difficult to verify > this. If I understand correctly any moment FW can change and this will > stop being valid, so no. Ack > >> >>>> + >>>> + reg: >>>> + items: >>>> + - description: MPM Sleep Counter Base >>> >>> just maxItems: 1 >>> >> >> Ack >>>> + >>>> + clock-frequency: >>>> + description: Frequency for the sleep counter >>> >>> Since this does not have clocks, what frequency you are setting here? >> >> Module Power Manager(MPM) Sleep Counter is a clock that starts ticking >> from Primary Boot Loader(PBL) Stage. This is usually a 32 Khz clock and >> the frequency for the same is stored here. > > You just said all devices have the same MPM, so I would argue that all > devices have the same clock. > > Anyway, this is a legacy property. Ack. Will drop clock frequency. > > Best regards, > Krzysztof > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel