From: Jerome Brunet <jbrunet@baylibre.com>
To: "André Balsa" <andrebalsa@gmail.com>, linux-amlogic@lists.infradead.org
Subject: Re: Possible regression in driver meson-gx-mmc in kernel 5.0.0
Date: Mon, 04 Mar 2019 16:34:01 +0100 [thread overview]
Message-ID: <d1e057447b1c9ca832db3161242e35963bb15ba0.camel@baylibre.com> (raw)
In-Reply-To: <CAJDSL=W7X3am=iCOvafyzLuL8hzZriDWh4Zs2zfgBZDdDJtx7w@mail.gmail.com>
On Mon, 2019-03-04 at 14:46 +0100, André Balsa wrote:
> Hello, my first post to the list, nice to meet everybody.
>
> I cannot boot kernel 5.0.0 on my S905 TV box (using
> meson-gxbb-p201.dtb) from an SD card, see the errors below (captured
> from serial output).
As I already pointed out to somebody else, it is difficult to give any form of
support for boards we know nothing about, especially the one that are
'conveniently' using the DT of the ref design
>
> If I revert only meson-gx-mmc.c to the version in kernel 4.20.13,
> kernel 5.0.0 boots without any problems.
You reverted more than one patch here.
>
> It seems the problems occur because of patches introduced by Jerome
> Brunet in December, see
> https://lkml.org/lkml/2018/12/6/745
>
> My guess is the removal of the spinlock allows for race conditions
> that cause the mmc driver to fail when writing to an SD card.
1) As pointed out in the related commit message this spinlock was useless.
Anyone looking at the code should be able to see that. What you are seeing is
the result of CRC errors.
2) The last 2 patches of related series had been sent as RFT, but noboby
replied.
These 2 changes helped several designs work and I could not see any regression
on the designs I had at the time, including the p200
Now we got several reports of regression.
It is very difficult to find settings that will work for the all the designs.
The documentation is not verbose regarding this. You can't even take the
vendor kernel as reference, the code is extremely 'fancy' and phase settings
are perpetually cycling within the irq handler, which is unacceptable.
We are actively working to solve this and hopefully we will be able to share
something soon
>
> I am available to test the driver further with any proposed solution.
>
> Regards,
> Andrew
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-03-04 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAJDSL=VG2YbAwuL_1SOVfWfD4gWquNG353p8LkCP+jiFpiN=9A@mail.gmail.com>
2019-03-04 13:46 ` Possible regression in driver meson-gx-mmc in kernel 5.0.0 André Balsa
2019-03-04 15:34 ` Jerome Brunet [this message]
2019-03-04 16:55 ` André Balsa
2019-03-05 14:40 ` André Balsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1e057447b1c9ca832db3161242e35963bb15ba0.camel@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=andrebalsa@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.