From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rao, Nikhil" Subject: Re: [PATCH v2 3/4] app/test-eventdev: add Tx adapter support Date: Wed, 5 Sep 2018 12:24:18 +0530 Message-ID: References: <20180904141223.24216-1-pbhagavatula@caviumnetworks.com> <20180904141223.24216-3-pbhagavatula@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org, "Rao, Nikhil" To: Pavan Nikhilesh , jerin.jacob@caviumnetworks.com, anoob.joseph@caviumnetworks.com Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D5C9FF11 for ; Wed, 5 Sep 2018 08:54:21 +0200 (CEST) In-Reply-To: <20180904141223.24216-3-pbhagavatula@caviumnetworks.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/4/2018 7:42 PM, Pavan Nikhilesh wrote: > Convert existing Tx service based pipeline to Tx adapter based APIs and > simplify worker functions. > > Signed-off-by: Pavan Nikhilesh > --- > app/test-eventdev/test_pipeline_atq.c | 269 ++++++++++++----------- > app/test-eventdev/test_pipeline_common.c | 206 +++++------------ > app/test-eventdev/test_pipeline_common.h | 62 +++--- > app/test-eventdev/test_pipeline_queue.c | 241 ++++++++++---------- > 4 files changed, 367 insertions(+), 411 deletions(-) > > diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c > index 832ab8b6e..ab407dbbb 100644 > --- a/app/test-eventdev/test_pipeline_common.c > +++ b/app/test-eventdev/test_pipeline_common.c > @@ -5,58 +5,6 @@ > > > @@ -215,7 +160,6 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > { > uint16_t i; > uint8_t nb_queues = 1; > - uint8_t mt_state = 0; > struct test_pipeline *t = evt_test_priv(test); > struct rte_eth_rxconf rx_conf; > struct rte_eth_conf port_conf = { > @@ -238,13 +182,21 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt) > return -ENODEV; > } > > + t->internal_port = 0; > RTE_ETH_FOREACH_DEV(i) { > struct rte_eth_dev_info dev_info; > struct rte_eth_conf local_port_conf = port_conf; > + uint32_t caps = 0; > + > + rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps); > + if ((caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT)) { > + t->internal_port = 1; > + } else if (t->internal_port == 1) { > + evt_err("Eventdev can't use %d port", i); > + return -EINVAL; > + } > Shouldn't this function also return -EINVAL for the case where internal_port = 0 for i = 0, and internal_port = 1 for i = 1 ? Nikhil