From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F1EC43381 for ; Thu, 14 Jan 2021 17:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FC2F23B40 for ; Thu, 14 Jan 2021 17:36:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728318AbhANRgb (ORCPT ); Thu, 14 Jan 2021 12:36:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:33866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725922AbhANRg2 (ORCPT ); Thu, 14 Jan 2021 12:36:28 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DB6A23B45; Thu, 14 Jan 2021 17:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610645748; bh=xa37m5Q/FryyLUx/FnM3xo2yMtvSkpnfWMgpl5fR0oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HLv1ORWu9ZxRwe8pdpdw9HhGXLnNx3xoN0PEeyIKbfkRmFESf5EaBKxJMWNr+FaN4 tMS7i7VsFShd92LgkQfBEJiFJRMR3JQAeMR76ciYK/5X1rLeGUjkehRmtL5YR4emeV LZRgVEUZZHwcI8zB6AOaHMDJRJLaBtJNwnDJXCQ2dxxMlBeE7jD3f3k9mcVSRMKhXR CNy9Zf2mG22DRSMlC8MTOtjU8//iIshEn+J1JEJ2h6cIUKFOsY20Isn6P0FXEnZ/lm jehNb9QqWIOAPYKMJyyqUqRrxhFdEOdZAmrFPHlqq/2jBDXxsdkEMXSoEepFEE+RFx WVdQZcKwZX7IA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1l06XB-00FQtx-I5; Thu, 14 Jan 2021 18:35:45 +0100 From: Mauro Carvalho Chehab To: Vinod Koul Cc: Mauro Carvalho Chehab , Alex Dewar , Greg Kroah-Hartman , Yu Chen , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/4] staging: hikey9xx: phy-hi3670-usb3.c: hi3670_is_abbclk_seleted() returns bool Date: Thu, 14 Jan 2021 18:35:43 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Instead of using 1/0 for true/false, change the type to boolean and change the returned value. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/phy-hi3670-usb3.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c index cffe6c58dfd7..b5fed306fcbf 100644 --- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c +++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c @@ -326,24 +326,24 @@ static int hi3670_phy_set_params(struct hi3670_priv *priv) return ret; } -static int hi3670_is_abbclk_seleted(struct hi3670_priv *priv) +static bool hi3670_is_abbclk_seleted(struct hi3670_priv *priv) { u32 reg; if (!priv->sctrl) { dev_err(priv->dev, "priv->sctrl is null!\n"); - return 1; + return true; } if (regmap_read(priv->sctrl, SCTRL_SCDEEPSLEEPED, ®)) { dev_err(priv->dev, "SCTRL_SCDEEPSLEEPED read failed!\n"); - return 1; + return true; } if ((reg & USB_CLK_SELECTED) == 0) - return 1; + return true; - return 0; + return false; } static int hi3670_config_phy_clock(struct hi3670_priv *priv) -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F140AC433E0 for ; Thu, 14 Jan 2021 17:35:51 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8E5AC23B53 for ; Thu, 14 Jan 2021 17:35:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8E5AC23B53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 64BA786A2E; Thu, 14 Jan 2021 17:35:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cHNYS+J4cLrH; Thu, 14 Jan 2021 17:35:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 1DF64869BF; Thu, 14 Jan 2021 17:35:50 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id D60811BF9BD for ; Thu, 14 Jan 2021 17:35:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id D0BAA869BF for ; Thu, 14 Jan 2021 17:35:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id v+nSPZceWB0b for ; Thu, 14 Jan 2021 17:35:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by whitealder.osuosl.org (Postfix) with ESMTPS id 6617D869AC for ; Thu, 14 Jan 2021 17:35:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 0DB6A23B45; Thu, 14 Jan 2021 17:35:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610645748; bh=xa37m5Q/FryyLUx/FnM3xo2yMtvSkpnfWMgpl5fR0oo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HLv1ORWu9ZxRwe8pdpdw9HhGXLnNx3xoN0PEeyIKbfkRmFESf5EaBKxJMWNr+FaN4 tMS7i7VsFShd92LgkQfBEJiFJRMR3JQAeMR76ciYK/5X1rLeGUjkehRmtL5YR4emeV LZRgVEUZZHwcI8zB6AOaHMDJRJLaBtJNwnDJXCQ2dxxMlBeE7jD3f3k9mcVSRMKhXR CNy9Zf2mG22DRSMlC8MTOtjU8//iIshEn+J1JEJ2h6cIUKFOsY20Isn6P0FXEnZ/lm jehNb9QqWIOAPYKMJyyqUqRrxhFdEOdZAmrFPHlqq/2jBDXxsdkEMXSoEepFEE+RFx WVdQZcKwZX7IA== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1l06XB-00FQtx-I5; Thu, 14 Jan 2021 18:35:45 +0100 From: Mauro Carvalho Chehab To: Vinod Koul Subject: [PATCH v2 3/4] staging: hikey9xx: phy-hi3670-usb3.c: hi3670_is_abbclk_seleted() returns bool Date: Thu, 14 Jan 2021 18:35:43 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Mauro Carvalho Chehab , Greg Kroah-Hartman , Yu Chen , linux-kernel@vger.kernel.org, Alex Dewar Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" Instead of using 1/0 for true/false, change the type to boolean and change the returned value. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/phy-hi3670-usb3.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/hikey9xx/phy-hi3670-usb3.c b/drivers/staging/hikey9xx/phy-hi3670-usb3.c index cffe6c58dfd7..b5fed306fcbf 100644 --- a/drivers/staging/hikey9xx/phy-hi3670-usb3.c +++ b/drivers/staging/hikey9xx/phy-hi3670-usb3.c @@ -326,24 +326,24 @@ static int hi3670_phy_set_params(struct hi3670_priv *priv) return ret; } -static int hi3670_is_abbclk_seleted(struct hi3670_priv *priv) +static bool hi3670_is_abbclk_seleted(struct hi3670_priv *priv) { u32 reg; if (!priv->sctrl) { dev_err(priv->dev, "priv->sctrl is null!\n"); - return 1; + return true; } if (regmap_read(priv->sctrl, SCTRL_SCDEEPSLEEPED, ®)) { dev_err(priv->dev, "SCTRL_SCDEEPSLEEPED read failed!\n"); - return 1; + return true; } if ((reg & USB_CLK_SELECTED) == 0) - return 1; + return true; - return 0; + return false; } static int hi3670_config_phy_clock(struct hi3670_priv *priv) -- 2.29.2 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel