From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52858C433E0 for ; Thu, 25 Feb 2021 07:18:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 754E664ED9 for ; Thu, 25 Feb 2021 07:18:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 754E664ED9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40880 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFAun-0001rc-9I for qemu-devel@archiver.kernel.org; Thu, 25 Feb 2021 02:18:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:46186) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFAt8-0001Ot-Tk for qemu-devel@nongnu.org; Thu, 25 Feb 2021 02:16:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:58082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFAt7-0002Eb-7v for qemu-devel@nongnu.org; Thu, 25 Feb 2021 02:16:42 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 07C7AB02B; Thu, 25 Feb 2021 07:16:38 +0000 (UTC) Subject: Re: [PATCH v22 06/17] meson: add target_user_arch To: Eric Blake , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Paolo Bonzini , Richard Henderson , Eduardo Habkost , Peter Maydell , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210224133428.14071-1-cfontana@suse.de> <20210224133428.14071-7-cfontana@suse.de> <37da6126-a6eb-a12e-2944-9ac4a232390c@redhat.com> From: Claudio Fontana Message-ID: Date: Thu, 25 Feb 2021 08:16:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <37da6126-a6eb-a12e-2944-9ac4a232390c@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , Roman Bolshakov , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/24/21 11:35 PM, Eric Blake wrote: > On 2/24/21 3:21 PM, Philippe Mathieu-Daudé wrote: >> On 2/24/21 2:34 PM, Claudio Fontana wrote: >>> the lack of target_user_arch makes it hard to fully leverage the >>> build system in order to separate user code from sysemu code. >>> >>> Provide it, so that we can avoid the proliferation of #ifdef >>> in target code. >>> >>> Signed-off-by: Claudio Fontana >>> Reviewed-by: Alex Bennée >>> >>> [claudio: added changes for new target hexagon] >> >> Again, this line goes ... >> >>> --- >> >> ... here. Else it is not stripped by git-am and ends >> burried in the repository (see commit 940e43aa30e). > > If you are modifying a patch originally written by someone else (that > is, their S-o-b appears first, but your edits mean you also add S-o-b), > it is courteous to include your modifications in the commit log in this > manner. (For an example, see commit 2c4c556e06) > > You're right that it can look fishy if your changlog appears on your own > commit (if you rebased things with no one else touching the patch in > between, just update the commit message as part of that rebase; the > changelog goes after the --- for review in that case). But it's not > completely wrong: you'll see me doing it when wearing my maintainer hat > and preparing a pull request, and modifying my own patch different from > how it was posted on the mailing list while wearing my developr hat > prior to the pull request (see commit c930831446 for an example) > Hi, yes, I extended this kind of meaning to my own patches; what I tried to express there was that the change was reviewed, but afterwards there was a small modification (needed for rebase), that seemed trivial enough not to warrant stripping the reviewed-by, but still worth mentioning in the log. I probably should have added an additional S-o-b at the end anyway.. If you have a better suggestion on how to do this, let me know, thanks, Claudio