From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Thu, 6 Apr 2017 12:17:47 +0200
Subject: [U-Boot] [PATCH v4 10/19] arm: socfpga: Add misc support for
	Arria 10
In-Reply-To: <CAFiDJ59Zhqt+7TOuKBRb2-OwTmiYJ_z-xgqS4OLB4gNzewdXuw@mail.gmail.com>
References: <1491384774-49629-1-git-send-email-ley.foon.tan@intel.com>
 <1491384774-49629-11-git-send-email-ley.foon.tan@intel.com>
 <f045d14f-0e9b-8583-2c4d-bf07c2afc37a@denx.de>
 <CAFiDJ59Zhqt+7TOuKBRb2-OwTmiYJ_z-xgqS4OLB4gNzewdXuw@mail.gmail.com>
Message-ID: <d1fdede8-d6f5-8f67-a5b6-817b7036b19d@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 04/06/2017 05:20 AM, Ley Foon Tan wrote:
> On Wed, Apr 5, 2017 at 6:40 PM, Marek Vasut <marex@denx.de> wrote:
>> On 04/05/2017 11:32 AM, Ley Foon Tan wrote:
>>> Add misc support for Arria 10.
>>>
>>> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
>>> Signed-off-by: Ley Foon Tan <ley.foon.tan@intel.com>
>>
>> [...]
>>
>>> +static int find_peripheral_uart(const void *blob,
>>> +     int child, const char *node_name)
>>> +{
>>> +     int len;
>>> +     fdt_addr_t base_addr = 0;
>>> +     fdt_size_t size;
>>> +     const u32 *cell;
>>> +     u32 value, offset = 0;
>>> +
>>> +     base_addr = fdtdec_get_addr_size(blob, child, "reg", &size);
>>> +     if (base_addr != FDT_ADDR_T_NONE) {
>>> +             cell = fdt_getprop(blob, child, "pinctrl-single,pins",
>>> +                     &len);
>>> +             if (cell != NULL) {
>>> +                     for (; len > 0; len -= (2 * sizeof(u32))) {
>>> +                             offset = fdt32_to_cpu(*cell++);
>>> +                             value = fdt32_to_cpu(*cell++);
>>> +                             /* Found UART peripheral */
>>> +                             if (value == 0x0D)
>>
>> What does 0x0d mean ?
> 0x0D is dedicated pin mux number for UART. I can update the comment here.

Even better, use a macro instead of an ad-hoc constant.

>>> +                                     return offset;
>>> +                     }
>>> +             }
>>> +     }
>>> +     return -EINVAL;
>>> +}
>>
>> [...]
>>
> Regards
> LeyFoon
> 


-- 
Best regards,
Marek Vasut