RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021

From: "Lh Kuo 郭力豪" <lh.Kuo@sunplus.com>
To: Mark Brown <broonie@kernel.org>, Li-hao Kuo <lhjeff911@gmail.com>
Cc: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"andyshevchenko@gmail.com" <andyshevchenko@gmail.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: RE: [PATCH v6 1/2] spi: Add spi driver for Sunplus SP7021
Date: Thu, 20 Jan 2022 09:12:11 +0000	[thread overview]
Message-ID: <d202d04f32b8496293bd98e090322104@sphcmbx02.sunplus.com.tw> (raw)
In-Reply-To: <Yeb75aOOckAfNTTG@sirena.org.uk>

Hi Mr. Mark Brown :

Thanks for your comment, I will modify it in next next submission

> 
> > +	for (i = 0; i <= xfer_cnt; i++) {
> > +		mutex_lock(&pspim->buf_lock);
> 
> This lock is redundant: it is only ever held in this function which is guaranteed by the core to never be
> called twice concurrently.

I will modify it in next next submission

> > +	ret = devm_request_irq(dev, pspim->m_irq, sp7021_spi_master_irq,
> > +			       IRQF_TRIGGER_RISING, pdev->name, pspim);
> > +	if (ret)
> > +		return ret;
> > +
> > +	ret = devm_request_irq(dev, pspim->s_irq, sp7021_spi_slave_irq,
> > +			       IRQF_TRIGGER_RISING, pdev->name, pspim);
> > +	if (ret)
> > +		return ret;
> 
> Are you sure the driver is ready to handle interrupts without any of the other resources?  Normally
> interrupts are one of the last things to be requested.

I will modify it in next next submission