From: bauen1 <j2468h@googlemail.com>
To: selinux@vger.kernel.org
Subject: [PATCH] chcat: don't crash if access to binary policy is prohibited
Date: Sat, 9 May 2020 16:06:00 +0200 [thread overview]
Message-ID: <d204aaea-ca46-49c2-f7cd-6f20889cecbf@gmail.com> (raw)
sobject will crash if access to the binary policy is prohibited by
selinux, e.g. refpolicy
this also breaks file operations that don't require seobject.
Signed-off-by: bauen1 <j2468h@gmail.com>
---
python/chcat/chcat | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/python/chcat/chcat b/python/chcat/chcat
index fdd2e46e..55408577 100755
--- a/python/chcat/chcat
+++ b/python/chcat/chcat
@@ -28,7 +28,6 @@ import os
import pwd
import getopt
import selinux
-import seobject
PROGNAME = "policycoreutils"
try:
@@ -65,6 +64,7 @@ def verify_users(users):
def chcat_user_add(newcat, users):
+ import seobject
errors = 0
logins = seobject.loginRecords()
seusers = logins.get_all()
@@ -144,6 +144,7 @@ def chcat_add(orig, newcat, objects, login_ind):
def chcat_user_remove(newcat, users):
+ import seobject
errors = 0
logins = seobject.loginRecords()
seusers = logins.get_all()
@@ -233,6 +234,7 @@ def chcat_remove(orig, newcat, objects, login_ind):
def chcat_user_replace(newcat, users):
+ import seobject
errors = 0
logins = seobject.loginRecords()
seusers = logins.get_all()
@@ -376,6 +378,7 @@ def listcats():
def listusercats(users):
+ import seobject
if len(users) == 0:
try:
users.append(os.getlogin())
--
2.26.2
next reply other threads:[~2020-05-09 14:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 14:06 bauen1 [this message]
2020-05-10 17:25 ` [PATCH] chcat: don't crash if access to binary policy is prohibited Nicolas Iooss
2020-05-29 13:16 ` Stephen Smalley
2021-02-17 21:16 ` [PATCH v2] chcat: allow usage if binary policy is inaccessible bauen1
2021-02-22 18:27 ` Petr Lautrbach
2021-02-22 20:33 ` bauen1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d204aaea-ca46-49c2-f7cd-6f20889cecbf@gmail.com \
--to=j2468h@googlemail.com \
--cc=selinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.