From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754316AbdKFQzP (ORCPT ); Mon, 6 Nov 2017 11:55:15 -0500 Received: from mail-co1nam03on0084.outbound.protection.outlook.com ([104.47.40.84]:26688 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753096AbdKFQzN (ORCPT ); Mon, 6 Nov 2017 11:55:13 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Joerg Roedel , Tom Lendacky , x86@kernel.org Subject: Re: [Part2 PATCH v7 35/38] KVM: SVM: Pin guest memory when SEV is active To: Borislav Petkov References: <20171101211723.71594-1-brijesh.singh@amd.com> <20171101211723.71594-6-brijesh.singh@amd.com> <20171106144334.b73z4qng76d2q5cr@pd.tnic> From: Brijesh Singh Message-ID: Date: Mon, 6 Nov 2017 10:55:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171106144334.b73z4qng76d2q5cr@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: BN6PR1001CA0021.namprd10.prod.outlook.com (10.174.84.34) To CY1PR12MB0152.namprd12.prod.outlook.com (10.161.173.22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3a788b67-7e87-4a96-f727-08d5253724df X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603249);SRVR:CY1PR12MB0152; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;3:rr6V7yEjujoQN1DT4mW610pOJXhROWqFv61rsIK7vfDA4bMDDXCjkgF0JfO3nMGEIKvtG7usze/va67JNZlogZS6ubqcPfonj8DlNXk1yKw6sx+fsIQxZExFwKLtfa0kh0Gny193Ga7cwvzAKXNX76mFtuZhAJm0fT4rgSEvbMEbrwauUB92gpLJocUSsSYtlTLPQBF4h1xRwdU6UTTcu+W0+MzZy2OErTa8mbCD6O4fqJbdaCHR992IhCLJgzsH;25:6e0bFQ3trAtzwidxhFC+10oT4N3UwxFYpdQ1XviBq7rF+3yMz9RgmqRVkKQtGmfJ0oQvY/oYg3XqquGVHHScfDGCRQz8FKJ/78/rihsul5YoL5P4fczcY9g5jr07M78WarizoJqmcHVUPw1iqsVixnzmFZKxRkHHIFEdKblSJOwqzxoNAQddfzyB1m81pAkamt0Zn1A8GkayxHHnXxRSZxkHieeO1wJ6ggFmWBrfB+prcfqdhKaeuJx3nk0mpBIeaWI4YVulpuTjCyTxju7/DvduHqxR80gJ7l8oaENvLviTF8Bv7z9UFX4aKTYViOTIgGWQVyKVeUgjtSZ52adRiw==;31:+/Eh95uw+eg2BeEqtgmdNU3Bjq5B0pKgW7rDGEm+gV142CBFRLajzDmqUXx0tusPgfN4pYcHb9CDRmj9J6gT0jX4yq0UEsEytC1TOv3NOtYctQc7lx+tkkDTxACraFZvCz/uBtC1xYvM2OD/bHT9PWi69RbIbg9vvTfyICHtmLpif0n0B/B4hA884giXW8zmFZbsNWl0rgV2gSLYvrp/nrTFpy0nF0iSxpgxKCZiDBE= X-MS-TrafficTypeDiagnostic: CY1PR12MB0152: X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:QQz9GzI0rPOLz4vvbg8/Po3OIexQxMgWbCgO47fMr7asM9D17pvb5FvN2atCRGmKwM6A+81YurSEeqX8m2iGM0tE5Xcjjv2LiDAum1Z3vrn3KyiszYZ8xnm2PJ6PAZluT3bOuZIoSRbTPy8dSXTtUZHf0VGfftdxQQ/omSHbYsVS+MBsnpaH67vpnQz8XlJRarWdL4yiwtYAVqAa5QEHGD0DXiVweUkG9cw2f0z6bdK7Qo19qPhuc6ajeXJ6NYHY0rVfG69TRvnfdDuoUPuJ8gLCLqgGcTZ2ZEOOU1G+Wikcye/rXEYlRDurdfcIhVSofWyfnls5Uv0+qe4inCvp5a6oEJ89DOy5SGkSawA2MT39KEUWyHjcJL1KrpvXKOo88MdPHz0XDGvZ3TzB+XWmuiEYDhqlTwWxKTJqnFH7cEtSQ9xXyDFNGmcN0aJTy0jGLMnnZ84SUas3oUEsRdakKguHJ3vZ8eElYat8QYPNPidUedMpjyiOMqW1REdv8hlh;4:lNB0XGhcoN+DlQCG/8t31FYX1grkQedxN8BXEAFbSQaK7kDll6nXre+IrfuG3+6klWOo7oUqMRXTNnl/Vedb/fz3YV4PZQxKphuQJ8JDdST+I34bUTR+NZpb/hKOnwhVGC78Gf5WDcIbvz6UHvoe03Avy0BTg60tRvl8NIrYXj4kruRQFAsEkGHs/auM+Lm3EyHzNRItVh3UnkzwQJeaJgzPVJjfqRnNcCYKrO5XHZKT3GHfQX0KVWE0cp975/qbCkau8h7e9RAvWb10YVMb9Q== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(3231021)(100000703101)(100105400095)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:CY1PR12MB0152;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:CY1PR12MB0152; X-Forefront-PRVS: 048396AFA0 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(6049001)(376002)(39860400002)(346002)(189002)(199003)(24454002)(16526018)(65826007)(31686004)(97736004)(23676003)(67846002)(6916009)(2950100002)(64126003)(478600001)(54906003)(58126008)(50466002)(6486002)(90366009)(230700001)(3846002)(36756003)(316002)(16576012)(6116002)(7416002)(77096006)(5660300001)(6666003)(53936002)(101416001)(189998001)(25786009)(47776003)(81156014)(86362001)(33646002)(105586002)(2906002)(81166006)(53546010)(4326008)(50986999)(83506002)(65806001)(65956001)(305945005)(66066001)(7736002)(76176999)(54356999)(8936002)(106356001)(68736007)(6246003)(229853002)(8676002)(31696002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0152;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTFQUjEyTUIwMTUyOzIzOlpFcWEyaEF5ZHFLV3JrOThqbndYUXhxblVu?= =?utf-8?B?ZTJLd2VKR3dyMXpucFhkbFhmNGc2VnhMT1lxemRmS3BVU25UQ2dlalA0YTUr?= =?utf-8?B?OHJ1VTRVRUxhdkpsL2pDU0Z0OEljclEvUzlhTjhmUVBKd3gxZTVjZGl0Ull0?= =?utf-8?B?SW5qYW5COU1SamtrWlRPRW83alFMYUlQVWtsY1pSY0ZwQTMzZk1ZUWtXVzI5?= =?utf-8?B?c2Y4N2F2aGxhTk9zMTI3MXFjaEpwOW9SelNEYjJKNzliWlVGZGhSc0xUSnFK?= =?utf-8?B?QXJxNU16d0tyYUk1MHhJVEFORWpoTFh4d3NnR0hrdGVmYkltN0VPdnZYdnl6?= =?utf-8?B?SjNoRmZMa1lrU1AxSjdVTXkzTHdaek9TSkpEeDFrbFEwVmxFSjRVamdzREZz?= =?utf-8?B?cG43RzJNaW1Sekk4QVA4RHZtajh3d1Qza0hPSlJ5NWFicTVQWkgwMWFaZnVD?= =?utf-8?B?aXM3alI2dVMzdy9lNFpqVW8rNHovZ21xRFZ5aGRUUzV6QkovOEFHbml2NElB?= =?utf-8?B?QXlwQjZNaEFIVDlMcWlqeDluRWlDVTNjMjIzY2ZaSzN3Uy8rQmtsQm5ZSWJw?= =?utf-8?B?L3RXY2liUVBrRk1FcHpVczU1amp3MmxrZDBmdFMyZnBDZytNY1BMODg2Y1dQ?= =?utf-8?B?OUJtMjYrRWQ3bnMxMElVMjk4aGhIL2JtZDhVYWhNazU2RHZQbTBqKzlNaWR1?= =?utf-8?B?M3p1U1FacU4ySm1qUXlDcEc1aFZVMnRLaHNVUEJXWWpwWUQ4QmV6TGhlbnhI?= =?utf-8?B?MHRkaWhBL2FueFozYXEwc1NaaGpQZURoU3NPZWczYm9zSDA1aWRBdnVEOHRC?= =?utf-8?B?NUx1WnlJOWhjRC9meGx4VHhObVpIb1VBQXRmRnl1TEJ2bi9HaUZ1MFlqRXRM?= =?utf-8?B?Y2wxYVZJNHZaYzJCckQ4a2ZRL2lHNERqclZ5ZS9nemQwdlFYV0NLY2lVY1JM?= =?utf-8?B?ckV1dEh6MGo3ZlRWN05HZXBXUUo2cVBmRDRsRHErbFVMWkFUcGkvL2JMRGs4?= =?utf-8?B?WFQ3U2wvajFaR0FxUTI4YlVBRk50bjFucXg1SUY4V2Nxcm1XdU1vNG80ZWxm?= =?utf-8?B?Qmxpc0g0eDgydmpnOTJPMjBqQVFxVmloeVlySGRwNmpLSHVZWkhLMTBwck5v?= =?utf-8?B?b3Q5U2V0M3MzTDJXcWNjWVZKWjJEMHJ0TWlwQzJmdnA0ZGptVTE4WlJSa29R?= =?utf-8?B?bUZJREQvVGkya1ViaUlmUlVYVDluZ0Q5WEpGcElJaDlFYXpPMTU1WjBjdkM5?= =?utf-8?B?eXpTK1huWWdSb0I1Tm5xOXFNNzhBSDhmMENyYkdwRmt1TklKQkdRdUV1Q09S?= =?utf-8?B?R0t0VlpvRWd5cExhc1hUNGRQaU0zcElCVnhPNElwV013Nkoxdkc4b0lQMTRv?= =?utf-8?B?MlZ4MlM2dXh3N3FiTHJ5cTRYQ1I4TmJPOTZRQ1FYQ3MwT04wTkFQZXdvb0Zi?= =?utf-8?B?V1FZSTVxckVoeUYxMkR6cVRwTWxZMmlnSGhjNDhtYXlDNUdkNEJLL1lVY0lZ?= =?utf-8?B?RkZ5c2JJNytFaXBUUDFXM0tSaG50UjRua21BLzNRTzlFeTQwREIwWWpLcUNJ?= =?utf-8?B?QWNTRGJNZytFUDdScVlwbzZ2RWJ2MFFQcW5Fb3IwTFo5SW1NSWhMbktNRUY0?= =?utf-8?B?SjhwUURMYlZkdEpKTks4YkVwTzY5MzNuNEVpVXlQUzIyVDlvRE5kR2lpNEhx?= =?utf-8?B?YWxFZ0p5Q3dsREhnbWhTNzl1MmRwMVlmcFVSTldYNzNPYmtKQUZteHVvUUIv?= =?utf-8?B?Ym9XUVNPRVZuNUVjYTl3Wk9CNVhRcU00bld6dks1VmJUMnpnckdKb0ZwQlJw?= =?utf-8?B?dk9PWmZFQWs5Ujl1aHdWTzgvMFloWVErb3pyRzdpeCtwRnBKeEYzbGFjQlln?= =?utf-8?B?dUhNRkVSYmVrbzYrQ3VzNXMySjBST3FIemRtOUd0VDNybnU3cERvL2JNVVFk?= =?utf-8?B?aTkrcEp5V3h3PT0=?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;6:CGhB5HYIhnJH8GVz77dSEmVAMzDlT4baUQQAlt4ukMu8WQehjVU5gQcPEncme4y7id62q5lt9wAW8eBSPmkJXuIZWXlWIAgDDHYQxNJ159fzqMtbzAikVOzWHWcs94HPhheFx1CVB+lmCzpE4CAGRU12q4VcowrV9+yubNkXq0ZOHTMyXICEyjjIlFsmO6gvM7YZfrLmok5PmB1z1mMJZJHfXegPBoby+NV/vAcyoznhKolo81UNoSTOJchAH/hjoqGh3QmM+UUATFmDqzMpqfSbWY+/WWAUgTgyXA4Y7eRPEzogh9roCUQQe9WIdX2CdnD+EXAqL4wVp+Ka3bBmi8c/nHquA0uLei0IU5Qy9m0=;5:lBQX3yhKTViEDEfXJpRG15gkAc+t1TfkXXIMJ+20B01+z2Uirds3BgrJXpOJRNsYE/B6aaaOgYG2wAi8y+FtBeQxhjNyGvxdPedpbGVHrllrFytwAZLNRQm0NTptZ2CakS2MLg0r0OaYhCh/pippDE3kghoseH8ZBjG5VMnr/zo=;24:sbjmvUA2XfFR0GZXkBihynXFl+RQEOVmXejKKh7H5jy7e4aL2KgT0V7kk/534XB1s9WMZ3jhh7Y+s3Zul65IYBdUKHx9WV+SM6vVfpHozZk=;7:HKCVP3dxu4DLty4IPtBj0DgLe12x6Zn1zzt5k0uo9BLYcShrLQfPNrLochO2lfTy7zCg+qAnCMQDAYjiwjxqyCxd15UGeTx0kvxLAyh9FOFrsm5f0Eeb2/EsNZgCbl717I89ywJhbKITQtN+ClIEJvUMDTnXzHSwn0His2U2R/tlqKzq8RXkENI1zkwY6sCAuc+OdtlgEbHT+9XsBbSRYTE9zggugIz3yIdkxwrnUSNMyiF4Nyme8e0f7eJAsL1j SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0152;20:KeKAhAXVe8QT5oDThKCEoq/OjMjpppH8FkFY/x+BgX4kQFbQWV7Un9839AQguwlxnHLyM/5kW46PsHLM8J864+HRRVxCFd05S3Rwz1sp3O1CaE0S9OYTyz1MdQ13a4/JCrX+RCCu8GSN1/nYNUBCIvd9ipHZ+tisLASuGojpwSPw0KurX9gfe4P1s6wGMOHNAkBBGCuHHk78JxfrXlirQNU0oRSUNmynzNw8EPKTPP+J7PF/6Muie5Lcq5QgdmsS X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2017 16:55:10.1129 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a788b67-7e87-4a96-f727-08d5253724df X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0152 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2017 08:43 AM, Borislav Petkov wrote: ... >> + >> + region->uaddr = range->addr; >> + region->size = range->size; >> + list_add_tail(®ion->list, &sev->regions_list); >> + return ret; > > Nothing's protecting that list from concurrent modifications of adding > and removal of regions. > Ah good catch. I will fix this in next rev. Similar to the mem_enc_op(), we need to acquire the kvm->lock when adding or removing the regions. -Brijesh