From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DAB62F25 for ; Sat, 26 Mar 2022 09:10:06 +0000 (UTC) Received: from [192.168.1.107] ([37.4.249.126]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mhl8Y-1o2gGc2cbI-00dlml; Sat, 26 Mar 2022 10:04:14 +0100 Message-ID: Date: Sat, 26 Mar 2022 10:04:13 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Content-Language: en-US To: Adrien Thierry , linux-kernel@vger.kernel.org Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Gaston Gonzalez , Ojaswin Mujoo , linux-staging@lists.linux.dev, Krzysztof Kozlowski References: <20220324172647.167617-1-athierry@redhat.com> From: Stefan Wahren In-Reply-To: <20220324172647.167617-1-athierry@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:MF0J0jzDKrDVpVSeRs+yL5+DPjsuUuOKN6ic8X9ZRn9nO5noxHE pkVO2sNitXCFmRHUYlBBUZ1tQN3NKo0K433u9l4QCIRYICQwOtKUy4GWlj/riTRa0PTSVdE tbIw+2vzeG0sgDVscEhHT0arSZ+SaGUcpV8UnfRX2uCI2h5Pff0VKrPgwFoimW8T16j6S+k QX4wZ8bO1NS22VMOx5AbA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:HEgWnirrg4c=:3saXw4EW8o512aWrybj/9T KjgNRs5DiSoyu0hWIWFdz5/+Z2E92S1HW/hHL+VANr3i05qW1rK0OA8ROtzGPu3Oi6uTqLmqC IBb7RtW84LC1TEE4tl2S149yrecRzRjK/TWr60Sk3Ni9qXMKBvtGXF2GgMrBS2q3CLC/U6dWZ FIvwFNXNR+CFAZnf/7WIJXThY7iU+qHy3bU+gWfNmqY7Piv/y0NqkpqJO3A4qrMsw4mkkE2VU hCQvTzpG7ncsWe3qhlqh50zqd/HsmfIJpAc+najovC1mZ5936Yc+fY/+KSs6hIbjfsu9ndu2x MW+4/FRQLHVyq27txuiScBk9P3vBWRqS+g4ItwIj/91Su/n2kFMkE3MZnx+SiVv/K7hEItOLg rtB6acB4fZcfk1ev+Mj94+D+ttBeCe9QosC/0NI124Ghb9e66SCQMnsBiqVoD82xsShVgYPfk +BfYso6yBsKZ15hc9lhGKxjnlf0asf7+AkEmS8tPQybJPUge/oqY+EGR3mj7NhclbFK/H2h+U jmIp/lX8m2JKYQ+VIl9xIiF7aaTdz2kwHUGecd3aMk4wZw6I8Dp1gYF6SWnOvTFYChNZcZCen WpshipbA0bTgHq5erWMq8A6W5AjNfxABBNbDqubcLjBRBP+i6eUs/JNGXCI0H6gdWkZP43Odu Uvp0KX85dmbS7S/PSTmNqopNLXjkdYe9NKUlUSFiE48y2BjifYq+fmKxh1VASlWrExMgwRnFQ ALH4D9w6zj60YvS9 Hi Adrien, Am 24.03.22 um 18:26 schrieb Adrien Thierry: > The goal of this patch series is to use the bcm2711 compatible string in > vchiq_arm for the Raspberry Pi 4. there was already a patch series to enable VCHIQ on BCM2711, which wasn't accepted: https://lore.kernel.org/linux-arm-kernel/20211014223230.451659-1-mguma@redhat.com/T/ Could you please explain your approach, especially leaving out 36 bit DMA support? > This allows using the downstream device > tree with the upstream kernel. This is a really bad idea and caused a lot of trouble in the past. A lot of the issues in the Fedora or Arch Linux forums or mailing lists results from this idea. It wastes the time of the kernel developer since these DT files has never been reviewed by the devicetree maintainers. Best regards > > --- > Changes since v1: > - Removed duplicate compatible string for bcm2711 in > brcm,bcm2835-vchiq.yaml > > Adrien Thierry (2): > dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 > staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based > RPi > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ > arch/arm/boot/dts/bcm2711-rpi.dtsi | 1 + > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 +++++ > 3 files changed, 11 insertions(+) > > > base-commit: ed4643521e6af8ab8ed1e467630a85884d2696cf From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B057DC433F5 for ; Sat, 26 Mar 2022 09:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=K0vMLDavnO8yY3RNT4d1UAQUDpnuVWA5usLQe1gXrZY=; b=TIJz2xODFkz2tW 8bwna/Etm6nEP3HdtB6dYwCozEOmZOBpg3+A/mV5jZvkv7DBrE04jq03sPUBTB5WU9/ju+R4fSBYb 9nqTKw6PkxngOY8Y4MGC0cDDjDO27+UtSJjliprbI+CFphyXF2oxr6RfVfNM7MfcL0WPxyVKVxmqw PPFjaAxGeIOIIFDj8q+FwlwKk8JRMLaVt485K2+gFkQOF30KEAIFpWFp0BUNBEbDC3xmB0oMNCGYM e574f45yX7yLWZtI8A+jKiZbPwg/L1sAeadWxMxQMAUDxv6oETUxm+FQvas3U3dO3rCVLoURGWxYn cudUpmtvgFM7h3P5c00w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY2LU-0043us-Ku; Sat, 26 Mar 2022 09:04:28 +0000 Received: from mout.kundenserver.de ([217.72.192.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nY2LQ-0043u3-Pk; Sat, 26 Mar 2022 09:04:26 +0000 Received: from [192.168.1.107] ([37.4.249.126]) by mrelayeu.kundenserver.de (mreue108 [212.227.15.183]) with ESMTPSA (Nemesis) id 1Mhl8Y-1o2gGc2cbI-00dlml; Sat, 26 Mar 2022 10:04:14 +0100 Message-ID: Date: Sat, 26 Mar 2022 10:04:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 0/2] Add support for bcm2711 in vchiq_arm Content-Language: en-US To: Adrien Thierry , linux-kernel@vger.kernel.org Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Gaston Gonzalez , Ojaswin Mujoo , linux-staging@lists.linux.dev, Krzysztof Kozlowski References: <20220324172647.167617-1-athierry@redhat.com> From: Stefan Wahren In-Reply-To: <20220324172647.167617-1-athierry@redhat.com> X-Provags-ID: V03:K1:MF0J0jzDKrDVpVSeRs+yL5+DPjsuUuOKN6ic8X9ZRn9nO5noxHE pkVO2sNitXCFmRHUYlBBUZ1tQN3NKo0K433u9l4QCIRYICQwOtKUy4GWlj/riTRa0PTSVdE tbIw+2vzeG0sgDVscEhHT0arSZ+SaGUcpV8UnfRX2uCI2h5Pff0VKrPgwFoimW8T16j6S+k QX4wZ8bO1NS22VMOx5AbA== X-UI-Out-Filterresults: notjunk:1;V03:K0:d6HKoQudEVo=:GbponABS8VCxPl4Deiz4Az eszX52sV7NCtNdzh/sBB82qpMGmqS2nUFBE8RV8c4MJ/RWCWqyjbVTOLqD6ZHdQLP1UZvxdR/ /vCN5ZIwM/jBEdZs2qof9iwitLQTzmYg9z4tuFMwWe2KQnG6CAJeFXGM02k7pZoXYhgJThrS1 3zhiXBrT6eHXFKw7NgtFIxCVQdbGy2kdtOqlVMbcCvbBs6SJxx+tRAqFDxCBY5EOVjtZTAh06 GGf1VidSwJhsRw6tebMG7AQeVLUUiB0o42A8NMgHHngGPAUvl8MVDB4bNvB5G+WLhSm5nSBni LBlwC4ZyjtLu2MiPV8li5VyCtZy4oGY/bNKjJ0D0kBXFBqRIjGJpArOk0bgjJWVct2RAmHbvX PQMgBLaiAq8Vi6SJrDQ2XjQOuHkWHGvV2nT+zhp1CuZALrVAcE89G70g9DJHlMUm7kVNY9sIs 8eaNv+rOdaC/xQTpCkD/mK3b4cc+0ByzZI2I8BDRIe5RZyb4cU2hCaKpyYGWCA4EkwBxXF1ed TyxhqU8ZWgrxu0t23yDqBfpPqIySAt3dkx6mRb2IqZeaoIVcHQKw9mOcergZCc4w4iI2SHvKY doaFO+EorTyx2r4gA7+sVrrLpFDJ8TcX5Oj0dPMtUBEkL+LsAxaWsZ0xveJSQ0RTIxJm1Auf1 BQPoByxX0t3jORx7+j/K2aTwU719WptaLFfYBkPyz7QbfDXllgc8ubzrAQqrMhTO5aff9lLVj HTts3do4QFfzJvvH X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220326_020425_191741_9E664268 X-CRM114-Status: GOOD ( 18.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrien, Am 24.03.22 um 18:26 schrieb Adrien Thierry: > The goal of this patch series is to use the bcm2711 compatible string in > vchiq_arm for the Raspberry Pi 4. there was already a patch series to enable VCHIQ on BCM2711, which wasn't accepted: https://lore.kernel.org/linux-arm-kernel/20211014223230.451659-1-mguma@redhat.com/T/ Could you please explain your approach, especially leaving out 36 bit DMA support? > This allows using the downstream device > tree with the upstream kernel. This is a really bad idea and caused a lot of trouble in the past. A lot of the issues in the Fedora or Arch Linux forums or mailing lists results from this idea. It wastes the time of the kernel developer since these DT files has never been reviewed by the devicetree maintainers. Best regards > > --- > Changes since v1: > - Removed duplicate compatible string for bcm2711 in > brcm,bcm2835-vchiq.yaml > > Adrien Thierry (2): > dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 > staging: vchiq_arm: Use bcm2711 compatible string for bcm2711-based > RPi > > .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ > arch/arm/boot/dts/bcm2711-rpi.dtsi | 1 + > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 5 +++++ > 3 files changed, 11 insertions(+) > > > base-commit: ed4643521e6af8ab8ed1e467630a85884d2696cf _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel