From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F647C43603 for ; Thu, 12 Dec 2019 14:34:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 01C592067C for ; Thu, 12 Dec 2019 14:34:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OguXM/3J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729732AbfLLOek (ORCPT ); Thu, 12 Dec 2019 09:34:40 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:56105 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729716AbfLLOek (ORCPT ); Thu, 12 Dec 2019 09:34:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576161279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8L0wh57USWeg4kwDbaH2LaCzisTmsJPLc/9WAOqxji8=; b=OguXM/3J8LGWIicHGD40uEHW5+9RlEj7anvHDGN5dszY5qvpRfCTf4DVdyWZ6JLmG4maxY s50+p22i/xY/WilnnIePcY+kiEpfMA7dRKTrSP4AAmwlNwz5OwHiQdiFYNmYYuneT90qPg BLwyjtAOrCrTHOmQ3R5tFDh7cuRmyQM= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-238-_TOoGmWNNUeJJAgIxpXNwQ-1; Thu, 12 Dec 2019 09:34:37 -0500 X-MC-Unique: _TOoGmWNNUeJJAgIxpXNwQ-1 Received: by mail-wm1-f72.google.com with SMTP id l11so1734024wmi.0 for ; Thu, 12 Dec 2019 06:34:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8L0wh57USWeg4kwDbaH2LaCzisTmsJPLc/9WAOqxji8=; b=P7BDDpM5tSPujgr20VTbpkKDTQ/9TECdZRuU1sMJZ3wZ1mzfnB19SZBLlWzmhe47g4 ZjkE/LRQP9u+RC61iiW6sx8p3jH5u5tegyAH/PekzmNu26JyaITjlB6yP3oEp+a7LkYc vUyHCMfaiELta8SxNoiiVnBUESLE57yG7K+voRE4T8DGKTtqhKFXj00WKJcC3+9rP0rD g54xeOJBatWBtYjmFuMuAmt99Pzu0VsEa4M9MSnv6a7Db+yxBDDV7zMEM+aBuG63MnRt /UqExXzX+Sf9w9xuluOV/MAS3G0meND087IAWnyI/zKuICEZyquNaFMtpVKNdy968c02 q+nA== X-Gm-Message-State: APjAAAUpRjGCL0adMnerETdith15dPt7rveGbFVcSUVTqv6WleAxQXpY lV8nLAXtUZeUEDy/zCgXW0GX8jv9k75vknERhZHY3s2ufi62V3Vv3cKl6AqYtkX6REH7MH8EaOL NxLxn6yWzPaA84Qoxvgf0dw== X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr7132905wme.151.1576161276518; Thu, 12 Dec 2019 06:34:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwkMCbj3Al3W02aKWsSaIJItyyUbz24oMkL+40mFm8mAw2FfNeYRrpFtQxw5vg9q9Dyq+2PYg== X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr7132870wme.151.1576161276268; Thu, 12 Dec 2019 06:34:36 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id y20sm6009145wmi.25.2019.12.12.06.34.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 06:34:35 -0800 (PST) Subject: Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight To: Lee Jones Cc: Maarten Lankhorst , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , "Rafael J . Wysocki" , Len Brown , Andy Shevchenko , linux-acpi@vger.kernel.org, intel-gfx , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20191119151818.67531-1-hdegoede@redhat.com> <20191119151818.67531-3-hdegoede@redhat.com> <20191210085111.GQ3468@dell> <20191212084546.GA3468@dell> From: Hans de Goede Message-ID: Date: Thu, 12 Dec 2019 15:34:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191212084546.GA3468@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 12-12-2019 09:45, Lee Jones wrote: > On Wed, 11 Dec 2019, Hans de Goede wrote: > >> Hi Lee, >> >> On 10-12-2019 09:51, Lee Jones wrote: >>> On Tue, 19 Nov 2019, Hans de Goede wrote: >>> >>>> At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 >>>> different PWM controllers for controlling the LCD's backlight brightness. >>>> >>>> Either the one integrated into the PMIC or the one integrated into the >>>> SoC (the 1st LPSS PWM controller). >>>> >>>> So far in the LPSS code on BYT we have skipped registering the LPSS PWM >>>> controller "pwm_backlight" lookup entry when a Crystal Cove PMIC is >>>> present, assuming that in this case the PMIC PWM controller will be used. >>>> >>>> On CHT we have been relying on only 1 of the 2 PWM controllers being >>>> enabled in the DSDT at the same time; and always registered the lookup. >>>> >>>> So far this has been working, but the correct way to determine which PWM >>>> controller needs to be used is by checking a bit in the VBT table and >>>> recently I've learned about 2 different BYT devices: >>>> Point of View MOBII TAB-P800W >>>> Acer Switch 10 SW5-012 >>>> >>>> Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS >>>> PWM controller (and the VBT correctly indicates this), so here our old >>>> heuristics fail. >>>> >>>> Since only the i915 driver has access to the VBT, this commit renames >>>> the "pwm_backlight" lookup entries for the Crystal Cove PMIC's PWM >>>> controller to "pwm_pmic_backlight" so that the i915 driver can do a >>>> pwm_get() for the right controller depending on the VBT bit, instead of >>>> the i915 driver relying on a "pwm_backlight" lookup getting registered >>>> which magically points to the right controller. >>>> >>>> Signed-off-by: Hans de Goede >>>> --- >>>> drivers/mfd/intel_soc_pmic_core.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> For my own reference: >>> Acked-for-MFD-by: Lee Jones >> >> As mentioned in the cover-letter, to avoid breaking bi-sectability >> as well as to avoid breaking the intel-gfx CI we need to merge this series >> in one go through one tree. Specifically through the drm-intel tree. >> Is that ok with you ? >> >> If this is ok with you, then you do not have to do anything, I will just push >> the entire series to drm-intel. drivers/mfd/intel_soc_pmic_core.c >> does not see much changes so I do not expect this to lead to any conflicts. > > It's fine, so long as a minimal immutable pull-request is provided. > Whether it's pulled or not will depend on a number of factors, but it > needs to be an option. The way the drm subsys works that is not really a readily available option. The struct definition which this patch changes a single line in has not been touched since 2015-06-26 so I really doubt we will get a conflict from this. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7545C00454 for ; Thu, 12 Dec 2019 14:34:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADE362067C for ; Thu, 12 Dec 2019 14:34:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OguXM/3J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADE362067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C28DE6E1AA; Thu, 12 Dec 2019 14:34:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by gabe.freedesktop.org (Postfix) with ESMTPS id C8D136E1BD for ; Thu, 12 Dec 2019 14:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576161279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8L0wh57USWeg4kwDbaH2LaCzisTmsJPLc/9WAOqxji8=; b=OguXM/3J8LGWIicHGD40uEHW5+9RlEj7anvHDGN5dszY5qvpRfCTf4DVdyWZ6JLmG4maxY s50+p22i/xY/WilnnIePcY+kiEpfMA7dRKTrSP4AAmwlNwz5OwHiQdiFYNmYYuneT90qPg BLwyjtAOrCrTHOmQ3R5tFDh7cuRmyQM= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-12-dWLE1DQWPrqJHIEixIBjxg-1; Thu, 12 Dec 2019 09:34:38 -0500 Received: by mail-wr1-f69.google.com with SMTP id h30so1105732wrh.5 for ; Thu, 12 Dec 2019 06:34:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8L0wh57USWeg4kwDbaH2LaCzisTmsJPLc/9WAOqxji8=; b=CNp5W4qDcN1BqUB2hbxyQyV/FmqPTqKLD2rMV+RENltQd9mOvRcMHPdpz4xwdxbwBr 9QDNh4jT2ZUYWN/jfA6czInUlTs6wiEWbZCHqLO0fyG52JwvF3w68cfRmCjEV+IBzAMU E5XH+FTYcT61kJVavi4xzLNy3lgSQi31UrhQihl8n9jX5HhwejP+u8NH7X7DbW9UI7qe 3TvZw7h6HsbOXHA3qGeQggiWbIx1+kcrwmMYby6LrOWr1ViIK2FWjZFv1reIgKVDnT8m PbXxEsK/OwyBlauqbrPGHFOqfl/uhNbWjJ+PeiIi0Mx0+qy9GTT9xfY6LoUTIlFPsogC AP/w== X-Gm-Message-State: APjAAAXcUpggd84GIC8RoBsmeFz4IwmyjTDdth0Z9L+7RGOP02xLpcBl qdBWd86P3cPsCqcpfJn0e3bUHBsDUxj9GkJ/P+SjlasDqY8/mwSHnv3O4VkMJv2CfM97MR9xCYK bAdgIO7kXnMfTAqlTV9QDW1lBCJRV X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr7132895wme.151.1576161276514; Thu, 12 Dec 2019 06:34:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwkMCbj3Al3W02aKWsSaIJItyyUbz24oMkL+40mFm8mAw2FfNeYRrpFtQxw5vg9q9Dyq+2PYg== X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr7132870wme.151.1576161276268; Thu, 12 Dec 2019 06:34:36 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id y20sm6009145wmi.25.2019.12.12.06.34.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 06:34:35 -0800 (PST) Subject: Re: [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight To: Lee Jones References: <20191119151818.67531-1-hdegoede@redhat.com> <20191119151818.67531-3-hdegoede@redhat.com> <20191210085111.GQ3468@dell> <20191212084546.GA3468@dell> From: Hans de Goede Message-ID: Date: Thu, 12 Dec 2019 15:34:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191212084546.GA3468@dell> Content-Language: en-US X-MC-Unique: dWLE1DQWPrqJHIEixIBjxg-1 X-Mimecast-Spam-Score: 0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Andy Shevchenko , Len Brown Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 12-12-2019 09:45, Lee Jones wrote: > On Wed, 11 Dec 2019, Hans de Goede wrote: > >> Hi Lee, >> >> On 10-12-2019 09:51, Lee Jones wrote: >>> On Tue, 19 Nov 2019, Hans de Goede wrote: >>> >>>> At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 >>>> different PWM controllers for controlling the LCD's backlight brightness. >>>> >>>> Either the one integrated into the PMIC or the one integrated into the >>>> SoC (the 1st LPSS PWM controller). >>>> >>>> So far in the LPSS code on BYT we have skipped registering the LPSS PWM >>>> controller "pwm_backlight" lookup entry when a Crystal Cove PMIC is >>>> present, assuming that in this case the PMIC PWM controller will be used. >>>> >>>> On CHT we have been relying on only 1 of the 2 PWM controllers being >>>> enabled in the DSDT at the same time; and always registered the lookup. >>>> >>>> So far this has been working, but the correct way to determine which PWM >>>> controller needs to be used is by checking a bit in the VBT table and >>>> recently I've learned about 2 different BYT devices: >>>> Point of View MOBII TAB-P800W >>>> Acer Switch 10 SW5-012 >>>> >>>> Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS >>>> PWM controller (and the VBT correctly indicates this), so here our old >>>> heuristics fail. >>>> >>>> Since only the i915 driver has access to the VBT, this commit renames >>>> the "pwm_backlight" lookup entries for the Crystal Cove PMIC's PWM >>>> controller to "pwm_pmic_backlight" so that the i915 driver can do a >>>> pwm_get() for the right controller depending on the VBT bit, instead of >>>> the i915 driver relying on a "pwm_backlight" lookup getting registered >>>> which magically points to the right controller. >>>> >>>> Signed-off-by: Hans de Goede >>>> --- >>>> drivers/mfd/intel_soc_pmic_core.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> For my own reference: >>> Acked-for-MFD-by: Lee Jones >> >> As mentioned in the cover-letter, to avoid breaking bi-sectability >> as well as to avoid breaking the intel-gfx CI we need to merge this series >> in one go through one tree. Specifically through the drm-intel tree. >> Is that ok with you ? >> >> If this is ok with you, then you do not have to do anything, I will just push >> the entire series to drm-intel. drivers/mfd/intel_soc_pmic_core.c >> does not see much changes so I do not expect this to lead to any conflicts. > > It's fine, so long as a minimal immutable pull-request is provided. > Whether it's pulled or not will depend on a number of factors, but it > needs to be an option. The way the drm subsys works that is not really a readily available option. The struct definition which this patch changes a single line in has not been touched since 2015-06-26 so I really doubt we will get a conflict from this. Regards, Hans _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B93C00454 for ; Thu, 12 Dec 2019 14:34:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DB5E2067C for ; Thu, 12 Dec 2019 14:34:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="OguXM/3J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DB5E2067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D1AB36E1BD; Thu, 12 Dec 2019 14:34:41 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id C3FAA6E1AA for ; Thu, 12 Dec 2019 14:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576161279; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8L0wh57USWeg4kwDbaH2LaCzisTmsJPLc/9WAOqxji8=; b=OguXM/3J8LGWIicHGD40uEHW5+9RlEj7anvHDGN5dszY5qvpRfCTf4DVdyWZ6JLmG4maxY s50+p22i/xY/WilnnIePcY+kiEpfMA7dRKTrSP4AAmwlNwz5OwHiQdiFYNmYYuneT90qPg BLwyjtAOrCrTHOmQ3R5tFDh7cuRmyQM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-Ugy0xJDDObuwuuyn4AiSpg-1; Thu, 12 Dec 2019 09:34:37 -0500 Received: by mail-wr1-f71.google.com with SMTP id t3so1091334wrm.23 for ; Thu, 12 Dec 2019 06:34:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8L0wh57USWeg4kwDbaH2LaCzisTmsJPLc/9WAOqxji8=; b=kDg8fu6w0kbDiJ1ZwLGcDFyBU2ef/MUlyLf/0KK2ialxqhReK8Hj5yOayBhdyQWMql 9bFcTkcQPzoklXkGtuzQsK9Om65iRRU4dqFZdGjQf8hdk/3o5RvycFth5tN7AZOzRTMl IrIEjL3lb0ZrqLKpfyNu6ZhHZtRjqB6nkmCu0TvcpNoSus/f/ykhTjcckTBkqlftwaKu E/V8yiDrNnF319sOUOtaxDBlwG9rXs41mWiWaunhSlQSL3t1y5hBNTaaEgvYDFAjqTP5 Dd1GsL6F/DA/EMFa7CMYSR/IarTMM7QqaHFt/cJzL2bIUWURA/RQCU1SUfCrI2BwjLzJ WAHA== X-Gm-Message-State: APjAAAUzEbJML2OVXyUsl7i+KY5UQ1kuBl3eDJxE3lK9c1uDE6hookzr VFoOr3GBB2FadSPBmDq82aGX7mulVT3yEV0gLWYl0I7fRNE39po3YKUTp6Ovr3hcohrjovQzc4T wS8WK/YWpVDFgRLwJzo0HR6zefTQU X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr7132899wme.151.1576161276515; Thu, 12 Dec 2019 06:34:36 -0800 (PST) X-Google-Smtp-Source: APXvYqwkMCbj3Al3W02aKWsSaIJItyyUbz24oMkL+40mFm8mAw2FfNeYRrpFtQxw5vg9q9Dyq+2PYg== X-Received: by 2002:a1c:a9c6:: with SMTP id s189mr7132870wme.151.1576161276268; Thu, 12 Dec 2019 06:34:36 -0800 (PST) Received: from shalem.localdomain (2001-1c00-0c0c-fe00-7e79-4dac-39d0-9c14.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:7e79:4dac:39d0:9c14]) by smtp.gmail.com with ESMTPSA id y20sm6009145wmi.25.2019.12.12.06.34.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 06:34:35 -0800 (PST) To: Lee Jones References: <20191119151818.67531-1-hdegoede@redhat.com> <20191119151818.67531-3-hdegoede@redhat.com> <20191210085111.GQ3468@dell> <20191212084546.GA3468@dell> From: Hans de Goede Message-ID: Date: Thu, 12 Dec 2019 15:34:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191212084546.GA3468@dell> Content-Language: en-US X-MC-Unique: Ugy0xJDDObuwuuyn4AiSpg-1 X-Mimecast-Spam-Score: 0 Subject: Re: [Intel-gfx] [PATCH 2/3] mfd: intel_soc_pmic: Rename pwm_backlight pwm-lookup to pwm_pmic_backlight X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org, Andy Shevchenko , Len Brown Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 12-12-2019 09:45, Lee Jones wrote: > On Wed, 11 Dec 2019, Hans de Goede wrote: > >> Hi Lee, >> >> On 10-12-2019 09:51, Lee Jones wrote: >>> On Tue, 19 Nov 2019, Hans de Goede wrote: >>> >>>> At least Bay Trail (BYT) and Cherry Trail (CHT) devices can use 1 of 2 >>>> different PWM controllers for controlling the LCD's backlight brightness. >>>> >>>> Either the one integrated into the PMIC or the one integrated into the >>>> SoC (the 1st LPSS PWM controller). >>>> >>>> So far in the LPSS code on BYT we have skipped registering the LPSS PWM >>>> controller "pwm_backlight" lookup entry when a Crystal Cove PMIC is >>>> present, assuming that in this case the PMIC PWM controller will be used. >>>> >>>> On CHT we have been relying on only 1 of the 2 PWM controllers being >>>> enabled in the DSDT at the same time; and always registered the lookup. >>>> >>>> So far this has been working, but the correct way to determine which PWM >>>> controller needs to be used is by checking a bit in the VBT table and >>>> recently I've learned about 2 different BYT devices: >>>> Point of View MOBII TAB-P800W >>>> Acer Switch 10 SW5-012 >>>> >>>> Which use a Crystal Cove PMIC, yet the LCD is connected to the SoC/LPSS >>>> PWM controller (and the VBT correctly indicates this), so here our old >>>> heuristics fail. >>>> >>>> Since only the i915 driver has access to the VBT, this commit renames >>>> the "pwm_backlight" lookup entries for the Crystal Cove PMIC's PWM >>>> controller to "pwm_pmic_backlight" so that the i915 driver can do a >>>> pwm_get() for the right controller depending on the VBT bit, instead of >>>> the i915 driver relying on a "pwm_backlight" lookup getting registered >>>> which magically points to the right controller. >>>> >>>> Signed-off-by: Hans de Goede >>>> --- >>>> drivers/mfd/intel_soc_pmic_core.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> For my own reference: >>> Acked-for-MFD-by: Lee Jones >> >> As mentioned in the cover-letter, to avoid breaking bi-sectability >> as well as to avoid breaking the intel-gfx CI we need to merge this series >> in one go through one tree. Specifically through the drm-intel tree. >> Is that ok with you ? >> >> If this is ok with you, then you do not have to do anything, I will just push >> the entire series to drm-intel. drivers/mfd/intel_soc_pmic_core.c >> does not see much changes so I do not expect this to lead to any conflicts. > > It's fine, so long as a minimal immutable pull-request is provided. > Whether it's pulled or not will depend on a number of factors, but it > needs to be an option. The way the drm subsys works that is not really a readily available option. The struct definition which this patch changes a single line in has not been touched since 2015-06-26 so I really doubt we will get a conflict from this. Regards, Hans _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx