From: David Daney <ddaney@caviumnetworks.com>
To: David Daney <david.daney@cavium.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtc: isl12026: Add driver.
Date: Mon, 12 Feb 2018 11:03:30 -0800 [thread overview]
Message-ID: <d2337554-c3df-f915-72c7-5decd571f12f@caviumnetworks.com> (raw)
In-Reply-To: <20180212185915.25041-1-david.daney@cavium.com>
On 02/12/2018 10:59 AM, David Daney wrote:
> The ISL12026 is a combination RTC and EEPROM device with I2C
> interface. The standard RTC driver interface is provided. The EEPROM
> is accessed via the NVMEM interface via the "eeprom0" directory in the
> sysfs entry for the device.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
> ---
> .../devicetree/bindings/rtc/isil,isl12026.txt | 27 +
> drivers/rtc/Kconfig | 9 +
> drivers/rtc/Makefile | 1 +
> drivers/rtc/rtc-isl12026.c | 550 +++++++++++++++++++++
> 4 files changed, 587 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/isil,isl12026.txt
> create mode 100644 drivers/rtc/rtc-isl12026.c
>
> diff --git a/Documentation/devicetree/bindings/rtc/isil,isl12026.txt b/Documentation/devicetree/bindings/rtc/isil,isl12026.txt
> new file mode 100644
> index 000000000000..4b6c7177a95a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/isil,isl12026.txt
> @@ -0,0 +1,27 @@
> +ISL12026 I2C RTC/EEPROM
> +
> +ISL12026 is an I2C RTC/EEPROM combination device. The RTC and control
> +registers respond at bus address 0x6f, and the EEPROM array responds
> +at bus address 0x57. The canonical "reg" value will be for the RTC portion.
> +
> +Required properties supported by the device:
> +
> + - "compatible": must be "isil,isl12026"
> + - "reg": I2C bus address of the device (always 0x6f)
> +
> +Optional properties:
> +
> + - "isil,pwr-bsw": If present PWR.BSW bit must be set to the specified
> + value for proper operation.
> +
> + - "isil,pwr-sbib": If present PWR.SBIB bit must be set to the specified
> + value for proper operation.
> +
> +
> +Example:
> +
> + rtc@6f {
Two seconds after sending, I see that the compatible went missing.
I will wait several days for feedback and resubmit with the proper
compatible
Sorry for the snafu,
David Daney
> + reg = <0x6f>;
> + isil,pwr-bsw = <0>;
> + isil,pwr-sbib = <1>;
> + }
>
next prev parent reply other threads:[~2018-02-12 19:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-12 18:59 [PATCH] rtc: isl12026: Add driver David Daney
2018-02-12 19:03 ` David Daney [this message]
2018-02-13 15:54 ` Andy Shevchenko
2018-02-13 15:54 ` Andy Shevchenko
2018-02-13 23:06 ` David Daney
2018-02-13 23:06 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2337554-c3df-f915-72c7-5decd571f12f@caviumnetworks.com \
--to=ddaney@caviumnetworks.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=david.daney@cavium.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.