From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A520BC76191 for ; Wed, 24 Jul 2019 18:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F0A621951 for ; Wed, 24 Jul 2019 18:29:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="qJvAUJJ6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387642AbfGXS3E (ORCPT ); Wed, 24 Jul 2019 14:29:04 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:52626 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387457AbfGXS3D (ORCPT ); Wed, 24 Jul 2019 14:29:03 -0400 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6OISwE4043548; Wed, 24 Jul 2019 13:28:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563992938; bh=kkHnXtzzzeveag6HtGf6rzEhUFlSnwH+G6IbEdhhZHs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=qJvAUJJ6BeXA3d+1gnFjvUjokpSVTurr0c9Tq44x+BEZ5CoT+T7qPDcWwKAEqTTNI +5domutxZZBkM0+fCW9sjH0kJA6p2g4Fs7kVPDtuaX8RrvgA0trYWQRuCnuzpIQjAx ZbhBV/3NfgIJOGbQHj65sQmhNOzKQt1F903KSewA= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6OISw5P019356 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Jul 2019 13:28:58 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 24 Jul 2019 13:28:57 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jul 2019 13:28:57 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6OISvcL125813; Wed, 24 Jul 2019 13:28:57 -0500 Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc To: Tony Lindgren , Keerthy CC: , Jyri Sarha , Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Tero Kristo , , References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-3-tony@atomide.com> <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> <20190724063110.GT5447@atomide.com> From: Suman Anna Message-ID: Date: Wed, 24 Jul 2019 13:28:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190724063110.GT5447@atomide.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/24/19 1:31 AM, Tony Lindgren wrote: > * Keerthy [190724 05:50]: >> >> On 24/07/19 12:33 AM, Suman Anna wrote: >>> + Jyri >>> >>> On 7/23/19 6:28 AM, Tony Lindgren wrote: >>>> We currently get a warning for lcdc because of a difference >>>> with dts provided configuration compared to the legacy platform >>>> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in >>>> the platform data without configuring the modes. >>> >>> Hi Tony, >>> While I understand that you are trying to match the DT data with the >>> existing legacy data, do you know if there was a reason why this was >>> omitted in the first place? Should we be really adding the MSTANDBY_ >>> flags and fix up the DTS node accordingly? I tried looking through the >>> git log, and the initial commit itself didn't add the MSTANDBY_ flags >>> but used the SYSC_HAS_MIDLEMODE. > > Yes the goal is to get rid of all errors and warnings in dmesg output > so we can spot the real issues. > >>> Jyri, >>> Do you know the history? >> >> Tony/Suman, >> >> This patch breaks DS0 on am3. > > OK thanks for testing. Let's drop this for now, sounds like there is > some midlemode configuration happening even with no flags set. You were dropping the ti,sysc-midle property in patch 8, is that still ok without this patch? > > Probably the right fix is to configure the usable midlemodes instead > both for platform data and dts data and then drop the platform data. Yeah, that's probably better and more accurate unless we actually have some h/w issues that require them to be dropped. regards Suman > > Regards, > > Tony > > > >>>> Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that >>>> the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. >>> >>> >>> >>>> >>>> Signed-off-by: Tony Lindgren >>>> --- >>>> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { >>>> static struct omap_hwmod_class_sysconfig lcdc_sysc = { >>>> .rev_offs = 0x0, >>>> .sysc_offs = 0x54, >>>> - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), >>>> + .sysc_flags = SYSC_HAS_SIDLEMODE, >>>> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >>>> .sysc_fields = &omap_hwmod_sysc_type2, >>>> }; >>>> >>> From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suman Anna Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc Date: Wed, 24 Jul 2019 13:28:57 -0500 Message-ID: References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-3-tony@atomide.com> <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> <20190724063110.GT5447@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190724063110.GT5447@atomide.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren , Keerthy Cc: linux-omap@vger.kernel.org, Jyri Sarha , Dave Gerlach , Faiz Abbas , Greg Kroah-Hartman , Nishanth Menon , Peter Ujfalusi , Roger Quadros , Tero Kristo , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org On 7/24/19 1:31 AM, Tony Lindgren wrote: > * Keerthy [190724 05:50]: >> >> On 24/07/19 12:33 AM, Suman Anna wrote: >>> + Jyri >>> >>> On 7/23/19 6:28 AM, Tony Lindgren wrote: >>>> We currently get a warning for lcdc because of a difference >>>> with dts provided configuration compared to the legacy platform >>>> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in >>>> the platform data without configuring the modes. >>> >>> Hi Tony, >>> While I understand that you are trying to match the DT data with the >>> existing legacy data, do you know if there was a reason why this was >>> omitted in the first place? Should we be really adding the MSTANDBY_ >>> flags and fix up the DTS node accordingly? I tried looking through the >>> git log, and the initial commit itself didn't add the MSTANDBY_ flags >>> but used the SYSC_HAS_MIDLEMODE. > > Yes the goal is to get rid of all errors and warnings in dmesg output > so we can spot the real issues. > >>> Jyri, >>> Do you know the history? >> >> Tony/Suman, >> >> This patch breaks DS0 on am3. > > OK thanks for testing. Let's drop this for now, sounds like there is > some midlemode configuration happening even with no flags set. You were dropping the ti,sysc-midle property in patch 8, is that still ok without this patch? > > Probably the right fix is to configure the usable midlemodes instead > both for platform data and dts data and then drop the platform data. Yeah, that's probably better and more accurate unless we actually have some h/w issues that require them to be dropped. regards Suman > > Regards, > > Tony > > > >>>> Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that >>>> the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. >>> >>> >>> >>>> >>>> Signed-off-by: Tony Lindgren >>>> --- >>>> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { >>>> static struct omap_hwmod_class_sysconfig lcdc_sysc = { >>>> .rev_offs = 0x0, >>>> .sysc_offs = 0x54, >>>> - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), >>>> + .sysc_flags = SYSC_HAS_SIDLEMODE, >>>> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >>>> .sysc_fields = &omap_hwmod_sysc_type2, >>>> }; >>>> >>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93812C76186 for ; Wed, 24 Jul 2019 18:29:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6377C21911 for ; Wed, 24 Jul 2019 18:29:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="urQ8JVzY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ti.com header.i=@ti.com header.b="qJvAUJJ6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6377C21911 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JORTCH8Fcol5UpRcWFE9En2lzfovIWE9k04jtM7Fk5M=; b=urQ8JVzYMsaGHA TVWH4Ldb1vCdCGpWxDsjdhGjNjg+mSyFXo5EtXCUnR0+yXyAJxentK+w6+EDEYKLsBoT5uP6nOEwU F02IalGt3sPaa1rgwaytzev0szfs0rcukSKE6uiX8xItvT/EPW9LYRatL/VLaDpeCPX/x2gDEkeQO /s7+XQDIZAs5qH1G9M8wPnCRObXQ3y7PJs1YPG1rkmZV5iT73boCMC39FJpMhLIQ46fdanWc51wpE L5KU362NU/mLIboCYYv9lGmWDHDSpOntYuUyKZiJFD0i4g7owSFZh3F+GaxOhuYPAqhT8yuh6L1VA qYY8wGWSwFYrHXRnebbQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hqM0e-0005EF-Qn; Wed, 24 Jul 2019 18:29:04 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hqM0b-0005Do-Bw for linux-arm-kernel@lists.infradead.org; Wed, 24 Jul 2019 18:29:03 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x6OISwE4043548; Wed, 24 Jul 2019 13:28:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1563992938; bh=kkHnXtzzzeveag6HtGf6rzEhUFlSnwH+G6IbEdhhZHs=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=qJvAUJJ6BeXA3d+1gnFjvUjokpSVTurr0c9Tq44x+BEZ5CoT+T7qPDcWwKAEqTTNI +5domutxZZBkM0+fCW9sjH0kJA6p2g4Fs7kVPDtuaX8RrvgA0trYWQRuCnuzpIQjAx ZbhBV/3NfgIJOGbQHj65sQmhNOzKQt1F903KSewA= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x6OISw5P019356 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 24 Jul 2019 13:28:58 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Wed, 24 Jul 2019 13:28:57 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Wed, 24 Jul 2019 13:28:57 -0500 Received: from [128.247.58.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id x6OISvcL125813; Wed, 24 Jul 2019 13:28:57 -0500 Subject: Re: [PATCH 2/8] ARM: OMAP2+: Remove unconfigured midlemode for am3 lcdc To: Tony Lindgren , Keerthy References: <20190723112811.44381-1-tony@atomide.com> <20190723112811.44381-3-tony@atomide.com> <52328e14-58b2-2ea1-8b0a-33548a1c6a7a@ti.com> <20190724063110.GT5447@atomide.com> From: Suman Anna Message-ID: Date: Wed, 24 Jul 2019 13:28:57 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190724063110.GT5447@atomide.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190724_112901_571230_8A26F292 X-CRM114-Status: GOOD ( 22.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nishanth Menon , Tero Kristo , Dave Gerlach , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Jyri Sarha , Peter Ujfalusi , Faiz Abbas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/24/19 1:31 AM, Tony Lindgren wrote: > * Keerthy [190724 05:50]: >> >> On 24/07/19 12:33 AM, Suman Anna wrote: >>> + Jyri >>> >>> On 7/23/19 6:28 AM, Tony Lindgren wrote: >>>> We currently get a warning for lcdc because of a difference >>>> with dts provided configuration compared to the legacy platform >>>> data. This is because lcdc has SYSC_HAS_MIDLEMODE configured in >>>> the platform data without configuring the modes. >>> >>> Hi Tony, >>> While I understand that you are trying to match the DT data with the >>> existing legacy data, do you know if there was a reason why this was >>> omitted in the first place? Should we be really adding the MSTANDBY_ >>> flags and fix up the DTS node accordingly? I tried looking through the >>> git log, and the initial commit itself didn't add the MSTANDBY_ flags >>> but used the SYSC_HAS_MIDLEMODE. > > Yes the goal is to get rid of all errors and warnings in dmesg output > so we can spot the real issues. > >>> Jyri, >>> Do you know the history? >> >> Tony/Suman, >> >> This patch breaks DS0 on am3. > > OK thanks for testing. Let's drop this for now, sounds like there is > some midlemode configuration happening even with no flags set. You were dropping the ti,sysc-midle property in patch 8, is that still ok without this patch? > > Probably the right fix is to configure the usable midlemodes instead > both for platform data and dts data and then drop the platform data. Yeah, that's probably better and more accurate unless we actually have some h/w issues that require them to be dropped. regards Suman > > Regards, > > Tony > > > >>>> Let's fix the warning by removing SYSC_HAS_MIDLEMODE. Note that >>>> the am335x TRM lists SYSC_HAS_MIDLEMODE, but it is unused. >>> >>> >>> >>>> >>>> Signed-off-by: Tony Lindgren >>>> --- >>>> arch/arm/mach-omap2/omap_hwmod_33xx_data.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_data.c >>>> @@ -231,7 +231,7 @@ static struct omap_hwmod am33xx_control_hwmod = { >>>> static struct omap_hwmod_class_sysconfig lcdc_sysc = { >>>> .rev_offs = 0x0, >>>> .sysc_offs = 0x54, >>>> - .sysc_flags = (SYSC_HAS_SIDLEMODE | SYSC_HAS_MIDLEMODE), >>>> + .sysc_flags = SYSC_HAS_SIDLEMODE, >>>> .idlemodes = (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART), >>>> .sysc_fields = &omap_hwmod_sysc_type2, >>>> }; >>>> >>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel