From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2F23C433ED for ; Wed, 28 Apr 2021 22:57:22 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA38261440 for ; Wed, 28 Apr 2021 22:57:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA38261440 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FVvCg6lDTz300c for ; Thu, 29 Apr 2021 08:57:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Iu0FpC+K; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.vnet.ibm.com (client-ip=148.163.158.5; helo=mx0a-001b2d01.pphosted.com; envelope-from=gmills@linux.vnet.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=Iu0FpC+K; dkim-atps=neutral Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FVvCB3j6lz2xZR for ; Thu, 29 Apr 2021 08:56:53 +1000 (AEST) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 13SMierZ017872; Wed, 28 Apr 2021 18:56:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=RwiGZbppi5LfqIcI/ncUAaBOo08GcgKUIhlmP75dJgo=; b=Iu0FpC+KfIssjbneASsZf0jU/Rg8CwRXFOvS6px6PM0KaqzPQoK6eVcb5nq09e9FByz+ 6JHz4T+BOv08fwBMykQFx+ow5cjleOnajAFtvJzGKSuher5KoxNQPBEc8ocmAL2ytySA YjY2aV12oqfXjCX5mP54jtBY0dcGI64nu0LUL+wzquq9UpSIcVjjZ8QQdCCeFIV9vHIW d7Kw61Wgt6lSJCvJz07QwqwbGs2zTvLqZku8meZBh8zjcv02XJ1vlE3EkY7xWDL/isC8 7GETOJFY9WkM43k0DOPEUrD1U6wZE14dfhYGKN/GzcYNee8nCBhrd5tKXU/t3BlIVuMx oA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 387grur6u0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 18:56:49 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 13SMm9VD029206; Wed, 28 Apr 2021 18:56:49 -0400 Received: from ppma02wdc.us.ibm.com (aa.5b.37a9.ip4.static.sl-reverse.com [169.55.91.170]) by mx0b-001b2d01.pphosted.com with ESMTP id 387grur6tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 18:56:49 -0400 Received: from pps.filterd (ppma02wdc.us.ibm.com [127.0.0.1]) by ppma02wdc.us.ibm.com (8.16.0.43/8.16.0.43) with SMTP id 13SMcj6m015010; Wed, 28 Apr 2021 22:56:48 GMT Received: from b03cxnp08026.gho.boulder.ibm.com (b03cxnp08026.gho.boulder.ibm.com [9.17.130.18]) by ppma02wdc.us.ibm.com with ESMTP id 384aya0b7a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 28 Apr 2021 22:56:48 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08026.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 13SMultv19005844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 28 Apr 2021 22:56:47 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9BDEE6A054; Wed, 28 Apr 2021 22:56:47 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 651E96A051; Wed, 28 Apr 2021 22:56:45 +0000 (GMT) Received: from [9.206.162.87] (unknown [9.206.162.87]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Wed, 28 Apr 2021 22:56:44 +0000 (GMT) Subject: Re: Move Inventory.Item.Board from Redfish Chassis to Redfish Assembly To: Ed Tanous References:

From: Gunnar Mills Message-ID: Date: Wed, 28 Apr 2021 16:56:42 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: HrsBxCNgS0LZimBMeOy1X0QLAa2nk48S X-Proofpoint-GUID: cpxDVRoeKOYlSpcK06orMXRDFgl0KVv2 Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-04-28_17:2021-04-28, 2021-04-28 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 mlxscore=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104060000 definitions=main-2104280144 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "openbmc@lists.ozlabs.org" , Ed Tanous , Derick , "Bills, Jason M" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On 4/28/2021 1:44 PM, Ed Tanous wrote: >>> On Wed, Apr 28, 2021 at 9:18 AM Gunnar Mills wrote: >>>> >>>> From some discussion on Discord a few weeks ago. A newer way of >>>> thinking in Redfish is for a simple rack server to just have one Redfish >>>> Chassis and things like boards modeled as Redfish Assemblies under the >>>> Chassis. Today we look for inventory item chassis and inventory >>>> item board to populate the Chassis collection. I propose we move >>>> the "Inventory.Item.Board" from Redfish Chassis to Redfish Assembly. >>> > > Here's an example of something that's type Board that creates sensors. > https://github.com/openbmc/entity-manager/blob/master/configurations/A2UL16RISER.json > There are several more like this. From follow-on discussion in Discord this afternoon. Today the sensors to board association (e.g. the riser card above with sensors) is "chassis"/"all_sensor. It should be "inventory"/"sensors" (Association Type #2: Linking a low-level hardware item to its sensors [a]). Redfish has a "RelatedItem" property on the Sensor schema. To populate the "RelatedItem" property we will use Association Type #2. This is the first step to moving Inventory.Item.Board to a Redfish Assembly, this is to ensure no relationships are lost. [a]https://github.com/openbmc/docs/blob/919a7b6816a5f16aa72d298e81e0756d95d5031e/architecture/sensor-architecture.md#association-type-2-linking-a-low-level-hardware-item-to-its-sensors > > I don't mean to throw up roadblocks, and I definitely don't know what > the solution is here, but we'll need to solve it before something like > this can go through. > We further discussed how staging this change might work, it probably involves a compile flag for some time and separately adding Inventory.Item.Board to Assembly and later removing from Chassis. Gunnar