From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Tue, 11 Sep 2018 12:12:53 +0200 Subject: [U-Boot] [PATCH v3 01/26] fs: fat: guard the content of include/fat.h In-Reply-To: <20180911065922.19141-2-takahiro.akashi@linaro.org> References: <20180911065922.19141-1-takahiro.akashi@linaro.org> <20180911065922.19141-2-takahiro.akashi@linaro.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11.09.18 08:58, Akashi, Takahiro wrote: > From: AKASHI Takahiro > > The whole content of include/fat.h is private to FAT implementation > and then should be guarded with CONFIG_FS_FAT. > > Signed-off-by: AKASHI Takahiro I thought we could drop this patch now? If you really need it, please state why in the patch description and make sure to include common.h before you do the #ifdef on CONFIG_FS_FAT. Otherwise the symbol might not be declared. Alex > --- > include/fat.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/fat.h b/include/fat.h > index 09e142368585..c02839dcb040 100644 > --- a/include/fat.h > +++ b/include/fat.h > @@ -9,6 +9,8 @@ > #ifndef _FAT_H_ > #define _FAT_H_ > > +#ifdef CONFIG_FS_FAT > + > #include > #include > > @@ -202,4 +204,5 @@ int fat_opendir(const char *filename, struct fs_dir_stream **dirsp); > int fat_readdir(struct fs_dir_stream *dirs, struct fs_dirent **dentp); > void fat_closedir(struct fs_dir_stream *dirs); > void fat_close(void); > +#endif /* CONFIG_FS_FAT */ > #endif /* _FAT_H_ */ >