Re: [PATCH net-next 0/7] Devlink health updates

From: Eran Ben Elisha <eranbe@mellanox.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Jiri Pirko <jiri@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Moshe Shemesh <moshe@mellanox.com>
Subject: Re: [PATCH net-next 0/7] Devlink health updates
Date: Wed, 23 Jan 2019 12:34:15 +0000	[thread overview]
Message-ID: <d275ab10-ecda-9df6-8f70-21caa017ca70@mellanox.com> (raw)
In-Reply-To: <20190123114452.GE2191@nanopsycho>

On 1/23/2019 1:44 PM, Jiri Pirko wrote:
> Tue, Jan 22, 2019 at 04:57:17PM CET, eranbe@mellanox.com wrote:
>> This patchset fixes some comments that were received for the devlink
>> health series, mostly around the devlink health buffers API.
>>
>> It offers a new devlink<->driver API for passing health dump and diagnose info.
>> As part of this patchset, the new API is developed and integrated into the
>> devlink health and mlx5e TX reporter.
>> Also, added some helpers together with the new API, which reduce the code
>> required by the driver to fill dump and diagnose significantly.
>>
>> Eventually, it also deletes the old API.
>>
>> In addition, it includes some small fixes in the devlink and mlx5e TX reporter.
> 
> We are (re-)defining UAPI here. You need to present some examples
> of devlink tool output, both in json and stdout.

Actually we don't really redefining the section, but only having naming 
change, DEVLINK_ATTR_HEALTH_BUFFER_OBJECT* to DEVLINK_ATTR_MSG_OBJECT*. 
It is pretty much the same in UAPI perspective. All examples from 
original patchset are still 100% true.

> Again, much more convenient to be done for the whole patchset, not this
> "fixup-one" :/

The core of the change you have asked for it fully implemented in patch 
0001 (and will be kept as is if I would do the re-done procedure). Me 
and Moshe had an internal review yesterday and it doesn't look like a 
nightmare at all.

Please try to give it a real try as I worked a lot in order to meet the 
DD set here, and if you still find it really hard, let me know.

> 
> 
>>
>>
>> Eran Ben Elisha (7):
>>   devlink: Add devlink msg API
>>   net/mlx5e: Move driver to use devlink msg API
>>   devlink: move devlink health reporter to use devlink msg API
>>   devlink: Delete depracated health buffers API
>>   devlink: Remove spaces around "=" in the logger print
>>   devlink: Fix use-after-free at reporter destroy
>>   net/mlx5e: Add RTNL lock to TX recover flow
>>
>> .../mellanox/mlx5/core/en/reporter_tx.c       | 124 +---
>> include/net/devlink.h                         |  79 +--
>> include/trace/events/devlink.h                |   2 +-
>> include/uapi/linux/devlink.h                  |  14 +-
>> net/core/devlink.c                            | 633 ++++++++----------
>> 5 files changed, 342 insertions(+), 510 deletions(-)
>>
>> -- 
>> 2.17.1
>>