From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1BE2C49ED9 for ; Tue, 10 Sep 2019 20:37:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA1992168B for ; Tue, 10 Sep 2019 20:37:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="OmWwFMcJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbfIJUhC (ORCPT ); Tue, 10 Sep 2019 16:37:02 -0400 Received: from esa2.hc3370-68.iphmx.com ([216.71.145.153]:3967 "EHLO esa2.hc3370-68.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725770AbfIJUhC (ORCPT ); Tue, 10 Sep 2019 16:37:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568147822; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=PQX2XV0vVmXhFIlKkjJKf1ji0vclOmRYdx+xosldAik=; b=OmWwFMcJRffOs7x6PgZIi7HA+X/HEr71iHlB58m4kNVK5RPtHb/IHrRp ttCeyMpnH5SgIcQViN+jfGmAWCvTlSRdmxIxSzrphZqyAuWTb/ESY5tnn 5sUX4OjZL6P5DYwkoaoR9zvaSjGwSpe5JqOPnZPEYRdVdaZDF8zP0H5ZL 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 6Al88nOj1y14/m72nAPf2nC7ggByJ2zYOOvHJNU1oXsjAIBEiR/C874dTwKtkLpjZpv6rXgHoc ZJv97sDCDMsd3wl8d8fOQyB+45HsExWuOF/bAdF0ALhdHkwCvc5BRttBJ4e4fLlf+W7s5lyysC U//fmTRFSSWr+1wW3hTwV+lANEQeXGewhsOHK0ggRqsRfUPGkdVg7g5MIekcziJnEDXqAsmvdU yIE7w5F2BItYpD8bGXoFdznrXrZ7zPegfobWq0SDLsUCsGpG4MUfNSEtUJqfS5mL6Zc7GWG9vH 43M= X-SBRS: 2.7 X-MesageID: 5399823 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,490,1559534400"; d="scan'208";a="5399823" Subject: Re: [Xen-devel] [PATCH] xen/pci: try to reserve MCFG areas earlier To: Boris Ostrovsky , , CC: References: <1567556431-9809-1-git-send-email-igor.druzhinin@citrix.com> <5054ad91-5b87-652c-873a-b31758948bd7@oracle.com> <43b7da04-5c42-80d8-898b-470ee1c91ed2@oracle.com> <1695c88d-e5ad-1854-cdef-3cd95c812574@oracle.com> <4d3bf854-51de-99e4-9a40-a64c581bdd10@citrix.com> <43e492ff-f967-7218-65c4-d16581fabea3@oracle.com> <416ff4b7-3186-f61a-75fa-bcfc968f8117@citrix.com> From: Igor Druzhinin Message-ID: Date: Tue, 10 Sep 2019 21:36:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/09/2019 18:48, Boris Ostrovsky wrote: > On 9/10/19 5:46 AM, Igor Druzhinin wrote: >> On 10/09/2019 02:47, Boris Ostrovsky wrote: >>> On 9/9/19 5:48 PM, Igor Druzhinin wrote: >>>> On 09/09/2019 20:19, Boris Ostrovsky wrote: >>>> >>>>> The other question I have is why you think it's worth keeping >>>>> xen_mcfg_late() as a late initcall. How could MCFG info be updated >>>>> between acpi_init() and late_initcalls being run? I'd think it can only >>>>> happen when a new device is hotplugged. >>>>> >>>> It was a precaution against setup_mcfg_map() calls that might add new >>>> areas that are not in MCFG table but for some reason have _CBA method. >>>> It's obviously a "firmware is broken" scenario so I don't have strong >>>> feelings to keep it here. Will prefer to remove in v2 if you want. >>> Isn't setup_mcfg_map() called before the first xen_add_device() which is where you are calling xen_mcfg_late()? >>> >> setup_mcfg_map() calls are done in order of root bus discovery which >> happens *after* the previous root bus has been enumerated. So the order >> is: call setup_mcfg_map() for root bus 0, find that >> pci_mmcfg_late_init() has finished MCFG area registration, perform PCI >> enumeration of bus 0, call xen_add_device() for every device there, call >> setup_mcfg_map() for root bus X, etc. > > Ah, yes. Multiple busses. > > If that's the case then why don't we need to call xen_mcfg_late() for > the first device on each bus? > Ideally, yes - we'd like to call it for every bus discovered. But boot time buses are already in MCFG (otherwise system boot might not simply work as Jan pointed out) so it's not strictly required. The only case is a potential PCI bus hot-plug but I'm not sure it actually works in practice and we certainly didn't support it before. It might be solved theoretically by subscribing to acpi_bus_type that is available after acpi_init(). Igor From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5A62C49ED7 for ; Tue, 10 Sep 2019 20:37:31 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AE38421479 for ; Tue, 10 Sep 2019 20:37:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=citrix.com header.i=@citrix.com header.b="OmWwFMcJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AE38421479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i7msq-0004Ht-Ac; Tue, 10 Sep 2019 20:37:04 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i7mso-0004Ho-Qc for xen-devel@lists.xenproject.org; Tue, 10 Sep 2019 20:37:02 +0000 X-Inumbo-ID: bdd45f94-d40a-11e9-ac21-12813bfff9fa Received: from esa2.hc3370-68.iphmx.com (unknown [216.71.145.153]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id bdd45f94-d40a-11e9-ac21-12813bfff9fa; Tue, 10 Sep 2019 20:37:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1568147822; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=PQX2XV0vVmXhFIlKkjJKf1ji0vclOmRYdx+xosldAik=; b=OmWwFMcJRffOs7x6PgZIi7HA+X/HEr71iHlB58m4kNVK5RPtHb/IHrRp ttCeyMpnH5SgIcQViN+jfGmAWCvTlSRdmxIxSzrphZqyAuWTb/ESY5tnn 5sUX4OjZL6P5DYwkoaoR9zvaSjGwSpe5JqOPnZPEYRdVdaZDF8zP0H5ZL 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=igor.druzhinin@citrix.com; spf=Pass smtp.mailfrom=igor.druzhinin@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of igor.druzhinin@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa2.hc3370-68.iphmx.com: domain of igor.druzhinin@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="igor.druzhinin@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa2.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa2.hc3370-68.iphmx.com; envelope-from="igor.druzhinin@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: 6Al88nOj1y14/m72nAPf2nC7ggByJ2zYOOvHJNU1oXsjAIBEiR/C874dTwKtkLpjZpv6rXgHoc ZJv97sDCDMsd3wl8d8fOQyB+45HsExWuOF/bAdF0ALhdHkwCvc5BRttBJ4e4fLlf+W7s5lyysC U//fmTRFSSWr+1wW3hTwV+lANEQeXGewhsOHK0ggRqsRfUPGkdVg7g5MIekcziJnEDXqAsmvdU yIE7w5F2BItYpD8bGXoFdznrXrZ7zPegfobWq0SDLsUCsGpG4MUfNSEtUJqfS5mL6Zc7GWG9vH 43M= X-SBRS: 2.7 X-MesageID: 5399823 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.64,490,1559534400"; d="scan'208";a="5399823" To: Boris Ostrovsky , , References: <1567556431-9809-1-git-send-email-igor.druzhinin@citrix.com> <5054ad91-5b87-652c-873a-b31758948bd7@oracle.com> <43b7da04-5c42-80d8-898b-470ee1c91ed2@oracle.com> <1695c88d-e5ad-1854-cdef-3cd95c812574@oracle.com> <4d3bf854-51de-99e4-9a40-a64c581bdd10@citrix.com> <43e492ff-f967-7218-65c4-d16581fabea3@oracle.com> <416ff4b7-3186-f61a-75fa-bcfc968f8117@citrix.com> From: Igor Druzhinin Message-ID: Date: Tue, 10 Sep 2019 21:36:58 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Subject: Re: [Xen-devel] [PATCH] xen/pci: try to reserve MCFG areas earlier X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: jgross@suse.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" T24gMTAvMDkvMjAxOSAxODo0OCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOgo+IE9uIDkvMTAvMTkg NTo0NiBBTSwgSWdvciBEcnV6aGluaW4gd3JvdGU6Cj4+IE9uIDEwLzA5LzIwMTkgMDI6NDcsIEJv cmlzIE9zdHJvdnNreSB3cm90ZToKPj4+IE9uIDkvOS8xOSA1OjQ4IFBNLCBJZ29yIERydXpoaW5p biB3cm90ZToKPj4+PiBPbiAwOS8wOS8yMDE5IDIwOjE5LCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6 Cj4+Pj4KPj4+Pj4gVGhlIG90aGVyIHF1ZXN0aW9uIEkgaGF2ZSBpcyB3aHkgeW91IHRoaW5rIGl0 J3Mgd29ydGgga2VlcGluZwo+Pj4+PiB4ZW5fbWNmZ19sYXRlKCkgYXMgYSBsYXRlIGluaXRjYWxs LiBIb3cgY291bGQgTUNGRyBpbmZvIGJlIHVwZGF0ZWQKPj4+Pj4gYmV0d2VlbiBhY3BpX2luaXQo KSBhbmQgbGF0ZV9pbml0Y2FsbHMgYmVpbmcgcnVuPyBJJ2QgdGhpbmsgaXQgY2FuIG9ubHkKPj4+ Pj4gaGFwcGVuIHdoZW4gYSBuZXcgZGV2aWNlIGlzIGhvdHBsdWdnZWQuCj4+Pj4+Cj4+Pj4gSXQg d2FzIGEgcHJlY2F1dGlvbiBhZ2FpbnN0IHNldHVwX21jZmdfbWFwKCkgY2FsbHMgdGhhdCBtaWdo dCBhZGQgbmV3Cj4+Pj4gYXJlYXMgdGhhdCBhcmUgbm90IGluIE1DRkcgdGFibGUgYnV0IGZvciBz b21lIHJlYXNvbiBoYXZlIF9DQkEgbWV0aG9kLgo+Pj4+IEl0J3Mgb2J2aW91c2x5IGEgImZpcm13 YXJlIGlzIGJyb2tlbiIgc2NlbmFyaW8gc28gSSBkb24ndCBoYXZlIHN0cm9uZwo+Pj4+IGZlZWxp bmdzIHRvIGtlZXAgaXQgaGVyZS4gV2lsbCBwcmVmZXIgdG8gcmVtb3ZlIGluIHYyIGlmIHlvdSB3 YW50Lgo+Pj4gSXNuJ3Qgc2V0dXBfbWNmZ19tYXAoKSBjYWxsZWQgYmVmb3JlIHRoZSBmaXJzdCB4 ZW5fYWRkX2RldmljZSgpIHdoaWNoIGlzIHdoZXJlIHlvdSBhcmUgY2FsbGluZyB4ZW5fbWNmZ19s YXRlKCk/Cj4+Pgo+PiBzZXR1cF9tY2ZnX21hcCgpIGNhbGxzIGFyZSBkb25lIGluIG9yZGVyIG9m IHJvb3QgYnVzIGRpc2NvdmVyeSB3aGljaAo+PiBoYXBwZW5zICphZnRlciogdGhlIHByZXZpb3Vz IHJvb3QgYnVzIGhhcyBiZWVuIGVudW1lcmF0ZWQuIFNvIHRoZSBvcmRlcgo+PiBpczogY2FsbCBz ZXR1cF9tY2ZnX21hcCgpIGZvciByb290IGJ1cyAwLCBmaW5kIHRoYXQKPj4gcGNpX21tY2ZnX2xh dGVfaW5pdCgpIGhhcyBmaW5pc2hlZCBNQ0ZHIGFyZWEgcmVnaXN0cmF0aW9uLCBwZXJmb3JtIFBD SQo+PiBlbnVtZXJhdGlvbiBvZiBidXMgMCwgY2FsbCB4ZW5fYWRkX2RldmljZSgpIGZvciBldmVy eSBkZXZpY2UgdGhlcmUsIGNhbGwKPj4gc2V0dXBfbWNmZ19tYXAoKSBmb3Igcm9vdCBidXMgWCwg ZXRjLgo+IAo+IEFoLCB5ZXMuIE11bHRpcGxlIGJ1c3Nlcy4KPiAKPiBJZiB0aGF0J3MgdGhlIGNh c2UgdGhlbiB3aHkgZG9uJ3Qgd2UgbmVlZCB0byBjYWxsIHhlbl9tY2ZnX2xhdGUoKSBmb3IKPiB0 aGUgZmlyc3QgZGV2aWNlIG9uIGVhY2ggYnVzPwo+IAoKSWRlYWxseSwgeWVzIC0gd2UnZCBsaWtl IHRvIGNhbGwgaXQgZm9yIGV2ZXJ5IGJ1cyBkaXNjb3ZlcmVkLiBCdXQgYm9vdAp0aW1lIGJ1c2Vz IGFyZSBhbHJlYWR5IGluIE1DRkcgKG90aGVyd2lzZSBzeXN0ZW0gYm9vdCBtaWdodCBub3Qgc2lt cGx5CndvcmsgYXMgSmFuIHBvaW50ZWQgb3V0KSBzbyBpdCdzIG5vdCBzdHJpY3RseSByZXF1aXJl ZC4gVGhlIG9ubHkgY2FzZSBpcwphIHBvdGVudGlhbCBQQ0kgYnVzIGhvdC1wbHVnIGJ1dCBJJ20g bm90IHN1cmUgaXQgYWN0dWFsbHkgd29ya3MgaW4KcHJhY3RpY2UgYW5kIHdlIGNlcnRhaW5seSBk aWRuJ3Qgc3VwcG9ydCBpdCBiZWZvcmUuIEl0IG1pZ2h0IGJlIHNvbHZlZAp0aGVvcmV0aWNhbGx5 IGJ5IHN1YnNjcmliaW5nIHRvIGFjcGlfYnVzX3R5cGUgdGhhdCBpcyBhdmFpbGFibGUgYWZ0ZXIK YWNwaV9pbml0KCkuCgpJZ29yCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW5wcm9q ZWN0Lm9yZwpodHRwczovL2xpc3RzLnhlbnByb2plY3Qub3JnL21haWxtYW4vbGlzdGluZm8veGVu LWRldmVs