From: Jens Axboe <axboe@kernel.dk>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] fs: remove kiocb.ki_hint
Date: Mon, 21 Mar 2022 20:13:10 -0600 [thread overview]
Message-ID: <d28979ca-2433-01b0-a764-1288e5909421@kernel.dk> (raw)
In-Reply-To: <164678732353.405180.15951772868993926898.b4-ty@kernel.dk>
On 3/8/22 5:55 PM, Jens Axboe wrote:
> On Tue, 8 Mar 2022 07:05:28 +0100, Christoph Hellwig wrote:
>> This field is entirely unused now except for a tracepoint in f2fs, so
>> remove it.
>>
>>
>
> Applied, thanks!
>
> [1/2] fs: remove kiocb.ki_hint
> commit: 41d36a9f3e5336f5b48c3adba0777b8e217020d7
> [2/2] fs: remove fs.f_write_hint
> commit: 7b12e49669c99f63bc12351c57e581f1f14d4adf
Upon thinking about the EINVAL solution a bit more, I do have a one
worry - if you're currently using write_hints in your application,
nobody should expect upgrading the kernel to break it. It's a fine
solution for anything else, but that particular point does annoy me.
So perhaps it is better after all to simply pretend we set the
hint just fine? That should always be safe.
What do you think?
--
Jens Axboe
next prev parent reply other threads:[~2022-03-22 2:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-08 6:05 remove write hint leftovers v2 Christoph Hellwig
2022-03-08 6:05 ` [PATCH 1/2] fs: remove kiocb.ki_hint Christoph Hellwig
2022-03-08 22:19 ` Chaitanya Kulkarni
2022-03-08 23:09 ` Dave Chinner
2022-03-09 0:55 ` Jens Axboe
2022-03-22 2:13 ` Jens Axboe [this message]
2022-03-22 2:45 ` Matthew Wilcox
2022-03-22 2:50 ` Jens Axboe
2022-03-22 2:57 ` Keith Busch
2022-03-22 3:00 ` Jens Axboe
2022-03-08 6:05 ` [PATCH 2/2] fs: remove fs.f_write_hint Christoph Hellwig
2022-03-08 22:20 ` Chaitanya Kulkarni
2022-03-08 23:11 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2022-03-07 10:46 remove write hint leftovers Christoph Hellwig
2022-03-07 10:47 ` [PATCH 1/2] fs: remove kiocb.ki_hint Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d28979ca-2433-01b0-a764-1288e5909421@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.