From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1A77C433F5 for ; Tue, 22 Feb 2022 12:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbiBVMbz convert rfc822-to-8bit (ORCPT ); Tue, 22 Feb 2022 07:31:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231915AbiBVMbs (ORCPT ); Tue, 22 Feb 2022 07:31:48 -0500 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04E53109A49; Tue, 22 Feb 2022 04:31:22 -0800 (PST) Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.73 with qID 21MCVB9d8030888, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36504.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.71/5.88) with ESMTPS id 21MCVB9d8030888 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 22 Feb 2022 20:31:11 +0800 Received: from RTEXMBS03.realtek.com.tw (172.21.6.96) by RTEXH36504.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 20:31:11 +0800 Received: from RTEXDAG01.realtek.com.tw (172.21.6.100) by RTEXMBS03.realtek.com.tw (172.21.6.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 22 Feb 2022 20:31:10 +0800 Received: from RTEXDAG01.realtek.com.tw ([fe80::5c14:59a9:7ec4:ef5]) by RTEXDAG01.realtek.com.tw ([fe80::5c14:59a9:7ec4:ef5%6]) with mapi id 15.01.2308.021; Tue, 22 Feb 2022 20:31:10 +0800 From: Ricky WU To: "gregkh@linuxfoundation.org" CC: "ulf.hansson@linaro.org" , "kai.heng.feng@canonical.com" , "tommyhebb@gmail.com" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] mmc: rtsx: add 74 Clocks in power on flow Thread-Topic: [PATCH] mmc: rtsx: add 74 Clocks in power on flow Thread-Index: AQHYJ7nTpeKajlBmYU+vTOb/+dRQe6yeqeWAgACTEED//4JngIAAveNw Date: Tue, 22 Feb 2022 12:31:10 +0000 Message-ID: References: <90844cba1cb64571a8597a6e0afee01d@realtek.com> In-Reply-To: Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.81.103] x-kse-serverinfo: RTEXMBS03.realtek.com.tw, 9 x-kse-attachmentfiltering-interceptor-info: no applicable attachment filtering rules found x-kse-antivirus-interceptor-info: scan successful x-kse-antivirus-info: =?us-ascii?Q?Clean,_bases:_2022/2/22_=3F=3F_10:05:00?= x-kse-bulkmessagesfiltering-scan-result: protection disabled Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-KSE-ServerInfo: RTEXH36504.realtek.com.tw, 9 X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: protection disabled Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: gregkh@linuxfoundation.org > Sent: Tuesday, February 22, 2022 4:59 PM > To: Ricky WU > Cc: ulf.hansson@linaro.org; kai.heng.feng@canonical.com; > tommyhebb@gmail.com; linux-mmc@vger.kernel.org; > linux-kernel@vger.kernel.org > Subject: Re: [PATCH] mmc: rtsx: add 74 Clocks in power on flow > > On Tue, Feb 22, 2022 at 08:48:30AM +0000, Ricky WU wrote: > > > -----Original Message----- > > > From: gregkh@linuxfoundation.org > > > Sent: Tuesday, February 22, 2022 3:42 PM > > > To: Ricky WU > > > Cc: ulf.hansson@linaro.org; kai.heng.feng@canonical.com; > > > tommyhebb@gmail.com; linux-mmc@vger.kernel.org; > > > linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH] mmc: rtsx: add 74 Clocks in power on flow > > > > > > On Tue, Feb 22, 2022 at 07:27:52AM +0000, Ricky WU wrote: > > > > After 1ms stabilizing the voltage time add "Host provides at least > > > > 74 Clocks before issuing first command" that is spec definition > > > > > > You do have 72 columns to use here, no need to wrap this so tightly. > > > > > > > Ok... > > so I need to have next patch to fix this format? > > Please do, because: > > > > > > > > > > > Signed-off-by: Ricky Wu > > > > --- > > > > drivers/mmc/host/rtsx_pci_sdmmc.c | 7 +++++++ > > > > 1 file changed, 7 insertions(+) > > > > > > > > diff --git a/drivers/mmc/host/rtsx_pci_sdmmc.c > > > > b/drivers/mmc/host/rtsx_pci_sdmmc.c > > > > index 2a3f14afe9f8..e016d720e453 100644 > > > > --- a/drivers/mmc/host/rtsx_pci_sdmmc.c > > > > +++ b/drivers/mmc/host/rtsx_pci_sdmmc.c > > > > @@ -940,10 +940,17 @@ static int sd_power_on(struct > > > > realtek_pci_sdmmc > > > *host) > > > > if (err < 0) > > > > return err; > > > > > > > > + mdelay(1); > > > > > > What is this delay for? > > > > > > > Spec definition, need to wait 1ms for voltage stable and below > > mdelay(5) is our device send 74 Clocks time > > Clock cycles and mdelay() are not going to always stay the same, right? > > I really have no idea what "74 clocks time" means, is this some specific timing > value for this hardware? What is the units? This needs to be documented > better in both the changelog and in the code. > > thanks, > Please ref: https://www.sdcard.org/downloads/pls/ Version8 And see the 6.4.1.2 Power Up Time of Host Figure 6-5: Power Up Diagram of Host mdelay(1) corresponds to Stable supply voltage mdelay(5) corresponds to Host provides at least 74 Clocks before issuing first command our device need 5ms to issue 74 Clocks > greg k-h > ------Please consider the environment before printing this e-mail.