All of lore.kernel.org
 help / color / mirror / Atom feed
From: guanjunxiong@huawei.com (Guan Junxiong)
Subject: [PATCH V2] nvme: make use of nvme error status codes in block layer
Date: Tue, 18 Apr 2017 19:35:13 +0800	[thread overview]
Message-ID: <d28d14b3-7627-7490-8312-09ecae3addef@huawei.com> (raw)
In-Reply-To: <20170418080854.GA21059@infradead.org>



On 2017/4/18 16:08, Christoph Hellwig wrote:
> NAK.  Please don't start exposing random error codes to the block
> layer.  There are a few (very few) with special meaning in the block
> layer, mostly just for multipathing.  If you have an actual,
> demonstrated need for those we can add it.  Otherwise you're just
> creating noise.
> 
> .
> 

Thanks for your reply which makes sense.  We really need to let dm-multipath
make use of the nvme error codes. Current all error codes are converted to EIO
except NVME_SC_CAP_EXCEEDED, which means almost IO are retried on other path.

If some nvme error codes such as NVME_SC_WRITE_FAULT,NVME_SC_READ_ERROR
into -ENODATA so that it will not retry to save bandwith. Does it make sense?

      reply	other threads:[~2017-04-18 11:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-17 13:15 [PATCH V2] nvme: make use of nvme error status codes in block layer Guan Junxiong
2017-04-17 16:45 ` J Freyensee
2017-04-18  0:32   ` Guan Junxiong
2017-04-18  8:08 ` Christoph Hellwig
2017-04-18 11:35   ` Guan Junxiong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d28d14b3-7627-7490-8312-09ecae3addef@huawei.com \
    --to=guanjunxiong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.