From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v5 14/14] staging: typec: tcpci: move tcpci driver out of staging References: <1525307094-27402-1-git-send-email-jun.li@nxp.com> <1525307094-27402-15-git-send-email-jun.li@nxp.com> From: Mats Karrman Message-ID: Date: Fri, 11 May 2018 23:37:27 +0200 MIME-Version: 1.0 In-Reply-To: <1525307094-27402-15-git-send-email-jun.li@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US To: Li Jun , robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com List-ID: Hi Li Jun, This patch takes away building the entire staging/typec tree but this is still not empty after your patch, another driver "tcpci_rt1711h" is there. Better just remove tcpci from staging/typec/{Kconfig,Makefile} // Mats On 2018-05-03 02:24, Li Jun wrote: > Move TCPCI(Typec port controller interface) driver out of staging. > > Signed-off-by: Li Jun > --- > drivers/staging/Kconfig | 2 -- > drivers/staging/Makefile | 1 - > drivers/staging/typec/TODO | 5 ----- > drivers/usb/typec/Kconfig | 7 +++++++ > drivers/usb/typec/Makefile | 1 + > drivers/{staging => usb}/typec/tcpci.c | 0 > drivers/{staging => usb}/typec/tcpci.h | 0 > 7 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig > index d5926f0..d83ff66 100644 > --- a/drivers/staging/Kconfig > +++ b/drivers/staging/Kconfig > @@ -112,8 +112,6 @@ source "drivers/staging/greybus/Kconfig" > > source "drivers/staging/vc04_services/Kconfig" > > -source "drivers/staging/typec/Kconfig" > - > source "drivers/staging/vboxvideo/Kconfig" > > source "drivers/staging/pi433/Kconfig" > diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile > index 919753c..a71ec1f 100644 > --- a/drivers/staging/Makefile > +++ b/drivers/staging/Makefile > @@ -2,7 +2,6 @@ > # Makefile for staging directory > > obj-y += media/ > -obj-y += typec/ > obj-$(CONFIG_IPX) += ipx/ > obj-$(CONFIG_NCP_FS) += ncpfs/ > obj-$(CONFIG_PRISM2_USB) += wlan-ng/ > diff --git a/drivers/staging/typec/TODO b/drivers/staging/typec/TODO > deleted file mode 100644 > index 53fe2f7..0000000 > --- a/drivers/staging/typec/TODO > +++ /dev/null > @@ -1,5 +0,0 @@ > -tcpci: > -- Test with real hardware > - > -Please send patches to Guenter Roeck and copy > -Heikki Krogerus . > diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig > index 2c8eab1..0a862fc 100644 > --- a/drivers/usb/typec/Kconfig > +++ b/drivers/usb/typec/Kconfig > @@ -56,6 +56,13 @@ config TYPEC_TCPM > > if TYPEC_TCPM > > +config TYPEC_TCPCI > + tristate "Type-C Port Controller Interface driver" > + depends on I2C > + select REGMAP_I2C > + help > + Type-C Port Controller driver for TCPCI-compliant controller. > + > source "drivers/usb/typec/fusb302/Kconfig" > > config TYPEC_WCOVE > diff --git a/drivers/usb/typec/Makefile b/drivers/usb/typec/Makefile > index 1f599a6..02758a1 100644 > --- a/drivers/usb/typec/Makefile > +++ b/drivers/usb/typec/Makefile > @@ -7,3 +7,4 @@ obj-$(CONFIG_TYPEC_WCOVE) += typec_wcove.o > obj-$(CONFIG_TYPEC_UCSI) += ucsi/ > obj-$(CONFIG_TYPEC_TPS6598X) += tps6598x.o > obj-$(CONFIG_TYPEC) += mux/ > +obj-$(CONFIG_TYPEC_TCPCI) += tcpci.o > diff --git a/drivers/staging/typec/tcpci.c b/drivers/usb/typec/tcpci.c > similarity index 100% > rename from drivers/staging/typec/tcpci.c > rename to drivers/usb/typec/tcpci.c > diff --git a/drivers/staging/typec/tcpci.h b/drivers/usb/typec/tcpci.h > similarity index 100% > rename from drivers/staging/typec/tcpci.h > rename to drivers/usb/typec/tcpci.h From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v5,14/14] staging: typec: tcpci: move tcpci driver out of staging From: Mats Karrman Message-Id: Date: Fri, 11 May 2018 23:37:27 +0200 To: Li Jun , robh+dt@kernel.org, gregkh@linuxfoundation.org, heikki.krogerus@linux.intel.com, linux@roeck-us.net Cc: a.hajda@samsung.com, cw00.choi@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com, gsomlo@gmail.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-imx@nxp.com List-ID: SGkgTGkgSnVuLAoKVGhpcyBwYXRjaCB0YWtlcyBhd2F5IGJ1aWxkaW5nIHRoZSBlbnRpcmUgc3Rh Z2luZy90eXBlYyB0cmVlIGJ1dCB0aGlzIGlzIHN0aWxsCm5vdCBlbXB0eSBhZnRlciB5b3VyIHBh dGNoLCBhbm90aGVyIGRyaXZlciAidGNwY2lfcnQxNzExaCIgaXMgdGhlcmUuCkJldHRlciBqdXN0 IHJlbW92ZSB0Y3BjaSBmcm9tIHN0YWdpbmcvdHlwZWMve0tjb25maWcsTWFrZWZpbGV9CgovLyBN YXRzCgpPbiAyMDE4LTA1LTAzIDAyOjI0LCBMaSBKdW4gd3JvdGU6Cgo+IE1vdmUgVENQQ0koVHlw ZWMgcG9ydCBjb250cm9sbGVyIGludGVyZmFjZSkgZHJpdmVyIG91dCBvZiBzdGFnaW5nLgo+Cj4g U2lnbmVkLW9mZi1ieTogTGkgSnVuIDxqdW4ubGlAbnhwLmNvbT4KPiAtLS0KPiAgIGRyaXZlcnMv c3RhZ2luZy9LY29uZmlnICAgICAgICAgICAgICAgIHwgMiAtLQo+ICAgZHJpdmVycy9zdGFnaW5n L01ha2VmaWxlICAgICAgICAgICAgICAgfCAxIC0KPiAgIGRyaXZlcnMvc3RhZ2luZy90eXBlYy9U T0RPICAgICAgICAgICAgIHwgNSAtLS0tLQo+ICAgZHJpdmVycy91c2IvdHlwZWMvS2NvbmZpZyAg ICAgICAgICAgICAgfCA3ICsrKysrKysKPiAgIGRyaXZlcnMvdXNiL3R5cGVjL01ha2VmaWxlICAg ICAgICAgICAgIHwgMSArCj4gICBkcml2ZXJzL3tzdGFnaW5nID0+IHVzYn0vdHlwZWMvdGNwY2ku YyB8IDAKPiAgIGRyaXZlcnMve3N0YWdpbmcgPT4gdXNifS90eXBlYy90Y3BjaS5oIHwgMAo+ICAg NyBmaWxlcyBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL0tjb25maWcgYi9kcml2ZXJzL3N0YWdpbmcvS2NvbmZp Zwo+IGluZGV4IGQ1OTI2ZjAuLmQ4M2ZmNjYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zdGFnaW5n L0tjb25maWcKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcvS2NvbmZpZwo+IEBAIC0xMTIsOCArMTEy LDYgQEAgc291cmNlICJkcml2ZXJzL3N0YWdpbmcvZ3JleWJ1cy9LY29uZmlnIgo+ICAgCj4gICBz b3VyY2UgImRyaXZlcnMvc3RhZ2luZy92YzA0X3NlcnZpY2VzL0tjb25maWciCj4gICAKPiAtc291 cmNlICJkcml2ZXJzL3N0YWdpbmcvdHlwZWMvS2NvbmZpZyIKPiAtCj4gICBzb3VyY2UgImRyaXZl cnMvc3RhZ2luZy92Ym94dmlkZW8vS2NvbmZpZyIKPiAgIAo+ICAgc291cmNlICJkcml2ZXJzL3N0 YWdpbmcvcGk0MzMvS2NvbmZpZyIKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL01ha2Vm aWxlIGIvZHJpdmVycy9zdGFnaW5nL01ha2VmaWxlCj4gaW5kZXggOTE5NzUzYy4uYTcxZWMxZiAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvTWFrZWZpbGUKPiArKysgYi9kcml2ZXJzL3N0 YWdpbmcvTWFrZWZpbGUKPiBAQCAtMiw3ICsyLDYgQEAKPiAgICMgTWFrZWZpbGUgZm9yIHN0YWdp bmcgZGlyZWN0b3J5Cj4gICAKPiAgIG9iai15CQkJCSs9IG1lZGlhLwo+IC1vYmoteQkJCQkrPSB0 eXBlYy8KPiAgIG9iai0kKENPTkZJR19JUFgpCQkrPSBpcHgvCj4gICBvYmotJChDT05GSUdfTkNQ X0ZTKQkJKz0gbmNwZnMvCj4gICBvYmotJChDT05GSUdfUFJJU00yX1VTQikJKz0gd2xhbi1uZy8K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL3R5cGVjL1RPRE8gYi9kcml2ZXJzL3N0YWdp bmcvdHlwZWMvVE9ETwo+IGRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAo+IGluZGV4IDUzZmUyZjcu LjAwMDAwMDAKPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvdHlwZWMvVE9ETwo+ICsrKyAvZGV2L251 bGwKPiBAQCAtMSw1ICswLDAgQEAKPiAtdGNwY2k6Cj4gLS0gVGVzdCB3aXRoIHJlYWwgaGFyZHdh cmUKPiAtCj4gLVBsZWFzZSBzZW5kIHBhdGNoZXMgdG8gR3VlbnRlciBSb2VjayA8bGludXhAcm9l Y2stdXMubmV0PiBhbmQgY29weQo+IC1IZWlra2kgS3JvZ2VydXMgPGhlaWtraS5rcm9nZXJ1c0Bs aW51eC5pbnRlbC5jb20+Lgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi90eXBlYy9LY29uZmln IGIvZHJpdmVycy91c2IvdHlwZWMvS2NvbmZpZwo+IGluZGV4IDJjOGVhYjEuLjBhODYyZmMgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvdHlwZWMvS2NvbmZpZwo+ICsrKyBiL2RyaXZlcnMvdXNi L3R5cGVjL0tjb25maWcKPiBAQCAtNTYsNiArNTYsMTMgQEAgY29uZmlnIFRZUEVDX1RDUE0KPiAg IAo+ICAgaWYgVFlQRUNfVENQTQo+ICAgCj4gK2NvbmZpZyBUWVBFQ19UQ1BDSQo+ICsJdHJpc3Rh dGUgIlR5cGUtQyBQb3J0IENvbnRyb2xsZXIgSW50ZXJmYWNlIGRyaXZlciIKPiArCWRlcGVuZHMg b24gSTJDCj4gKwlzZWxlY3QgUkVHTUFQX0kyQwo+ICsJaGVscAo+ICsJICBUeXBlLUMgUG9ydCBD b250cm9sbGVyIGRyaXZlciBmb3IgVENQQ0ktY29tcGxpYW50IGNvbnRyb2xsZXIuCj4gKwo+ICAg c291cmNlICJkcml2ZXJzL3VzYi90eXBlYy9mdXNiMzAyL0tjb25maWciCj4gICAKPiAgIGNvbmZp ZyBUWVBFQ19XQ09WRQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi90eXBlYy9NYWtlZmlsZSBi L2RyaXZlcnMvdXNiL3R5cGVjL01ha2VmaWxlCj4gaW5kZXggMWY1OTlhNi4uMDI3NThhMSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL3VzYi90eXBlYy9NYWtlZmlsZQo+ICsrKyBiL2RyaXZlcnMvdXNi L3R5cGVjL01ha2VmaWxlCj4gQEAgLTcsMyArNyw0IEBAIG9iai0kKENPTkZJR19UWVBFQ19XQ09W RSkJKz0gdHlwZWNfd2NvdmUubwo+ICAgb2JqLSQoQ09ORklHX1RZUEVDX1VDU0kpCSs9IHVjc2kv Cj4gICBvYmotJChDT05GSUdfVFlQRUNfVFBTNjU5OFgpCSs9IHRwczY1OTh4Lm8KPiAgIG9iai0k KENPTkZJR19UWVBFQykJCSs9IG11eC8KPiArb2JqLSQoQ09ORklHX1RZUEVDX1RDUENJKQkrPSB0 Y3BjaS5vCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jIGIvZHJp dmVycy91c2IvdHlwZWMvdGNwY2kuYwo+IHNpbWlsYXJpdHkgaW5kZXggMTAwJQo+IHJlbmFtZSBm cm9tIGRyaXZlcnMvc3RhZ2luZy90eXBlYy90Y3BjaS5jCj4gcmVuYW1lIHRvIGRyaXZlcnMvdXNi L3R5cGVjL3RjcGNpLmMKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL3R5cGVjL3RjcGNp LmggYi9kcml2ZXJzL3VzYi90eXBlYy90Y3BjaS5oCj4gc2ltaWxhcml0eSBpbmRleCAxMDAlCj4g cmVuYW1lIGZyb20gZHJpdmVycy9zdGFnaW5nL3R5cGVjL3RjcGNpLmgKPiByZW5hbWUgdG8gZHJp dmVycy91c2IvdHlwZWMvdGNwY2kuaAotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6 IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBt ZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBh dCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==